From: strager <strager.nds@gmail.com>
To: Lancelot SIX <lsix@lancelotsix.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/tui: add 'set tui mouse-events off' to restore mouse selection
Date: Thu, 2 Feb 2023 03:11:10 -0800 [thread overview]
Message-ID: <CAC-ggsF3QGPiQ0EMU8eHq37_YKWjEj1sgOngARo-3rrFC-skHA@mail.gmail.com> (raw)
In-Reply-To: <20230202092950.tpxei5w4meutjeiv@ubuntu.lan>
On Thu, Feb 2, 2023 at 1:33 AM Lancelot SIX <lsix@lancelotsix.com> wrote:
>
> Hi,
>
> Thanks for working on this! I think I got used to use the "shift" key
> when I try to select, but soon might soon have "set tui mouse-events
> off" in my rc file.
I'm glad to hear my patch is useful to someone else!
I didn't know about the shift trick until *after* I submitted this patch. 😳
On Thu, Feb 2, 2023 at 1:33 AM Lancelot SIX <lsix@lancelotsix.com> wrote:
> - In GDB codebase, we use tab for indentation[1]:
>
> Lines should be indented with a mix of tabs and spaces. 8 spaces
> should be replaced with Tab.
>
> It looks like you patch uses spaces for indentation.
That's probably an issue with my mail client. The email attachment
patch file should have the proper tabs.
On Thu, Feb 2, 2023 at 1:33 AM Lancelot SIX <lsix@lancelotsix.com> wrote:
> -GDB prefers "nullptr" instead of "NULL".
I copied NULL from some other code in gdb, but I can change it if needed.
prev parent reply other threads:[~2023-02-02 11:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-28 0:42 strager
2023-01-28 8:35 ` Eli Zaretskii
2023-02-01 8:35 ` strager
2023-02-01 12:41 ` Eli Zaretskii
2023-02-01 13:27 ` Andrew Burgess
2023-02-02 1:08 ` strager
2023-02-02 7:18 ` Eli Zaretskii
2023-02-02 19:50 ` Pedro Alves
2023-02-02 19:59 ` strager
2023-09-14 8:05 ` strager
2023-09-20 15:39 ` Pedro Alves
2023-02-02 9:33 ` Lancelot SIX
2023-02-02 11:11 ` strager [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAC-ggsF3QGPiQ0EMU8eHq37_YKWjEj1sgOngARo-3rrFC-skHA@mail.gmail.com \
--to=strager.nds@gmail.com \
--cc=gdb-patches@sourceware.org \
--cc=lsix@lancelotsix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).