Re: [PATCH v5] gdb: Support embedded source in DWARF

[Will Hawkins <hawkinsw@obs.cr>]

On Fri, Apr 12, 2024 at 4:12 PM Tom de Vries <tdevries@suse.de> wrote:
>
> On 4/12/24 20:55, Will Hawkins wrote:
> > +         DW_LNE_set_address main_end
> > +         line [gdb_get_line_number "main end"]
> > +         DW_LNS_copy
> > +
> > +         DW_LNE_end_sequence
> > +     }
> I've just submitted a patch series designed to catch this (
> https://sourceware.org/pipermail/gdb-patches/2024-April/207922.html ).
>
> The copy produces a line table entry with empty address range (because
> the end_sequence is at the same address),.
>
> This is probably not what you intended.

What I get for doing copy/paste! A v6 is on its way! Thank you for the
eagle eyes!

On a semi-related note, it appears that "many" of the dwarf2 tests do
not properly specify

add_dummy_cus 0

in their invocation of Dwarf::assemble resulting in two CUs being
generated in the .S file. This does not appear to cause problems for
the tests, but if you run the generated binaries through a "dwarf
validator", e.g., llvm-dwarfdump, they will report errors. I have
requested an account on the gdb bugzilla to report a bug and will file
a related patch as a fix, if that is okay with you?

Will

>
> Thanks,
> - Tom
>