From: Orgad Shaneh <orgads@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Support MSYS platform
Date: Sun, 3 Mar 2024 11:46:53 +0200 [thread overview]
Message-ID: <CAGHpTBKgOkQjproOa1D80yhYQermhAsyMWOzm8YFDrfL7FhkBg@mail.gmail.com> (raw)
In-Reply-To: <86msrfofre.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 2601 bytes --]
On Sun, Mar 3, 2024 at 10:56 AM Eli Zaretskii <eliz@gnu.org> wrote:
> > From: Orgad Shaneh <orgads@gmail.com>
> > Cc: Orgad Shaneh <orgads@gmail.com>
> > Date: Sun, 3 Mar 2024 09:58:58 +0200
> >
> > From: Orgad Shaneh <orgads@gmail.com>
> >
> > Apply MSYS patches upstream.
>
> Thanks. Please find a few comments below.
>
Thanks for the review.
But before that: what exactly is the MSYS target, and how does it
> differ from MinGW and Cygwin targets?
>
See https://www.msys2.org/docs/what-is-msys2/
It is based on Cygwin, but focuses on support for native Windows apps.
It also features a decent package manager, which Cygwin doesn't.
In addition, I think this warrants a NEWS entry (both for Binutils and
> for GDB).
>
Done.
> diff --git a/configure b/configure
> > index dd743c58663..51c7d7b0b20 100755
> > --- a/configure
> > +++ b/configure
> > @@ -1534,12 +1534,12 @@ Optional Features:
> > --disable-FEATURE do not include FEATURE (same as
> --enable-FEATURE=no)
> > --enable-FEATURE[=ARG] include FEATURE [ARG=yes]
> > --enable-as-accelerator-for=ARG
> > - build as offload target compiler. Specify
> offload
> > + build as offload target compiler.
> Specify offload
> > host triple by ARG
> > --enable-offload-targets=LIST
> > enable offloading to devices from
> comma-separated
> > - LIST of TARGET[=DIR]. Use optional path to
> find
> > - offload target compiler during the build
> > + LIST of
> TARGET[=DIR]. Use optional path to find
> > + offload target compiler
> during the build
> > --enable-offload-defaulted
>
> What are those ^M (CR) characters, here and elsewhere? Looks like
> some artifact of the way you produced the diffs?
>
Looks like a bug in autoreconf on MSYS2. I reran it now on Linux.
> > @@ -4502,7 +4503,7 @@ cat confdefs.h - <<_ACEOF >conftest.$ac_ext
> > /* end confdefs.h. */
> >
> > int
> > -main ()
> > +main (void)
> > {
>
> Why is this needed? Did you use some version of Autotools that
> produces these differences?
>
Possibly. Reverted now.
General comment: some of the sources patched in this series are
> maintained elsewhere: Readline is maintained by Bash, Libtool is
> maintained by its own project, etc. So I expect you will need to
> submit the relevant parts to their upstream projects.
>
Ok, thanks.
- Orgad
next prev parent reply other threads:[~2024-03-03 9:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-03 7:58 Orgad Shaneh
2024-03-03 8:56 ` Eli Zaretskii
2024-03-03 9:46 ` Orgad Shaneh [this message]
2024-03-03 10:57 ` Eli Zaretskii
2024-03-03 11:04 ` Orgad Shaneh
2024-03-03 9:43 ` [PATCH] Support MSYS2 platform Orgad Shaneh
2024-03-03 10:54 ` Eli Zaretskii
2024-03-03 11:06 ` Orgad Shaneh
2024-03-03 11:07 ` Orgad Shaneh
2024-03-08 17:36 ` Tom Tromey
2024-03-08 19:41 ` Eli Zaretskii
2024-03-09 20:47 ` Orgad Shaneh
2024-03-10 14:27 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGHpTBKgOkQjproOa1D80yhYQermhAsyMWOzm8YFDrfL7FhkBg@mail.gmail.com \
--to=orgads@gmail.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).