From: Aaron Merey <amerey@redhat.com>
To: Tom Tromey <tom@tromey.com>
Cc: Aaron Merey via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH v4] gdb/debuginfod: Improve progress updates
Date: Thu, 10 Nov 2022 12:20:46 -0500 [thread overview]
Message-ID: <CAJDtP-QCYVgk_tCpHGxOETQ2akDM6PVquZQET7GLTjr+jv7QWA@mail.gmail.com> (raw)
In-Reply-To: <87mt8z28xy.fsf@tromey.com>
On Wed, Nov 9, 2022 at 3:02 PM Tom Tromey <tom@tromey.com> wrote:
>
> This patch is ok.
Thanks Tom, pushed as commit 27859c6b9d73.
I made a small change to this patch before pushing. If gdb's width
is set to unlimited, we now just print a static description of the
download. No progress bar will be printed, same as if the screen
width was too narrow for the progress bar or batch mode was
enabled. I updated the commit message to reflect this change.
Previously if gdb's width was unlimited we'd set the progress bar
width to maximum (4k characters), however this caused some
visual noise in the gdb.debuginfod test log. To avoid any
unintentionally huge progress bars I think it's better to only display
them when a definite screen width is known.
Aaron
prev parent reply other threads:[~2022-11-10 17:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-07 23:46 [PING*3][PATCH v4] gdb: Improve debuginfod " Aaron Merey
2022-10-12 18:53 ` Aaron Merey
2022-10-12 22:02 ` Alexandra Petlanova Hajkova
2022-10-12 22:02 ` Alexandra Petlanova Hajkova
2022-10-21 16:42 ` [PING*4][PATCH " Aaron Merey
2022-10-21 20:01 ` Tom Tromey
2022-10-26 3:17 ` [PATCH v4] gdb/debuginfod: Improve " Aaron Merey
2022-11-09 20:02 ` Tom Tromey
2022-11-10 17:20 ` Aaron Merey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJDtP-QCYVgk_tCpHGxOETQ2akDM6PVquZQET7GLTjr+jv7QWA@mail.gmail.com \
--to=amerey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).