Re: [PATCH 1/4 v7] gdb: Buffer output streams during events that might download debuginfo

[Aaron Merey <amerey@redhat.com>]

Hi Thiago,

On Tue, Dec 26, 2023 at 11:29 AM Thiago Jung Bauermann
<thiago.bauermann@linaro.org> wrote:
>
> Nice feature! Just a few small nits:

Thanks for reviewing this patch set. I've updated the patch set
with your suggestions. The revised patches have been posted
here: https://sourceware.org/pipermail/gdb-patches/2024-January/205953.html

> > --- a/gdb/testsuite/gdb.python/py-objfile.exp
> > +++ b/gdb/testsuite/gdb.python/py-objfile.exp
> > @@ -135,7 +135,7 @@ gdb_test "p main" "= {<text variable, no debug info>} $hex <main>" \
> >  gdb_py_test_silent_cmd "python objfile.add_separate_debug_file(\"${binfile}\")" \
> >      "Add separate debug file file" 1
> >
> > -gdb_py_test_silent_cmd "python sep_objfile = gdb.objfiles()\[0\]" \
> > +gdb_py_test_silent_cmd "python sep_objfile = gdb.objfiles()\[1\]" \
> >      "Get separate debug info objfile" 1
>
> Does the fact that this testcase needed change mean that there was an
> API break? In my opinion it doesn't and this patch is ok. I think it
> would be too much to guarantee a specific ordering of the returned
> objfiles.
>
> But I'm mentioning it anyway because perhaps someone has a different
> view?

I agree that it's too much to guarantee a specific ordering of the
objfiles list. I did not change objfile ordering in the revised patches.

Aaron