From: Aaron Merey <amerey@redhat.com>
To: Andrew Burgess <aburgess@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/7 v3] gdb/debuginfod: Add debuginfod_section_query
Date: Mon, 2 Oct 2023 14:07:08 -0400 [thread overview]
Message-ID: <CAJDtP-RKoyHSjE-p65pKxJ9eyhsWOOts8B8BFBj3WurDZR7ezg@mail.gmail.com> (raw)
In-Reply-To: <87y1gqup8t.fsf@redhat.com>
On Thu, Sep 28, 2023 at 2:28 PM Andrew Burgess <aburgess@redhat.com> wrote:
>
> Aaron Merey <amerey@redhat.com> writes:
> >
> > +scoped_fd
> > +debuginfod_section_query (const unsigned char *build_id,
> > + int build_id_len,
> > + const char *filename,
> > + const char *section_name,
> > + gdb::unique_xmalloc_ptr<char> *destname)
> > +{
> > +#if !defined (HAVE_LIBDEBUGINFOD_FIND_SECTION)
> > + return scoped_fd (-ENOSYS);
> > +#else
> > +
> > + if (!debuginfod_is_enabled ())
>
> This line is under-indented by one space :)
>
> Otherwise:
>
> Approved-By: Andrew Burgess <aburgess@redhat.com>
Thanks, pushed as commit 8546d15b
Aaron
next prev parent reply other threads:[~2023-10-02 18:07 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-16 4:42 [PATCH 0/7] gdb/debuginfod: Add on-demand debuginfo downloading Aaron Merey
2023-08-16 4:42 ` [PATCH 1/7] config/debuginfod.m4: Add check for libdebuginfod 0.188 Aaron Merey
2023-09-19 14:33 ` Aaron Merey
2023-09-27 10:28 ` Nick Clifton
2023-09-27 19:14 ` Aaron Merey
2023-08-16 4:42 ` [PATCH 2/7 v3] gdb/debuginfod: Add debuginfod_section_query Aaron Merey
2023-09-19 14:33 ` Aaron Merey
2023-09-28 18:28 ` Andrew Burgess
2023-10-02 18:07 ` Aaron Merey [this message]
2023-08-16 4:42 ` [PATCH 3/7 v3] gdb: Add command 'maint set/show debuginfod download-sections' Aaron Merey
2023-08-16 12:45 ` Eli Zaretskii
2023-09-19 14:34 ` Aaron Merey
2023-09-28 18:32 ` Andrew Burgess
2023-10-02 18:08 ` Aaron Merey
2023-08-16 4:42 ` [PATCH 4/7 v5] gdb: Buffer output streams during events that might download debuginfo Aaron Merey
2023-09-19 14:34 ` Aaron Merey
2023-10-10 21:55 ` [PATCH v6] " Aaron Merey
2023-10-24 11:22 ` Andrew Burgess
2023-10-28 0:25 ` Aaron Merey
2023-08-16 4:42 ` [PATCH 5/7 v2] gdb/progspace: Add reverse safe iterator and template for unwrapping iterator Aaron Merey
2023-09-19 14:35 ` Aaron Merey
2023-10-10 21:56 ` [PING*2][PATCH " Aaron Merey
2023-08-16 4:42 ` [PATCH 6/7 v4] gdb/debuginfod: Support on-demand debuginfo downloading Aaron Merey
2023-09-19 14:35 ` Aaron Merey
2023-10-10 21:57 ` [PING*2][PATCH " Aaron Merey
2023-08-16 4:42 ` [PATCH 7/7 v4] gdb/debuginfod: Add .debug_line downloading Aaron Merey
2023-09-19 14:35 ` Aaron Merey
2023-10-10 21:58 ` [PING*2][PATCH " Aaron Merey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJDtP-RKoyHSjE-p65pKxJ9eyhsWOOts8B8BFBj3WurDZR7ezg@mail.gmail.com \
--to=amerey@redhat.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).