public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Aaron Merey <amerey@redhat.com>
To: Andrew Burgess <aburgess@redhat.com>
Cc: Aaron Merey via Gdb-patches <gdb-patches@sourceware.org>, tom@tromey.com
Subject: Re: [PATCH 4/7 v2] gdb: Buffer output during print_thread and print_frame_info
Date: Wed, 24 May 2023 15:05:33 -0400	[thread overview]
Message-ID: <CAJDtP-TqX=-Qfo79nX-NHz89yyC5OzxrRvaug895gmkka-uzPw@mail.gmail.com> (raw)
In-Reply-To: <87v8gi6p7p.fsf@redhat.com>

On Wed, May 24, 2023 at 5:41 AM Andrew Burgess <aburgess@redhat.com> wrote:
>
> I guess I would have expected some new tests in this commit.  Is there
> any reason why we couldn't write a test here?

My rationale was that existing tests which check the correctness of frame and
thread printing should suffice. However we are missing a test checking that
debuginfod progress output does not occur within frame/thread info (like
the example in the commit message describes).

I will include a test for this to the patch that adds section downloading since
progress messages during frame/thread printing can only occur with section
downloads.

Aaron


      reply	other threads:[~2023-05-24 19:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-17 18:05 Aaron Merey
2023-05-02 14:25 ` Aaron Merey
2023-05-09 13:47   ` [PING*2][PATCH " Aaron Merey
2023-05-16 14:49     ` [PING*3][PATCH " Aaron Merey
2023-05-23 20:56       ` [PING*4][PATCH " Aaron Merey
2023-05-24  9:41 ` [PATCH " Andrew Burgess
2023-05-24 19:05   ` Aaron Merey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJDtP-TqX=-Qfo79nX-NHz89yyC5OzxrRvaug895gmkka-uzPw@mail.gmail.com' \
    --to=amerey@redhat.com \
    --cc=aburgess@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).