Re: [PATCH] Rename SEARCH_ALL

[Alexandra Petlanova Hajkova <ahajkova@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1245 bytes --]

On Mon, Jan 29, 2024 at 5:47 PM Tom Tromey <tromey@adacore.com> wrote:

> The constant SEARCH_ALL conflicts with a define in a Windows header.
> This patch renames the constant to SEARCH_ALL_DOMAINS to avoid the
> conflict.
>
> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31307
> ---
>  gdb/ada-lang.c                      | 2 +-
>  gdb/compile/compile-cplus-symbols.c | 2 +-
>  gdb/python/py-symbol.c              | 2 +-
>  gdb/symfile-debug.c                 | 4 ++--
>  gdb/symmisc.c                       | 2 +-
>  gdb/symtab.c                        | 2 +-
>  gdb/symtab.h                        | 4 ++--
>  7 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c
> index f1d01ec7aa3..52bae581af6 100644
> --- a/gdb/ada-lang.c
> +++ b/gdb/ada-lang.c
> @@ -13533,7 +13533,7 @@ class ada_language : public language_defn
>                              NULL,
>                              NULL,
>                              SEARCH_GLOBAL_BLOCK | SEARCH_STATIC_BLOCK,
> -                            SEARCH_ALL);
> +                            SEARCH_ALL_DOMAINS);
>
>
I can  confirm this change does not introduce any regressions for aarch64
Fedora Rawhide.