From: Alexandra Petlanova Hajkova <ahajkova@redhat.com>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 3/3] Require trivial destructor in allocate_on_obstack
Date: Wed, 28 Feb 2024 17:55:25 +0100 [thread overview]
Message-ID: <CAJVr-ENunk57wT0OkMiO--UoD+HoviN=qr9HHMudHrrH1Ac7NQ@mail.gmail.com> (raw)
In-Reply-To: <20240227-obstac-alloc-v1-3-bd079aad35cd@adacore.com>
[-- Attachment #1: Type: text/plain, Size: 487 bytes --]
On Tue, Feb 27, 2024 at 10:43 PM Tom Tromey <tromey@adacore.com> wrote:
> This patch makes allocate_on_obstack a little bit safer, by enforcing
> the rule that objects allocated on an obstack must have a trivial
> destructor.
>
> The static assert is done in a method -- doing it inside the class
> itself won't work because the class is incomplete at that point.
> ---
>
> Looks great. I can confirm this change does not cause any regressions for
aarch64 Fedora Rawhide.
next prev parent reply other threads:[~2024-02-28 16:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 21:42 [PATCH 0/3] Make allocate_on_obstack a bit safer Tom Tromey
2024-02-27 21:42 ` [PATCH 1/3] Use addrmap_fixed in a few spots Tom Tromey
2024-02-28 12:27 ` Alexandra Petlanova Hajkova
2024-02-27 21:42 ` [PATCH 2/3] Don't use virtual destructor in addrmap Tom Tromey
2024-02-28 15:16 ` Alexandra Petlanova Hajkova
2024-02-27 21:42 ` [PATCH 3/3] Require trivial destructor in allocate_on_obstack Tom Tromey
2024-02-28 16:55 ` Alexandra Petlanova Hajkova [this message]
2024-03-21 18:20 ` [PATCH 0/3] Make allocate_on_obstack a bit safer Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJVr-ENunk57wT0OkMiO--UoD+HoviN=qr9HHMudHrrH1Ac7NQ@mail.gmail.com' \
--to=ahajkova@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).