Re: [PATCH 2/2] Avoid FAILs in gdb.compile

[Alexandra Petlanova Hajkova <ahajkova@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1660 bytes --]

On Mon, Jan 23, 2023 at 11:03 PM Tom Tromey via Gdb-patches <
gdb-patches@sourceware.org> wrote:

> Many gdb.compile C++ tests fail for me on Fedora 36.  I think these
> are largely bugs in the plugin, though I didn't investigate too
> deeply.  Once one failure is seen, this often cascades and sometimes
> there are many timeouts.
>
> For example, this can happen:
>
>     (gdb) compile code var = a->get_var ()
>     warning: Could not find symbol "_ZZ9_gdb_exprP10__gdb_regsE1a" for
> compiled module "/tmp/gdbobj-0xdI6U/out2.o".
>     1 symbols were missing, cannot continue.
>
> I think this is probably a plugin bug because, IIRC, in theory these
> symbols should be exempt from a lookup via gdb.
>
> This patch arranges to catch any catastrophic failure and then simply
> exit the entire .exp file.
>
>
I think it's great, running make check looks better with this for sure
(tried on Fedora 36)
< # of expected passes 119003
< # of unexpected failures 6
---
> # of expected passes 119023
> # of unexpected failures 43

I like how you handle unknown _ZZ9_gdb_exprP10__gdb_regsE1a symbol with
UNSUPPORTED.
gdb) compile code var = a->get_var ()
warning: Could not find symbol "_ZZ9_gdb_exprP10__gdb_regsE1a" for compiled
module "/tmp/gdbobj-Fa9HOp/out2.o".
1 symbols were missing, cannot continue.
(gdb) UNSUPPORTED: gdb.compile/compile-cplus-method.exp: GCC compiler
plugin bug
testcase
/home/ahajkova/build/gdb/gdb/testsuite/../../../../binutils-gdb/gdb/testsuite/gdb.compile/compile-cplus-method.exp
completed in 1 seconds
Running
/home/ahajkova/build/gdb/gdb/testsuite/../../../../binutils-gdb/gdb/testsuite/gdb.compile/compile-cplus-namespace.exp
...