* [PATCH] dwarf2read.c (compute_delayed_physnames): Use TYPE_FN_FIELD_PHYSNAME.
@ 2015-01-03 19:31 Doug Evans
2015-01-04 3:24 ` Joel Brobecker
0 siblings, 1 reply; 3+ messages in thread
From: Doug Evans @ 2015-01-03 19:31 UTC (permalink / raw)
To: gdb-patches
Hi.
I was grepping for where TYPE_FN_FIELD_PHYSNAME was set, but had to
resort to digging into the implementation.
This patch will simplify greps the next time.
Regression tested on amd64-linux.
2015-01-03 Doug Evans <xdje42@gmail.com>
* dwarf2read.c (compute_delayed_physnames): Use TYPE_FN_FIELD_PHYSNAME.
diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c
index 86c3a73..15b3c9d 100644
--- a/gdb/dwarf2read.c
+++ b/gdb/dwarf2read.c
@@ -7704,7 +7704,7 @@ compute_delayed_physnames (struct dwarf2_cu *cu)
struct fn_fieldlist *fn_flp
= &TYPE_FN_FIELDLIST (mi->type, mi->fnfield_index);
physname = dwarf2_physname (mi->name, mi->die, cu);
- fn_flp->fn_fields[mi->index].physname = physname ? physname : "";
+ TYPE_FN_FIELD_PHYSNAME (fn_flp->fn_fields, mi->index) = physname ? physname : "";
}
}
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dwarf2read.c (compute_delayed_physnames): Use TYPE_FN_FIELD_PHYSNAME.
2015-01-03 19:31 [PATCH] dwarf2read.c (compute_delayed_physnames): Use TYPE_FN_FIELD_PHYSNAME Doug Evans
@ 2015-01-04 3:24 ` Joel Brobecker
2015-01-12 0:41 ` Doug Evans
0 siblings, 1 reply; 3+ messages in thread
From: Joel Brobecker @ 2015-01-04 3:24 UTC (permalink / raw)
To: Doug Evans; +Cc: gdb-patches
> 2015-01-03 Doug Evans <xdje42@gmail.com>
>
> * dwarf2read.c (compute_delayed_physnames): Use TYPE_FN_FIELD_PHYSNAME.
I was going to fix the line length, which is now too long, but it
looks like you haven't pushed the change, yet. So...
>
> diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c
> index 86c3a73..15b3c9d 100644
> --- a/gdb/dwarf2read.c
> +++ b/gdb/dwarf2read.c
> @@ -7704,7 +7704,7 @@ compute_delayed_physnames (struct dwarf2_cu *cu)
> struct fn_fieldlist *fn_flp
> = &TYPE_FN_FIELDLIST (mi->type, mi->fnfield_index);
> physname = dwarf2_physname (mi->name, mi->die, cu);
> - fn_flp->fn_fields[mi->index].physname = physname ? physname : "";
> + TYPE_FN_FIELD_PHYSNAME (fn_flp->fn_fields, mi->index) = physname ? physname : "";
... this line is a little too long :).
> }
> }
>
--
Joel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dwarf2read.c (compute_delayed_physnames): Use TYPE_FN_FIELD_PHYSNAME.
2015-01-04 3:24 ` Joel Brobecker
@ 2015-01-12 0:41 ` Doug Evans
0 siblings, 0 replies; 3+ messages in thread
From: Doug Evans @ 2015-01-12 0:41 UTC (permalink / raw)
To: Joel Brobecker; +Cc: gdb-patches
On Sat, Jan 3, 2015 at 7:24 PM, Joel Brobecker <brobecker@adacore.com> wrote:
>> 2015-01-03 Doug Evans <xdje42@gmail.com>
>>
>> * dwarf2read.c (compute_delayed_physnames): Use TYPE_FN_FIELD_PHYSNAME.
>
> I was going to fix the line length, which is now too long, but it
> looks like you haven't pushed the change, yet. So...
>
>>
>> diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c
>> index 86c3a73..15b3c9d 100644
>> --- a/gdb/dwarf2read.c
>> +++ b/gdb/dwarf2read.c
>> @@ -7704,7 +7704,7 @@ compute_delayed_physnames (struct dwarf2_cu *cu)
>> struct fn_fieldlist *fn_flp
>> = &TYPE_FN_FIELDLIST (mi->type, mi->fnfield_index);
>> physname = dwarf2_physname (mi->name, mi->die, cu);
>> - fn_flp->fn_fields[mi->index].physname = physname ? physname : "";
>> + TYPE_FN_FIELD_PHYSNAME (fn_flp->fn_fields, mi->index) = physname ? physname : "";
>
> ... this line is a little too long :).
>
>> }
>> }
>>
Committed with the shorter lines.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-01-12 0:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-03 19:31 [PATCH] dwarf2read.c (compute_delayed_physnames): Use TYPE_FN_FIELD_PHYSNAME Doug Evans
2015-01-04 3:24 ` Joel Brobecker
2015-01-12 0:41 ` Doug Evans
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).