From: Christian Biesinger <cbiesinger@google.com>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH v2 4/6] Remove some dead code from handle_search_memory
Date: Mon, 28 Sep 2020 17:13:48 +0200 [thread overview]
Message-ID: <CAPTJ0XF=zR3A65J2m5qrtZ2cjKm1=rD5hvX4tfyA_9HE32baLw@mail.gmail.com> (raw)
In-Reply-To: <20200925194913.1744541-5-tromey@adacore.com>
On Fri, Sep 25, 2020 at 9:49 PM Tom Tromey <tromey@adacore.com> wrote:
> +++ b/gdbserver/server.cc
> @@ -1054,11 +1054,8 @@ handle_search_memory (char *own_buf, int packet_len)
>
> pattern = (gdb_byte *) malloc (packet_len);
> if (pattern == NULL)
> - {
> - error ("Unable to allocate memory to perform the search");
> - strcpy (own_buf, "E00");
> - return;
I don't know much about gdbserver but if this code was trying to send
an error back maybe that code is actually needed?
Christian
next prev parent reply other threads:[~2020-09-28 15:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 19:49 [PATCH v2 0/6] Share memory-searching code Tom Tromey
2020-09-25 19:49 ` [PATCH v2 1/6] Rename some tests in find.exp Tom Tromey
2020-09-25 19:49 ` [PATCH v2 2/6] Move simple_search_memory to gdbsupport/search.cc Tom Tromey
2020-09-25 19:49 ` [PATCH v2 3/6] Use simple_search_memory in gdbserver Tom Tromey
2020-09-25 19:49 ` [PATCH v2 4/6] Remove some dead code from handle_search_memory Tom Tromey
2020-09-28 15:13 ` Christian Biesinger [this message]
2020-09-28 19:46 ` Tom Tromey
2020-09-28 20:11 ` Christian Biesinger
2020-10-07 18:06 ` Tom Tromey
2020-09-25 19:49 ` [PATCH v2 5/6] Document inclusive range in help for "find" Tom Tromey
2020-09-25 19:49 ` [PATCH v2 6/6] Add simple_search_memory unit tests Tom Tromey
2020-10-07 18:07 ` [PATCH v2 0/6] Share memory-searching code Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPTJ0XF=zR3A65J2m5qrtZ2cjKm1=rD5hvX4tfyA_9HE32baLw@mail.gmail.com' \
--to=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).