From: Tom Tromey <tromey@adacore.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@adacore.com>
Subject: [PATCH v2 4/6] Remove some dead code from handle_search_memory
Date: Fri, 25 Sep 2020 13:49:11 -0600 [thread overview]
Message-ID: <20200925194913.1744541-5-tromey@adacore.com> (raw)
In-Reply-To: <20200925194913.1744541-1-tromey@adacore.com>
handle_search_memory had some code after a call to error. This code
is dead, and this patch removes it.
gdbserver/ChangeLog
2020-09-25 Tom Tromey <tromey@adacore.com>
* server.cc (handle_search_memory): Remove dead code.
---
gdbserver/ChangeLog | 4 ++++
gdbserver/server.cc | 9 ++-------
2 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/gdbserver/server.cc b/gdbserver/server.cc
index 1c21660027e..674462c9ae6 100644
--- a/gdbserver/server.cc
+++ b/gdbserver/server.cc
@@ -1054,11 +1054,8 @@ handle_search_memory (char *own_buf, int packet_len)
pattern = (gdb_byte *) malloc (packet_len);
if (pattern == NULL)
- {
- error ("Unable to allocate memory to perform the search");
- strcpy (own_buf, "E00");
- return;
- }
+ error ("Unable to allocate memory to perform the search");
+
if (decode_search_memory_packet (own_buf + cmd_name_len,
packet_len - cmd_name_len,
&start_addr, &search_space_len,
@@ -1066,8 +1063,6 @@ handle_search_memory (char *own_buf, int packet_len)
{
free (pattern);
error ("Error in parsing qSearch:memory packet");
- strcpy (own_buf, "E00");
- return;
}
auto read_memory = [] (CORE_ADDR addr, gdb_byte *result, size_t len)
--
2.26.2
next prev parent reply other threads:[~2020-09-25 19:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 19:49 [PATCH v2 0/6] Share memory-searching code Tom Tromey
2020-09-25 19:49 ` [PATCH v2 1/6] Rename some tests in find.exp Tom Tromey
2020-09-25 19:49 ` [PATCH v2 2/6] Move simple_search_memory to gdbsupport/search.cc Tom Tromey
2020-09-25 19:49 ` [PATCH v2 3/6] Use simple_search_memory in gdbserver Tom Tromey
2020-09-25 19:49 ` Tom Tromey [this message]
2020-09-28 15:13 ` [PATCH v2 4/6] Remove some dead code from handle_search_memory Christian Biesinger
2020-09-28 19:46 ` Tom Tromey
2020-09-28 20:11 ` Christian Biesinger
2020-10-07 18:06 ` Tom Tromey
2020-09-25 19:49 ` [PATCH v2 5/6] Document inclusive range in help for "find" Tom Tromey
2020-09-25 19:49 ` [PATCH v2 6/6] Add simple_search_memory unit tests Tom Tromey
2020-10-07 18:07 ` [PATCH v2 0/6] Share memory-searching code Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200925194913.1744541-5-tromey@adacore.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).