From: Christian Biesinger <cbiesinger@google.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] sim: mn10300: clean up pointer casts
Date: Mon, 1 Nov 2021 12:07:48 -0400 [thread overview]
Message-ID: <CAPTJ0XHoC4R6hAD=Hkv8fe6QgahtUBoBN82usQb0ctZi8ia1TA@mail.gmail.com> (raw)
In-Reply-To: <20211101034519.29154-1-vapier@gentoo.org>
On Sun, Oct 31, 2021 at 11:45 PM Mike Frysinger via Gdb-patches
<gdb-patches@sourceware.org> wrote:
> --- a/sim/mn10300/dv-mn103ser.c
> +++ b/sim/mn10300/dv-mn103ser.c
> @@ -238,7 +238,7 @@ do_polling_event (struct hw *me,
> {
> SIM_DESC sd = hw_system (me);
> struct mn103ser *serial = hw_data(me);
> - long serial_reg = (long) data;
> + long serial_reg = (uintptr_t) data;
Shouldn't you change the variable type too? Otherwise this patch seems
to be somewhat pointless?
if ( nr_bytes == 1 )
> diff --git a/sim/mn10300/dv-mn103tim.c b/sim/mn10300/dv-mn103tim.c
> index ad9c24bbc6e8..76f87380d1d8 100644
> --- a/sim/mn10300/dv-mn103tim.c
> +++ b/sim/mn10300/dv-mn103tim.c
> @@ -570,7 +570,7 @@ do_counter_event (struct hw *me,
> void *data)
> {
> struct mn103tim *timers = hw_data(me);
> - long timer_nr = (long) data;
> + long timer_nr = (uintptr_t) data;
Here too.
> @@ -611,7 +611,7 @@ do_counter6_event (struct hw *me,
> void *data)
> {
> struct mn103tim *timers = hw_data(me);
> - long timer_nr = (long) data;
> + long timer_nr = (uintptr_t) data;
And here.
Christian
next prev parent reply other threads:[~2021-11-01 16:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-01 3:45 Mike Frysinger
2021-11-01 16:07 ` Christian Biesinger [this message]
2021-11-01 16:22 ` Mike Frysinger
2021-11-01 18:28 ` Christian Biesinger
2021-11-01 18:59 ` Mike Frysinger
2021-11-01 19:35 ` Christian Biesinger
2021-11-02 4:19 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPTJ0XHoC4R6hAD=Hkv8fe6QgahtUBoBN82usQb0ctZi8ia1TA@mail.gmail.com' \
--to=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).