From: Mike Frysinger <vapier@gentoo.org>
To: Christian Biesinger <cbiesinger@google.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] sim: mn10300: clean up pointer casts
Date: Mon, 1 Nov 2021 12:22:58 -0400 [thread overview]
Message-ID: <YYAUYrzh9EcGNYct@vapier> (raw)
In-Reply-To: <CAPTJ0XHoC4R6hAD=Hkv8fe6QgahtUBoBN82usQb0ctZi8ia1TA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1707 bytes --]
On 01 Nov 2021 12:07, Christian Biesinger wrote:
> On Sun, Oct 31, 2021 at 11:45 PM Mike Frysinger via Gdb-patches
> <gdb-patches@sourceware.org> wrote:
> > --- a/sim/mn10300/dv-mn103ser.c
> > +++ b/sim/mn10300/dv-mn103ser.c
> > @@ -238,7 +238,7 @@ do_polling_event (struct hw *me,
> > {
> > SIM_DESC sd = hw_system (me);
> > struct mn103ser *serial = hw_data(me);
> > - long serial_reg = (long) data;
> > + long serial_reg = (uintptr_t) data;
>
> Shouldn't you change the variable type too?
the types are already confused, but long here is fine as any other. uintptr_t
is not really any more correct. serial_reg comes in as an unsigned_word via
the memory read/write callbacks, (encoded) cast to void*, and (decoded) cast
to long. the memory read/write callbacks verify the values are always within
the serial_register_types enum range which looks like [0,16] range, so any of
these types work.
> Otherwise this patch seems to be somewhat pointless?
> if ( nr_bytes == 1 )
i don't know which one you mean, or why you think any of them are pointless.
the nr_bytes checks are in the read/write code paths of the memory mapped
register callbacks. so nr_bytes is needed & correct there.
the uintptr_t casts happen when passing information to the scheduled callback
which is after the nr_bytes checks.
i'm not anti trying to clean up these device models, i just don't have any
personal interest in them, so i'm not inclined to spend time on them anymore
than compiler warnings/failures force me to, or to make progress in unifying
all the ports. the lack of test coverage also makes me a bit inclined to not
get too invasive if i can avoid it.
-mike
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-11-01 16:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-01 3:45 Mike Frysinger
2021-11-01 16:07 ` Christian Biesinger
2021-11-01 16:22 ` Mike Frysinger [this message]
2021-11-01 18:28 ` Christian Biesinger
2021-11-01 18:59 ` Mike Frysinger
2021-11-01 19:35 ` Christian Biesinger
2021-11-02 4:19 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYAUYrzh9EcGNYct@vapier \
--to=vapier@gentoo.org \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).