RE: [PATCH] Fix AIX build break

[Aditya Kamath1 <Aditya.Kamath1@ibm.com>]

[-- Attachment #1: Type: text/plain, Size: 1522 bytes --]

Respected community members,

Hi,

Please find attached the patch. (See: 0001-Fix-AIX-build-break.patch).

Thank you for your patience and feedback.

This patch now fixes the AIX build break and uses the idea as suggested by Tom in this link (https://sourceware.org/git/?p=binutils-gdb.git;a=commitdiff;h=fece451c2aca57b095e7e4063e342781cf74aa75).

Kindly give me feedback for the same. I removed the extern thread_local and use class now.

Also, is there any guidelines for naming classes? Kindly let me know.

I am also curious to know if GDB is multi-threaded now?

Have a nice day ahead.

Thanks and regards,
Aditya.


From: Tom Tromey <tom@tromey.com>
Date: Friday, 12 January 2024 at 9:26 PM
To: Tom de Vries <tdevries@suse.de>
Cc: Aditya Kamath1 <Aditya.Kamath1@ibm.com>, Ulrich Weigand <Ulrich.Weigand@de.ibm.com>, Aditya Kamath1 via Gdb-patches <gdb-patches@sourceware.org>, Sangamesh Mallayya <sangamesh.swamy@in.ibm.com>, Tom Tromey <tom@tromey.com>
Subject: [EXTERNAL] Re: [PATCH] Fix AIX build break
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

Tom> I think this is triggered by using thread-local with extern.

Ugh.

>     Use RAII to set the per-thread SIGSEGV handler

Tom> which seems related, given that it mentions link errors.  Perhaps we
Tom> can do something similar here.

That would by fine with me.

Does the AIX build detect that threads work?  If not then we could
perhaps make the use of 'thread_local' dependent on CXX_STD_THREAD.

Tom

[-- Attachment #2: winmail.dat --]
[-- Type: application/ms-tnef, Size: 24153 bytes --]