From: Tom Tromey <tom@tromey.com>
To: Ciaran Woodward <ciaranwoodward@xmos.com>
Cc: Aditya Kamath1 <Aditya.Kamath1@ibm.com>,
Tom Tromey <tom@tromey.com>,
Ulrich Weigand <Ulrich.Weigand@de.ibm.com>,
Sangamesh Mallayya <sangamesh.swamy@in.ibm.com>,
Aditya Kamath1 via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix AIX build break.
Date: Tue, 06 Feb 2024 07:49:07 -0700 [thread overview]
Message-ID: <87il31ejh8.fsf@tromey.com> (raw)
In-Reply-To: <PAXPR09MB5583154E968E2CD50AB9F5A4B9462@PAXPR09MB5583.eurprd09.prod.outlook.com> (Ciaran Woodward's message of "Tue, 6 Feb 2024 12:36:42 +0000")
>>>>> "Ciaran" == Ciaran Woodward <ciaranwoodward@xmos.com> writes:
Ciaran> I think it is because va_list on that platform has some attributes.
Ugh.
Ciaran> scoped_restore_warning_hook::scoped_restore_warning_hook
Ciaran> (warning_hook_handler new_handler)
Ciaran> - : m_save (make_scoped_restore (&warning_hook, new_handler))
Ciaran> + : m_save (make_scoped_restore (reinterpret_cast<void(**)()>(&warning_hook),
Ciaran> + reinterpret_cast<void(*)()>(new_handler)))
What if we remove the scoped_restore use and just do the save/restore
manually here instead?
Tom
next prev parent reply other threads:[~2024-02-06 14:49 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-17 18:28 Aditya Vidyadhar Kamath
2024-01-17 19:25 ` Tom Tromey
2024-01-19 11:58 ` Aditya Kamath1
2024-01-19 16:25 ` Tom Tromey
2024-01-20 15:03 ` Aditya Kamath1
2024-01-24 0:53 ` Aditya Kamath1
2024-01-25 14:45 ` Aditya Kamath1
2024-01-25 19:53 ` Tom Tromey
2024-01-26 8:37 ` Aditya Kamath1
2024-01-31 0:40 ` Tom Tromey
2024-01-31 9:15 ` Aditya Kamath1
2024-02-01 0:37 ` Tom Tromey
2024-02-01 3:03 ` Aditya Kamath1
2024-02-06 12:36 ` Ciaran Woodward
2024-02-06 14:49 ` Tom Tromey [this message]
2024-02-06 15:04 ` Ciaran Woodward
2024-02-06 15:54 ` Aditya Kamath1
-- strict thread matches above, loose matches on Subject: below --
2024-01-12 9:20 Aditya Kamath1
2024-01-12 9:50 ` Tom de Vries
2024-01-12 15:56 ` Tom Tromey
2024-01-16 9:42 ` Aditya Kamath1
2024-01-17 15:09 ` Tom Tromey
2023-08-11 8:49 Aditya Kamath1
2023-08-11 9:43 ` Ulrich Weigand
2023-08-11 9:53 ` Aditya Kamath1
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87il31ejh8.fsf@tromey.com \
--to=tom@tromey.com \
--cc=Aditya.Kamath1@ibm.com \
--cc=Ulrich.Weigand@de.ibm.com \
--cc=ciaranwoodward@xmos.com \
--cc=gdb-patches@sourceware.org \
--cc=sangamesh.swamy@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).