RE: [PATCH 09/11] gdb/fortran: rewrite intrinsic handling and add some missing overloads

["Kempke, Nils-Christian" <nils-christian.kempke@intel.com>]

> From: Tom Tromey <tom@tromey.com>
> Sent: Thursday, April 7, 2022 4:49 PM

> Thanks for the patch.
> I found one minor problem in this one.  You don't have to resubmit after
> fixing it, though.
> 
> > After adding more overloads to the intrinsics handling, some of the
> > operation names were no longer accurate.  E.g. UNOP_FORTRAN_CEILING
> > has been renamed to FORTRAN_CEILING as it is no longer a purely unary
> > intrinsic function.
> 
> Eventually I'd like to get rid of this operator enum entirely, but it's
> also fine to make the names more correct in the meantime.

Thanks for the review!

I also thought about this while doing the changes..  But I did not want the series
to become even more invasive.  Should I touch the Fortran intrinsics handling 
in the new future again I'll do that, too (probably while checking the intrinsics code
test coverage..).

> 
> > +    case FORTRAN_LBOUND:
> > +    case FORTRAN_UBOUND:
> > +      pstate->push_new<fortran_bound_2arg>
> > +	(code, pstate->pop (), pstate->pop ());
> 
> I don't think you can rely on the order of evaluation here.  (C++ did
> change this, but after C++11, I think.)  Instead you need to introduce
> temporaries to control the ordering.
> 

Good spot, thanks!

I'll resubmit patch [PATCH 11/11] only then.

Cheers, Nils
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928