RE: [PATCH v2 02/24] gdb: use reg_buffer_common throughout gdbsupport/common-regcache.h

["Aktemur, Tankut Baris" <tankut.baris.aktemur@intel.com>]

On Friday, November 24, 2023 10:26 PM, Simon Marchi wrote:
> diff --git a/gdbserver/regcache.cc b/gdbserver/regcache.cc
> index 2e75a948a198..336b00008be5 100644
> --- a/gdbserver/regcache.cc
> +++ b/gdbserver/regcache.cc
> @@ -21,6 +21,8 @@
>  #include "gdbthread.h"
>  #include "tdesc.h"
>  #include "gdbsupport/rsp-low.h"
> +#include "gdbsupport/gdb-checked-static-cast.h"
> +
>  #ifndef IN_PROCESS_AGENT
> 
>  struct regcache *
> @@ -64,7 +66,7 @@ get_thread_regcache (struct thread_info *thread, int fetch)
> 
>  /* See gdbsupport/common-regcache.h.  */
> 
> -struct regcache *
> +reg_buffer_common *
>  get_thread_regcache_for_ptid (ptid_t ptid)
>  {
>    return get_thread_regcache (find_thread_ptid (ptid), 1);
> @@ -307,9 +309,10 @@ register_size (const struct target_desc *tdesc, int n)
>  /* See gdbsupport/common-regcache.h.  */
> 
>  int
> -regcache_register_size (const struct regcache *regcache, int n)
> +regcache_register_size (const reg_buffer_common *regcache, int n)
>  {
> -  return register_size (regcache->tdesc, n);
> +  return register_size
> +    (gdb::checked_static_cast<const struct regcache *> (regcache)->tdesc, n);
>  }
> 
>  static unsigned char *
> @@ -437,13 +440,14 @@ regcache::raw_collect (int n, void *buf) const
>  }
> 
>  enum register_status
> -regcache_raw_read_unsigned (struct regcache *regcache, int regnum,
> +regcache_raw_read_unsigned (reg_buffer_common *reg_buf, int regnum,
>  			    ULONGEST *val)
>  {
>    int size;
> +  regcache *regcache = gdb::checked_static_cast<struct regcache *> (reg_buf);
> 
>    gdb_assert (regcache != NULL);
> -
> +

Trailing space seems to have been inserted here.

-Baris


Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928