From: "Aktemur, Tankut Baris" <tankut.baris.aktemur@intel.com>
To: Tom Tromey <tom@tromey.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Cc: "blarsen@redhat.com" <blarsen@redhat.com>,
"aburgess@redhat.com" <aburgess@redhat.com>
Subject: RE: [PATCH v5] gdb, python: selectively omit enabling stdin in gdb.execute
Date: Mon, 19 Feb 2024 10:00:10 +0000 [thread overview]
Message-ID: <DM4PR11MB730383B4FFDBD40852914A90C4512@DM4PR11MB7303.namprd11.prod.outlook.com> (raw)
In-Reply-To: <87a5odecd6.fsf@tromey.com>
On February 6, 2024 6:23 PM, Tom Tromey wrote:
> >>>>> Tankut Baris Aktemur <tankut.baris.aktemur@intel.com> writes:
>
> > The previous revision (v4) of this patch can be found at
>
> > https://sourceware.org/pipermail/gdb-patches/2023-November/204107.html
>
> > Changes in this version:
>
> > * Revised the commit message to address Andrew Burgess' concerns in
> > https://sourceware.org/pipermail/gdb-patches/2023-November/204215.html
>
> > * Made a minor change to a code comment.
>
> I didn't see a response to this.
>
> I think this whole area is pretty ugly, but at the same time, I don't
> think that's your fault.
>
> In short I think this is OK.
> Approved-By: Tom Tromey <tom@tromey.com>
>
> thanks,
> Tom
Thank you. I updated the copyright years of the newly-introduced files from
2023 to 2023-2024 and pushed the patch.
-Baris
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
next prev parent reply other threads:[~2024-02-19 10:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-31 8:11 [PATCH v3] gdb, python: selectively omit enabling stdin in gdb.execute exception Tankut Baris Aktemur
2023-06-20 13:04 ` Aktemur, Tankut Baris
2023-11-14 11:06 ` [PATCH v4] gdb, python: selectively omit enabling stdin in gdb.execute Tankut Baris Aktemur
2023-11-16 11:32 ` Andrew Burgess
2023-11-20 20:21 ` [PATCH v5] " Tankut Baris Aktemur
2024-02-06 17:22 ` Tom Tromey
2024-02-19 10:00 ` Aktemur, Tankut Baris [this message]
2023-11-20 20:24 ` [PATCH v4] " Aktemur, Tankut Baris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR11MB730383B4FFDBD40852914A90C4512@DM4PR11MB7303.namprd11.prod.outlook.com \
--to=tankut.baris.aktemur@intel.com \
--cc=aburgess@redhat.com \
--cc=blarsen@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).