public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Tankut Baris Aktemur <tankut.baris.aktemur@intel.com>
Cc: gdb-patches@sourceware.org,  blarsen@redhat.com,  tom@tromey.com,
	aburgess@redhat.com
Subject: Re: [PATCH v5] gdb, python: selectively omit enabling stdin in gdb.execute
Date: Tue, 06 Feb 2024 10:22:45 -0700	[thread overview]
Message-ID: <87a5odecd6.fsf@tromey.com> (raw)
In-Reply-To: <54fb15ec3abb7a1f7f0714094365feb0d5197489.1700510882.git.tankut.baris.aktemur@intel.com> (Tankut Baris Aktemur's message of "Mon, 20 Nov 2023 21:21:54 +0100")

>>>>> Tankut Baris Aktemur <tankut.baris.aktemur@intel.com> writes:

> The previous revision (v4) of this patch can be found at

>   https://sourceware.org/pipermail/gdb-patches/2023-November/204107.html

> Changes in this version:

> * Revised the commit message to address Andrew Burgess' concerns in
>   https://sourceware.org/pipermail/gdb-patches/2023-November/204215.html

> * Made a minor change to a code comment.

I didn't see a response to this.

I think this whole area is pretty ugly, but at the same time, I don't
think that's your fault.

In short I think this is OK.
Approved-By: Tom Tromey <tom@tromey.com>

thanks,
Tom

  reply	other threads:[~2024-02-06 17:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-31  8:11 [PATCH v3] gdb, python: selectively omit enabling stdin in gdb.execute exception Tankut Baris Aktemur
2023-06-20 13:04 ` Aktemur, Tankut Baris
2023-11-14 11:06 ` [PATCH v4] gdb, python: selectively omit enabling stdin in gdb.execute Tankut Baris Aktemur
2023-11-16 11:32   ` Andrew Burgess
2023-11-20 20:21     ` [PATCH v5] " Tankut Baris Aktemur
2024-02-06 17:22       ` Tom Tromey [this message]
2024-02-19 10:00         ` Aktemur, Tankut Baris
2023-11-20 20:24     ` [PATCH v4] " Aktemur, Tankut Baris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a5odecd6.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=aburgess@redhat.com \
    --cc=blarsen@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tankut.baris.aktemur@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).