From: "Six, Lancelot" <Lancelot.Six@amd.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
"Six, Lancelot" <Lancelot.Six@amd.com>
Cc: "lsix@lancelotsix.com" <lsix@lancelotsix.com>
Subject: RE: [PATCH] gdb/testsuite: use proper int size for gdb.dwarf2/symbol_needs_eval*.exp
Date: Thu, 8 Jun 2023 21:13:16 +0000 [thread overview]
Message-ID: <DM4PR12MB5745D5B565A2309F14ACA3908350A@DM4PR12MB5745.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20230608153842.353415-1-lancelot.six@amd.com>
[AMD Official Use Only - General]
Replying to myself.
> diff --git a/gdb/testsuite/gdb.dwarf2/symbol_needs_eval_fail.exp
> b/gdb/testsuite/gdb.dwarf2/symbol_needs_eval_fail.exp
> index cb9826e90df..c3440d970dc 100644
> --- a/gdb/testsuite/gdb.dwarf2/symbol_needs_eval_fail.exp
> +++ b/gdb/testsuite/gdb.dwarf2/symbol_needs_eval_fail.exp
> @@ -47,11 +47,19 @@ if { [is_aarch64_target] } {
>
> standard_testfile symbol_needs_eval.c ${gdb_test_file_name}-dw.S
>
> +if [prepare_for_testing "failed to prepare" $testfile $srcfile {debug}] {
> + return
> +}
> +
> +clean_restart ${testfile}
The clean_restart is not needed here as this is the last thing prepare_for_testing does.
> diff --git a/gdb/testsuite/gdb.dwarf2/symbol_needs_eval_timeout.exp
> b/gdb/testsuite/gdb.dwarf2/symbol_needs_eval_timeout.exp
> index 0e6ee6112ea..ecdeb62a1a8 100644
> --- a/gdb/testsuite/gdb.dwarf2/symbol_needs_eval_timeout.exp
> +++ b/gdb/testsuite/gdb.dwarf2/symbol_needs_eval_timeout.exp
> @@ -47,11 +47,19 @@ if { [is_aarch64_target] } {
>
> standard_testfile symbol_needs_eval.c ${gdb_test_file_name}-dw.S
>
> +if [prepare_for_testing "failed to prepare" $testfile $srcfile {debug}] {
> + return
> +}
> +
> +clean_restart ${testfile}
Same here.
I'll prepare a V2 removing those 2 lines.
Best,
Lancelot.
prev parent reply other threads:[~2023-06-08 21:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-08 15:38 Lancelot SIX
2023-06-08 21:13 ` Six, Lancelot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM4PR12MB5745D5B565A2309F14ACA3908350A@DM4PR12MB5745.namprd12.prod.outlook.com \
--to=lancelot.six@amd.com \
--cc=gdb-patches@sourceware.org \
--cc=lsix@lancelotsix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).