public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: "Metzger, Markus T" <markus.t.metzger@intel.com>
To: Tom Tromey <tromey@adacore.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: 4b610737f02 Handle copy relocations
Date: Tue, 18 Oct 2022 13:25:28 +0000	[thread overview]
Message-ID: <DM8PR11MB5749AE94C31F5C35BC08F883DE289@DM8PR11MB5749.namprd11.prod.outlook.com> (raw)

Hello Tom,

        4b610737f02 Handle copy relocations

makes get_symbol_address() and get_msymbol_address() search objfiles

for a 'better' match to handle copy relocations.



With linker namespaces, however, it may cause a wrong address to be
read after symbol lookup actually found the correct symbol.  This can
be seen, for example, with gdb.base/dlmopen.exp when compiled with
clang.

Do you maybe see a different way of supporting copy relocations that
would not require fixing up the symbol when querying its address?

thanks,
markus.

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928

WARNING: multiple messages have this Message-ID

From: "Metzger, Markus T" <markus.t.metzger@intel.com>
To: Tom Tromey <tromey@adacore.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: 4b610737f02 Handle copy relocations
Date: Tue, 18 Oct 2022 13:25:28 +0000	[thread overview]
Message-ID: <DM8PR11MB5749AE94C31F5C35BC08F883DE289@DM8PR11MB5749.namprd11.prod.outlook.com> (raw)
Message-ID: <20221018132528.YBS8LqTxB14ycjtdlQAw454uQeL3u2sm7mVTIOPeoN4@z> (raw)

[-- Attachment #1: Type: text/plain, Size: 918 bytes --]

Hello Tom,

        4b610737f02 Handle copy relocations

makes get_symbol_address() and get_msymbol_address() search objfiles

for a 'better' match to handle copy relocations.



With linker namespaces, however, it may cause a wrong address to be
read after symbol lookup actually found the correct symbol.  This can
be seen, for example, with gdb.base/dlmopen.exp when compiled with
clang.

Do you maybe see a different way of supporting copy relocations that
would not require fixing up the symbol when querying its address?

thanks,
markus.

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928

             reply	other threads:[~2022-10-18 13:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-18 13:25 Metzger, Markus T [this message]
2022-10-18 13:25 ` Metzger, Markus T
2022-10-18 14:38 ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM8PR11MB5749AE94C31F5C35BC08F883DE289@DM8PR11MB5749.namprd11.prod.outlook.com \
    --to=markus.t.metzger@intel.com \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@adacore.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).