* [RFC][PATCH 0/2][PR 28406] gdb: add exit command as an alias for quit [not found] <20211030102035.32391-1-lienze2010@hotmail.com> @ 2021-10-30 11:06 ` Enze Li [not found] ` <20211030110629.4860-1-lienze2010@hotmail.com> 1 sibling, 0 replies; 4+ messages in thread From: Enze Li @ 2021-10-30 11:06 UTC (permalink / raw) To: gdb-patches As described in PR28406, I think it is a good idea to add an exit command. Many years ago, when I used the gdb debugger for the first time, I often input the "quit" command incorrectly. Adding this "exit" command may be friendly to new users, regardless of whether they have used other similar software before. The specific implementation of this idea is simple, only using the add_com_alias method. Eventually, the quit_cmd function will be invoked. Is this a good idea? Or, do these modifications make sense? Enze Li (2): gdb: improve quit command with an alias called exit gdb/doc: Document the exit command gdb/cli/cli-cmds.c | 3 ++- gdb/doc/gdb.texinfo | 12 +++++++----- 2 files changed, 9 insertions(+), 6 deletions(-) -- 2.33.1 ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <20211030110629.4860-1-lienze2010@hotmail.com>]
* [RFC][PATCH 1/2] gdb: improve quit command with an alias called exit [not found] ` <20211030110629.4860-1-lienze2010@hotmail.com> @ 2021-10-30 11:06 ` Enze Li 2021-10-30 11:06 ` [RFC][PATCH 2/2] gdb/doc: Document the exit command Enze Li 1 sibling, 0 replies; 4+ messages in thread From: Enze Li @ 2021-10-30 11:06 UTC (permalink / raw) To: gdb-patches This commit implements a request to add a quit command alias in PR28406[1]. With this commit, we can now use the "exit" alias to exit the GDB. Tested on x86_64-linux. [1] https://sourceware.org/bugzilla/show_bug.cgi?id=28406 --- gdb/cli/cli-cmds.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gdb/cli/cli-cmds.c b/gdb/cli/cli-cmds.c index 2cf614c8e7e..832c9e56937 100644 --- a/gdb/cli/cli-cmds.c +++ b/gdb/cli/cli-cmds.c @@ -2377,7 +2377,7 @@ strict == evaluate script according to filename extension, error if not supporte cmd_list_element *quit_cmd = add_com ("quit", class_support, quit_command, _("\ Exit gdb.\n\ -Usage: quit [EXPR]\n\ +Usage: quit [EXPR] or exit [EXPR]\n\ The optional expression EXPR, if present, is evaluated and the result\n\ used as GDB's exit code. The default is zero.")); cmd_list_element *help_cmd @@ -2385,6 +2385,7 @@ used as GDB's exit code. The default is zero.")); _("Print list of commands.")); set_cmd_completer (help_cmd, command_completer); add_com_alias ("q", quit_cmd, class_support, 1); + add_com_alias ("exit", quit_cmd, class_support, 1); add_com_alias ("h", help_cmd, class_support, 1); add_setshow_boolean_cmd ("verbose", class_support, &info_verbose, _("\ -- 2.33.1 ^ permalink raw reply [flat|nested] 4+ messages in thread
* [RFC][PATCH 2/2] gdb/doc: Document the exit command [not found] ` <20211030110629.4860-1-lienze2010@hotmail.com> 2021-10-30 11:06 ` [RFC][PATCH 1/2] gdb: improve quit command with an alias called exit Enze Li @ 2021-10-30 11:06 ` Enze Li 2021-11-01 18:05 ` Bruno Larsen 1 sibling, 1 reply; 4+ messages in thread From: Enze Li @ 2021-10-30 11:06 UTC (permalink / raw) To: gdb-patches Update "Quitting GDB" section. * gdb/doc/gdb.texinfo: (Quitting GDB): Document "exit". --- gdb/doc/gdb.texinfo | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo index e0b065e9663..0529fa71d50 100644 --- a/gdb/doc/gdb.texinfo +++ b/gdb/doc/gdb.texinfo @@ -841,7 +841,7 @@ The essentials are: @item type @samp{@value{GDBP}} to start @value{GDBN}. @item -type @kbd{quit} or @kbd{Ctrl-d} to exit. +type @kbd{quit}, @kbd{exit} or @kbd{Ctrl-d} to exit. @end itemize @menu @@ -1580,14 +1580,16 @@ Options,,Choosing Modes}. @table @code @kindex quit @r{[}@var{expression}@r{]} +@kindex exit @r{[}@var{expression}@r{]} @kindex q @r{(@code{quit})} @item quit @r{[}@var{expression}@r{]} +@item exit @r{[}@var{expression}@r{]} @itemx q To exit @value{GDBN}, use the @code{quit} command (abbreviated -@code{q}), or type an end-of-file character (usually @kbd{Ctrl-d}). If you -do not supply @var{expression}, @value{GDBN} will terminate normally; -otherwise it will terminate using the result of @var{expression} as the -error code. +@code{q}), the @code{exit} command, or type an end-of-file +character (usually @kbd{Ctrl-d}). If you do not supply @var{expression}, +@value{GDBN} will terminate normally; otherwise it will terminate using +the result of @var{expression} as the error code. @end table @cindex interrupt -- 2.33.1 ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RFC][PATCH 2/2] gdb/doc: Document the exit command 2021-10-30 11:06 ` [RFC][PATCH 2/2] gdb/doc: Document the exit command Enze Li @ 2021-11-01 18:05 ` Bruno Larsen 0 siblings, 0 replies; 4+ messages in thread From: Bruno Larsen @ 2021-11-01 18:05 UTC (permalink / raw) To: Enze Li, gdb-patches On 10/30/21 08:06, Enze Li via Gdb-patches wrote: > Update "Quitting GDB" section. > > * gdb/doc/gdb.texinfo: (Quitting GDB): Document "exit". > --- > gdb/doc/gdb.texinfo | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo > index e0b065e9663..0529fa71d50 100644 > --- a/gdb/doc/gdb.texinfo > +++ b/gdb/doc/gdb.texinfo > @@ -841,7 +841,7 @@ The essentials are: > @item > type @samp{@value{GDBP}} to start @value{GDBN}. > @item > -type @kbd{quit} or @kbd{Ctrl-d} to exit. > +type @kbd{quit}, @kbd{exit} or @kbd{Ctrl-d} to exit. > @end itemize > > @menu > @@ -1580,14 +1580,16 @@ Options,,Choosing Modes}. > > @table @code > @kindex quit @r{[}@var{expression}@r{]} > +@kindex exit @r{[}@var{expression}@r{]} > @kindex q @r{(@code{quit})} > @item quit @r{[}@var{expression}@r{]} > +@item exit @r{[}@var{expression}@r{]} > @itemx q > To exit @value{GDBN}, use the @code{quit} command (abbreviated > -@code{q}), or type an end-of-file character (usually @kbd{Ctrl-d}). If you > -do not supply @var{expression}, @value{GDBN} will terminate normally; > -otherwise it will terminate using the result of @var{expression} as the > -error code. > +@code{q}), the @code{exit} command, or type an end-of-file > +character (usually @kbd{Ctrl-d}). If you do not supply @var{expression}, > +@value{GDBN} will terminate normally; otherwise it will terminate using > +the result of @var{expression} as the error code. > @end table > > @cindex interrupt > This looks like an alright idea. But you should also update the man page (lower down on the doc file) if you end up making new changes to this patch series -- Cheers! Bruno Larsen ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-11-01 18:05 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <20211030102035.32391-1-lienze2010@hotmail.com> 2021-10-30 11:06 ` [RFC][PATCH 0/2][PR 28406] gdb: add exit command as an alias for quit Enze Li [not found] ` <20211030110629.4860-1-lienze2010@hotmail.com> 2021-10-30 11:06 ` [RFC][PATCH 1/2] gdb: improve quit command with an alias called exit Enze Li 2021-10-30 11:06 ` [RFC][PATCH 2/2] gdb/doc: Document the exit command Enze Li 2021-11-01 18:05 ` Bruno Larsen
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).