From: "Willgerodt, Felix" <felix.willgerodt@intel.com>
To: Tom Tromey <tom@tromey.com>,
Felix Willgerodt via Gdb-patches <gdb-patches@sourceware.org>
Subject: RE: [PATCH 1/1] gdb, i386: Update stale comment in i386-tdep.h.
Date: Wed, 25 Jan 2023 12:43:23 +0000 [thread overview]
Message-ID: <MN2PR11MB4566840DF0403720C3D18F448ECE9@MN2PR11MB4566.namprd11.prod.outlook.com> (raw)
In-Reply-To: <87wn5bvklv.fsf@tromey.com>
Pushed.
Thanks,
Felix
> -----Original Message-----
> From: Tom Tromey <tom@tromey.com>
> Sent: Dienstag, 24. Januar 2023 19:44
> To: Felix Willgerodt via Gdb-patches <gdb-patches@sourceware.org>
> Cc: Willgerodt, Felix <felix.willgerodt@intel.com>
> Subject: Re: [PATCH 1/1] gdb, i386: Update stale comment in i386-tdep.h.
>
> >>>>> "Felix" == Felix Willgerodt via Gdb-patches <gdb-
> patches@sourceware.org> writes:
>
> Felix> The comment seems no longer valid, the functions technically check
> for
> Felix> non-pseudo registers, like zmmh. Which is a valid use case.
>
> Felix> This could also be considered obvious, but the 32-bit register code is
> Felix> a bit complex to understand.
>
> It seems fine to me. Thank you.
>
> Tom
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
prev parent reply other threads:[~2023-01-25 12:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-24 14:16 Felix Willgerodt
2023-01-24 18:43 ` Tom Tromey
2023-01-25 12:43 ` Willgerodt, Felix [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR11MB4566840DF0403720C3D18F448ECE9@MN2PR11MB4566.namprd11.prod.outlook.com \
--to=felix.willgerodt@intel.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).