From: Felix Willgerodt <felix.willgerodt@intel.com>
To: gdb-patches@sourceware.org
Cc: Felix Willgerodt <felix.willgerodt@intel.com>
Subject: [PATCH 1/1] gdb, i386: Update stale comment in i386-tdep.h.
Date: Tue, 24 Jan 2023 15:16:50 +0100 [thread overview]
Message-ID: <20230124141650.2459324-1-felix.willgerodt@intel.com> (raw)
The comment seems no longer valid, the functions technically check for
non-pseudo registers, like zmmh. Which is a valid use case.
This could also be considered obvious, but the 32-bit register code is
a bit complex to understand.
---
gdb/i386-tdep.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/i386-tdep.h b/gdb/i386-tdep.h
index 82de5faa988..371bce72369 100644
--- a/gdb/i386-tdep.h
+++ b/gdb/i386-tdep.h
@@ -353,7 +353,7 @@ enum record_i386_regnum
/* Types for i386-specific registers. */
extern struct type *i387_ext_type (struct gdbarch *gdbarch);
-/* Checks of different pseudo-registers. */
+/* Checks of different registers. */
extern int i386_byte_regnum_p (struct gdbarch *gdbarch, int regnum);
extern int i386_word_regnum_p (struct gdbarch *gdbarch, int regnum);
extern int i386_dword_regnum_p (struct gdbarch *gdbarch, int regnum);
--
2.34.3
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
next reply other threads:[~2023-01-24 14:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-24 14:16 Felix Willgerodt [this message]
2023-01-24 18:43 ` Tom Tromey
2023-01-25 12:43 ` Willgerodt, Felix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230124141650.2459324-1-felix.willgerodt@intel.com \
--to=felix.willgerodt@intel.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).