RE: [PATCH 1/1] gdb, fortran: Fix quad floating-point type for ifort compiler.

["Willgerodt, Felix" <felix.willgerodt@intel.com>]

> -----Original Message-----
> From: Tom Tromey <tom@tromey.com>
> Sent: Dienstag, 14. Februar 2023 16:14
> To: Felix Willgerodt via Gdb-patches <gdb-patches@sourceware.org>
> Cc: Willgerodt, Felix <felix.willgerodt@intel.com>
> Subject: Re: [PATCH 1/1] gdb, fortran: Fix quad floating-point type for ifort
> compiler.
> 
> >>>>> "Felix" == Felix Willgerodt via Gdb-patches <gdb-
> patches@sourceware.org> writes:
> 
> Felix> I fixed this a while ago for ifx, one of the two Intel compilers, in
> Felix> 8d624a9d8050ca96e154215c7858ac5c2d8b0b19.
> 
> Felix> Apparently I missed that the older ifort Intel compiler actually emits
> Felix> slightly different debug info again:
> 
> Thank you, this is ok.
> 
> Approved-By: Tom Tromey <tom@tromey.com>

Thanks, I pushed this now.

> Felix> @@ -8238,12 +8238,14 @@ i386_floatformat_for_type (struct gdbarch
> *gdbarch,
> Felix>  	|| strcmp (name, "_Float128") == 0
> Felix>  	|| strcmp (name, "complex _Float128") == 0
> Felix>  	|| strcmp (name, "complex(kind=16)") == 0
> Felix> +	|| strcmp (name, "COMPLEX(16)") == 0
> Felix>  	|| strcmp (name, "complex*32") == 0
> Felix>  	|| strcmp (name, "COMPLEX*32") == 0
> Felix>  	|| strcmp (name, "quad complex") == 0
> Felix>  	|| strcmp (name, "real(kind=16)") == 0
> Felix>  	|| strcmp (name, "real*16") == 0
> Felix> -	|| strcmp (name, "REAL*16") == 0)
> Felix> +	|| strcmp (name, "REAL*16") == 0
> Felix> +	|| strcmp (name, "REAL(16)") == 0)
> Felix>        return floatformats_ieee_quad;
> 
> Not your fault but this whole approach seems bad.

Agreed. But can we change anything really?

Felix

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928