public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Felix Willgerodt via Gdb-patches <gdb-patches@sourceware.org>
Cc: Felix Willgerodt <felix.willgerodt@intel.com>
Subject: Re: [PATCH 1/1] gdb, fortran: Fix quad floating-point type for ifort compiler.
Date: Tue, 14 Feb 2023 08:14:03 -0700	[thread overview]
Message-ID: <87bklwuvno.fsf@tromey.com> (raw)
In-Reply-To: <20230214110049.649769-1-felix.willgerodt@intel.com> (Felix Willgerodt via Gdb-patches's message of "Tue, 14 Feb 2023 12:00:49 +0100")

>>>>> "Felix" == Felix Willgerodt via Gdb-patches <gdb-patches@sourceware.org> writes:

Felix> I fixed this a while ago for ifx, one of the two Intel compilers, in
Felix> 8d624a9d8050ca96e154215c7858ac5c2d8b0b19.

Felix> Apparently I missed that the older ifort Intel compiler actually emits
Felix> slightly different debug info again:

Thank you, this is ok.

Approved-By: Tom Tromey <tom@tromey.com>

Felix> @@ -8238,12 +8238,14 @@ i386_floatformat_for_type (struct gdbarch *gdbarch,
Felix>  	|| strcmp (name, "_Float128") == 0
Felix>  	|| strcmp (name, "complex _Float128") == 0
Felix>  	|| strcmp (name, "complex(kind=16)") == 0
Felix> +	|| strcmp (name, "COMPLEX(16)") == 0
Felix>  	|| strcmp (name, "complex*32") == 0
Felix>  	|| strcmp (name, "COMPLEX*32") == 0
Felix>  	|| strcmp (name, "quad complex") == 0
Felix>  	|| strcmp (name, "real(kind=16)") == 0
Felix>  	|| strcmp (name, "real*16") == 0
Felix> -	|| strcmp (name, "REAL*16") == 0)
Felix> +	|| strcmp (name, "REAL*16") == 0
Felix> +	|| strcmp (name, "REAL(16)") == 0)
Felix>        return floatformats_ieee_quad;

Not your fault but this whole approach seems bad.

Tom

  reply	other threads:[~2023-02-14 15:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-14 11:00 Felix Willgerodt
2023-02-14 15:14 ` Tom Tromey [this message]
2023-02-15  9:05   ` Willgerodt, Felix
2023-02-15 16:52     ` Tom Tromey
2023-02-20  9:17       ` Willgerodt, Felix
2023-02-24 14:11         ` Tom Tromey
2023-02-28 10:21           ` Willgerodt, Felix

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bklwuvno.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=felix.willgerodt@intel.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).