* [PATCH 1/1] gdb, btrace: Fix rn-dl-bind.exp for new icx remark.
@ 2022-11-11 9:16 Felix Willgerodt
2022-11-11 10:11 ` Metzger, Markus T
0 siblings, 1 reply; 3+ messages in thread
From: Felix Willgerodt @ 2022-11-11 9:16 UTC (permalink / raw)
To: gdb-patches, markus.t.metzger; +Cc: Felix Willgerodt
When running the test with the latest Intel compiler:
Running gdb/gdb/testsuite/gdb.btrace/rn-dl-bind.exp ...
gdb compile failed, icpx: warning: treating 'c' input as 'c++' when
in C++ mode, this behavior is deprecated [-Wdeprecated]
The test doesn't seem to test something specifically for C++,
so I removed the C++ compilation option. Alternatively we could rename
rn-dl-bind.exp.c to rn-dl-bind.exp.cc.
Signed-off-by: Felix Willgerodt <felix.willgerodt@intel.com>
---
gdb/testsuite/gdb.btrace/rn-dl-bind.exp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/testsuite/gdb.btrace/rn-dl-bind.exp b/gdb/testsuite/gdb.btrace/rn-dl-bind.exp
index d78f5654131..eb486b33124 100644
--- a/gdb/testsuite/gdb.btrace/rn-dl-bind.exp
+++ b/gdb/testsuite/gdb.btrace/rn-dl-bind.exp
@@ -28,7 +28,7 @@ if { [skip_btrace_tests] } {
standard_testfile
if [prepare_for_testing "failed to prepare" $testfile $srcfile \
- {c++ debug ldflags=-Wl,-z,lazy}] {
+ {debug ldflags=-Wl,-z,lazy}] {
return -1
}
--
2.34.3
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH 1/1] gdb, btrace: Fix rn-dl-bind.exp for new icx remark.
2022-11-11 9:16 [PATCH 1/1] gdb, btrace: Fix rn-dl-bind.exp for new icx remark Felix Willgerodt
@ 2022-11-11 10:11 ` Metzger, Markus T
2022-11-11 12:34 ` Willgerodt, Felix
0 siblings, 1 reply; 3+ messages in thread
From: Metzger, Markus T @ 2022-11-11 10:11 UTC (permalink / raw)
To: Willgerodt, Felix; +Cc: gdb-patches
Thanks, Felix,
>When running the test with the latest Intel compiler:
>
>Running gdb/gdb/testsuite/gdb.btrace/rn-dl-bind.exp ...
>gdb compile failed, icpx: warning: treating 'c' input as 'c++' when
>in C++ mode, this behavior is deprecated [-Wdeprecated]
>
>The test doesn't seem to test something specifically for C++,
>so I removed the C++ compilation option. Alternatively we could rename
>rn-dl-bind.exp.c to rn-dl-bind.exp.cc.
The patch looks good to me. This is plain C.
regards,
markus.
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH 1/1] gdb, btrace: Fix rn-dl-bind.exp for new icx remark.
2022-11-11 10:11 ` Metzger, Markus T
@ 2022-11-11 12:34 ` Willgerodt, Felix
0 siblings, 0 replies; 3+ messages in thread
From: Willgerodt, Felix @ 2022-11-11 12:34 UTC (permalink / raw)
To: Metzger, Markus T; +Cc: gdb-patches
Thanks, I pushed this.
Felix
> -----Original Message-----
> From: Metzger, Markus T <markus.t.metzger@intel.com>
> Sent: Freitag, 11. November 2022 11:12
> To: Willgerodt, Felix <felix.willgerodt@intel.com>
> Cc: gdb-patches@sourceware.org
> Subject: RE: [PATCH 1/1] gdb, btrace: Fix rn-dl-bind.exp for new icx remark.
>
> Thanks, Felix,
>
> >When running the test with the latest Intel compiler:
> >
> >Running gdb/gdb/testsuite/gdb.btrace/rn-dl-bind.exp ...
> >gdb compile failed, icpx: warning: treating 'c' input as 'c++' when
> >in C++ mode, this behavior is deprecated [-Wdeprecated]
> >
> >The test doesn't seem to test something specifically for C++,
> >so I removed the C++ compilation option. Alternatively we could rename
> >rn-dl-bind.exp.c to rn-dl-bind.exp.cc.
>
> The patch looks good to me. This is plain C.
>
> regards,
> markus.
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-11 12:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-11 9:16 [PATCH 1/1] gdb, btrace: Fix rn-dl-bind.exp for new icx remark Felix Willgerodt
2022-11-11 10:11 ` Metzger, Markus T
2022-11-11 12:34 ` Willgerodt, Felix
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).