From: "Aktemur, Tankut Baris" <tankut.baris.aktemur@intel.com>
To: Bruno Larsen <blarsen@redhat.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: RE: [PATCH v2 2/2] gdb: raise and handle NOT_AVAILABLE_ERROR when accessing frame PC
Date: Thu, 24 Mar 2022 08:46:13 +0000 [thread overview]
Message-ID: <MWHPR1101MB2271E128451FCBE9FA48D7DDC4199@MWHPR1101MB2271.namprd11.prod.outlook.com> (raw)
In-Reply-To: <59a6639f-4873-66b9-71f9-733fa656c4ca@redhat.com>
On Wednesday, March 23, 2022 2:35 PM, Bruno Larsen wrote:
> On 3/23/22 09:55, Aktemur, Tankut Baris wrote:
> > On Wednesday, March 16, 2022 6:27 PM, Bruno Larsen wrote:
> >>> Finally, together with its predecessor, this patch also fixes PR gdb/26877.
> >>
> >> While I think this is a good idea, it doesn't seem to fix the root cause of the bug you
> >> mentioned. It does stop the crash that the bug reports, but I would say the actual issue
> is
> >> that GDB is not noticing that the second inferior is also finished. My 2 cents, for what
> >> they're worth.
> >
> > The root cause was an unhandled error in a destructor. The 2-inferior setup was
> > just one way to expose it. From https://sourceware.org/bugzilla/show_bug.cgi?id=26877#c0:
> >
> > The problem is at:
> >
> > #20 0x00005555561128b9 in program_space::~program_space (this=0x55555830a070,
> __in_chrg=<optimized out>) at gdb/progspace.c:153
> >
> > While inside a destructor, GDB wanted to access the frame information
> > of Inferior 2 in a series of calls. But because the process is dead, its
> > registers cannot be read. This raises an error inside a destructor, leading
> > to termination of GDB.
> >
> > From that perspective, I think the root cause is fixed.
> >
>
> It is the root cause of the crash, but GDB is still not aware that the second inferior has
> finished, which is still a problem, IMHO.
I agree that it's a problem. The essence of the problem is that
the other inferior has terminated but this has not been shown to
the user, yet. The event is pending. I believe it can be the
topic of another fix. I'm afraid it's a wider problem outside the
scope of what I submitted.
Regards
-Baris
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
next prev parent reply other threads:[~2022-03-24 8:46 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-08 9:15 [PATCH v2 0/2] Querying registers of already-exited processes Tankut Baris Aktemur
2022-02-08 9:15 ` [PATCH v2 1/2] gdb/regcache: return REG_UNAVAILABLE if raw_update raises NOT_AVAILABLE_ERROR Tankut Baris Aktemur
2022-03-16 15:18 ` Bruno Larsen
2022-03-23 12:55 ` Aktemur, Tankut Baris
2022-02-08 9:15 ` [PATCH v2 2/2] gdb: raise and handle NOT_AVAILABLE_ERROR when accessing frame PC Tankut Baris Aktemur
2022-03-16 17:26 ` Bruno Larsen
2022-03-23 12:55 ` Aktemur, Tankut Baris
2022-03-23 13:34 ` Bruno Larsen
2022-03-24 8:46 ` Aktemur, Tankut Baris [this message]
2022-02-22 7:31 ` [PATCH v2 0/2] Querying registers of already-exited processes Aktemur, Tankut Baris
2022-03-07 8:00 ` Aktemur, Tankut Baris
2022-03-23 13:05 ` [PATCH v3 " Tankut Baris Aktemur
2022-03-23 13:05 ` [PATCH v3 1/2] gdb/regcache: return REG_UNAVAILABLE in raw_read if NOT_AVAILABLE_ERROR is seen Tankut Baris Aktemur
2022-03-23 13:05 ` [PATCH v3 2/2] gdb: raise and handle NOT_AVAILABLE_ERROR when accessing frame PC Tankut Baris Aktemur
2022-05-04 7:19 ` [PATCH v3 0/2] Querying registers of already-exited processes Aktemur, Tankut Baris
2022-12-23 17:10 ` Aktemur, Tankut Baris
2023-01-17 20:40 ` Aktemur, Tankut Baris
2023-01-24 10:35 ` Aktemur, Tankut Baris
2023-01-31 20:14 ` Aktemur, Tankut Baris
2023-02-20 13:07 ` Aktemur, Tankut Baris
2023-03-03 7:46 ` Aktemur, Tankut Baris
2023-03-28 13:40 ` Aktemur, Tankut Baris
2023-12-18 14:40 ` [PATCH v4 " Tankut Baris Aktemur
2023-12-18 14:40 ` [PATCH v4 1/2] gdb/regcache: return REG_UNAVAILABLE in raw_read if NOT_AVAILABLE_ERROR is seen Tankut Baris Aktemur
2023-12-18 14:40 ` [PATCH v4 2/2] gdb: raise and handle NOT_AVAILABLE_ERROR when accessing frame PC Tankut Baris Aktemur
2023-12-20 22:00 ` John Baldwin
2023-12-21 6:41 ` Eli Zaretskii
2023-12-27 18:41 ` Aktemur, Tankut Baris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MWHPR1101MB2271E128451FCBE9FA48D7DDC4199@MWHPR1101MB2271.namprd11.prod.outlook.com \
--to=tankut.baris.aktemur@intel.com \
--cc=blarsen@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).