From: Enze Li <enze.li@hotmail.com>
To: Tom Tromey <tom@tromey.com>,
Enze Li via Gdb-patches <gdb-patches@sourceware.org>
Cc: aburgess@redhat.com, pedro@palves.net, enze.li@gmx.com
Subject: Re: [PATCH v2 1/2] gdb/testsuite: rename get_maint_bp_addr and move it to gdb-utils.exp
Date: Sun, 24 Jul 2022 12:10:03 +0800 [thread overview]
Message-ID: <OS3P286MB215209EE5A5D8E71AC788C0FF0929@OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <877d4eqr58.fsf@tromey.com>
On Fri, 2022-07-15 at 10:25 -0600, Tom Tromey wrote:
> > > > > > "Enze" == Enze Li via Gdb-patches
> > > > > > <gdb-patches@sourceware.org> writes:
>
> Enze> The get_maint_bp_addr procedure will be shared by other test
> suite, so
> Enze> move it to gdb-utils.exp.
>
> Enze> Following Andrew's suggestion, I renamed get_maint_bp_addr to
> Enze> gdb_get_bp_addr, since it would have handled normal breakpoints
> in
> Enze> addition to the internal ones. Note that there is still room
> for
> Enze> improvement in this procedure, which I indicated in comments
> nearby.
>
> This looks good to me, thanks.
>
> Tom
Hi Tom,
Thanks for your review. I'm checking these in now.
Best Regards,
Enze
prev parent reply other threads:[~2022-07-24 4:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-24 14:13 Enze Li
2022-06-24 14:16 ` [PATCH v2 2/2] gdb/testsuite: add a clear test to py-breakpoint.exp Enze Li
2022-07-15 16:27 ` Tom Tromey
2022-07-15 16:25 ` [PATCH v2 1/2] gdb/testsuite: rename get_maint_bp_addr and move it to gdb-utils.exp Tom Tromey
2022-07-24 4:10 ` Enze Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OS3P286MB215209EE5A5D8E71AC788C0FF0929@OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM \
--to=enze.li@hotmail.com \
--cc=aburgess@redhat.com \
--cc=enze.li@gmx.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).