From: Enze Li <enze.li@hotmail.com>
To: gdb-patches@sourceware.org
Cc: enze.li@gmx.com
Subject: [PATCH v2] gdb: some int to bool conversion
Date: Sun, 22 Jan 2023 13:54:20 +0800 [thread overview]
Message-ID: <OS3P286MB2152263B3BD0EFF0254EFB5DF0CB9@OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <OS3P286MB215243E4429C6C8CD05AB540F0CA9@OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM>
When building GDB with clang 16, I got this,
CXX maint.o
maint.c:1045:23: error: implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1 [-Werror,-Wsingle-bit-bitfield-constant-conversion]
m_space_enabled = 1;
^ ~
maint.c:1057:22: error: implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1 [-Werror,-Wsingle-bit-bitfield-constant-conversion]
m_time_enabled = 1;
^ ~
maint.c:1073:24: error: implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1 [-Werror,-Wsingle-bit-bitfield-constant-conversion]
m_symtab_enabled = 1;
^ ~
3 errors generated.
Work around this by using bool bitfields instead.
Tested by rebuilding on x86_64-linux with clang 16 and gcc 12.
---
gdb/maint.c | 12 ++++++------
gdb/maint.h | 6 +++---
2 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/gdb/maint.c b/gdb/maint.c
index 1a226bf75e30..52f91a3246fe 100644
--- a/gdb/maint.c
+++ b/gdb/maint.c
@@ -1042,11 +1042,11 @@ scoped_command_stats::scoped_command_stats (bool msg_type)
#ifdef HAVE_USEFUL_SBRK
char *lim = (char *) sbrk (0);
m_start_space = lim - lim_at_start;
- m_space_enabled = 1;
+ m_space_enabled = true;
#endif
}
else
- m_space_enabled = 0;
+ m_space_enabled = false;
if (msg_type == 0 || per_command_time)
{
@@ -1054,13 +1054,13 @@ scoped_command_stats::scoped_command_stats (bool msg_type)
m_start_cpu_time = run_time_clock::now ();
m_start_wall_time = steady_clock::now ();
- m_time_enabled = 1;
+ m_time_enabled = true;
if (per_command_time)
print_time (_("command started"));
}
else
- m_time_enabled = 0;
+ m_time_enabled = false;
if (msg_type == 0 || per_command_symtab)
{
@@ -1070,10 +1070,10 @@ scoped_command_stats::scoped_command_stats (bool msg_type)
m_start_nr_symtabs = nr_symtabs;
m_start_nr_compunit_symtabs = nr_compunit_symtabs;
m_start_nr_blocks = nr_blocks;
- m_symtab_enabled = 1;
+ m_symtab_enabled = true;
}
else
- m_symtab_enabled = 0;
+ m_symtab_enabled = false;
/* Initialize timer to keep track of how long we waited for the user. */
reset_prompt_for_continue_wait_time ();
diff --git a/gdb/maint.h b/gdb/maint.h
index 09a68c17befd..1741d1325677 100644
--- a/gdb/maint.h
+++ b/gdb/maint.h
@@ -49,9 +49,9 @@ class scoped_command_stats
/* Track whether the stat was enabled at the start of the command
so that we can avoid printing anything if it gets turned on by
the current command. */
- int m_time_enabled : 1;
- int m_space_enabled : 1;
- int m_symtab_enabled : 1;
+ bool m_time_enabled : 1;
+ bool m_space_enabled : 1;
+ bool m_symtab_enabled : 1;
run_time_clock::time_point m_start_cpu_time;
std::chrono::steady_clock::time_point m_start_wall_time;
long m_start_space;
base-commit: 52480b9ef499870c36c8dfb34df31e67df7bb4dd
--
2.39.0
next prev parent reply other threads:[~2023-01-22 5:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-21 14:56 [PATCH] gdb: some int to unsigned int conversion Enze Li
2023-01-21 17:09 ` Tom Tromey
2023-01-22 6:47 ` Enze Li
2023-01-22 5:54 ` Enze Li [this message]
2023-01-22 17:38 ` [PATCH v2] gdb: some int to bool conversion Tom Tromey
2023-01-24 3:21 ` Enze Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OS3P286MB2152263B3BD0EFF0254EFB5DF0CB9@OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM \
--to=enze.li@hotmail.com \
--cc=enze.li@gmx.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).