public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Enze Li <enze.li@hotmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org,  enze.li@gmx.com
Subject: Re: [PATCH] gdb/doc: fix a makeinfo warning
Date: Thu, 01 Jun 2023 09:42:23 +0800	[thread overview]
Message-ID: <OS3P286MB2152471FC4A2D2955859CA20F0499@OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <83o7m0eeky.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 31 May 2023 10:53:54 -0400")

On Wed, May 31 2023 at 10:53:54 AM -0400, Eli Zaretskii wrote:

>> Cc: enze.li@gmx.com
>> Date: Wed, 31 May 2023 22:13:41 +0800
>> From: Enze Li via Gdb-patches <gdb-patches@sourceware.org>
>> 
>> I see this warning when compiling GDB,
>> 
>>   gdb.texinfo:5975: warning: undefined flag: GDB
>>   gdb.texinfo:5976: warning: undefined flag: GDB
>> 
>> and consequently I see the misprints in doc/gdb/Dynamic-Printf.html as
>> follow,
>> 
>>   ...Most of {No value for ‘GDB’}’s format specifiers...
>> 
>> Fix this by using '@value{GDBN}' instead of '@value{GDB}'.
>> ---
>>  gdb/doc/gdb.texinfo | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>> 
>> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
>> index 4bc83ed2168..a179af77224 100644
>> --- a/gdb/doc/gdb.texinfo
>> +++ b/gdb/doc/gdb.texinfo
>> @@ -5972,8 +5972,8 @@ Handle the output by calling a function in your program (normally
>>  @code{printf}).  When using this style the supported format specifiers
>>  depend entirely on the function being called.
>>  
>> -Most of @value{GDB}'s format specifiers align with those supported by
>> -the @code{printf} function, however, @value{GDB}'s @samp{%V} format
>> +Most of @value{GDBN}'s format specifiers align with those supported by
>> +the @code{printf} function, however, @value{GDBN}'s @samp{%V} format
>>  specifier extension is not supported by @code{printf}.  When using
>>  @samp{call} style dprintf, care should be taken to ensure that only
>>  format specifiers supported by the output function are used, otherwise
>
> Thanks, this is an "obvious fix".

Hi Eli,

It is necessary to be cautious for a new contributor.  Thank you for your
guidance, next time I will carefully try to submit such obvious errors.

Best Regards,
Enze

      reply	other threads:[~2023-06-01  1:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-31 14:13 Enze Li
2023-05-31 14:40 ` Tom Tromey
2023-06-01  1:34   ` Enze Li
2023-05-31 14:54 ` Eli Zaretskii
2023-06-01  1:42   ` Enze Li [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=OS3P286MB2152471FC4A2D2955859CA20F0499@OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM \
    --to=enze.li@hotmail.com \
    --cc=eliz@gnu.org \
    --cc=enze.li@gmx.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).