* [PATCH] gdb/doc: fix a makeinfo warning
@ 2023-05-31 14:13 Enze Li
2023-05-31 14:40 ` Tom Tromey
2023-05-31 14:54 ` Eli Zaretskii
0 siblings, 2 replies; 5+ messages in thread
From: Enze Li @ 2023-05-31 14:13 UTC (permalink / raw)
To: gdb-patches; +Cc: enze.li
I see this warning when compiling GDB,
gdb.texinfo:5975: warning: undefined flag: GDB
gdb.texinfo:5976: warning: undefined flag: GDB
and consequently I see the misprints in doc/gdb/Dynamic-Printf.html as
follow,
...Most of {No value for ‘GDB’}’s format specifiers...
Fix this by using '@value{GDBN}' instead of '@value{GDB}'.
---
gdb/doc/gdb.texinfo | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
index 4bc83ed2168..a179af77224 100644
--- a/gdb/doc/gdb.texinfo
+++ b/gdb/doc/gdb.texinfo
@@ -5972,8 +5972,8 @@ Handle the output by calling a function in your program (normally
@code{printf}). When using this style the supported format specifiers
depend entirely on the function being called.
-Most of @value{GDB}'s format specifiers align with those supported by
-the @code{printf} function, however, @value{GDB}'s @samp{%V} format
+Most of @value{GDBN}'s format specifiers align with those supported by
+the @code{printf} function, however, @value{GDBN}'s @samp{%V} format
specifier extension is not supported by @code{printf}. When using
@samp{call} style dprintf, care should be taken to ensure that only
format specifiers supported by the output function are used, otherwise
base-commit: 6e9bcaad3fd8f7635afb9fa7013762da2eeff8e5
--
2.40.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] gdb/doc: fix a makeinfo warning
2023-05-31 14:13 [PATCH] gdb/doc: fix a makeinfo warning Enze Li
@ 2023-05-31 14:40 ` Tom Tromey
2023-06-01 1:34 ` Enze Li
2023-05-31 14:54 ` Eli Zaretskii
1 sibling, 1 reply; 5+ messages in thread
From: Tom Tromey @ 2023-05-31 14:40 UTC (permalink / raw)
To: Enze Li via Gdb-patches; +Cc: Enze Li, enze.li
>>>>> "Enze" == Enze Li via Gdb-patches <gdb-patches@sourceware.org> writes:
Enze> I see this warning when compiling GDB,
Enze> gdb.texinfo:5975: warning: undefined flag: GDB
Enze> gdb.texinfo:5976: warning: undefined flag: GDB
Enze> and consequently I see the misprints in doc/gdb/Dynamic-Printf.html as
Enze> follow,
Thanks. I noticed this as well and I pushed a fix for it before I saw
yours.
Tom
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] gdb/doc: fix a makeinfo warning
2023-05-31 14:13 [PATCH] gdb/doc: fix a makeinfo warning Enze Li
2023-05-31 14:40 ` Tom Tromey
@ 2023-05-31 14:54 ` Eli Zaretskii
2023-06-01 1:42 ` Enze Li
1 sibling, 1 reply; 5+ messages in thread
From: Eli Zaretskii @ 2023-05-31 14:54 UTC (permalink / raw)
To: Enze Li; +Cc: gdb-patches, enze.li
> Cc: enze.li@gmx.com
> Date: Wed, 31 May 2023 22:13:41 +0800
> From: Enze Li via Gdb-patches <gdb-patches@sourceware.org>
>
> I see this warning when compiling GDB,
>
> gdb.texinfo:5975: warning: undefined flag: GDB
> gdb.texinfo:5976: warning: undefined flag: GDB
>
> and consequently I see the misprints in doc/gdb/Dynamic-Printf.html as
> follow,
>
> ...Most of {No value for ‘GDB’}’s format specifiers...
>
> Fix this by using '@value{GDBN}' instead of '@value{GDB}'.
> ---
> gdb/doc/gdb.texinfo | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
> index 4bc83ed2168..a179af77224 100644
> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -5972,8 +5972,8 @@ Handle the output by calling a function in your program (normally
> @code{printf}). When using this style the supported format specifiers
> depend entirely on the function being called.
>
> -Most of @value{GDB}'s format specifiers align with those supported by
> -the @code{printf} function, however, @value{GDB}'s @samp{%V} format
> +Most of @value{GDBN}'s format specifiers align with those supported by
> +the @code{printf} function, however, @value{GDBN}'s @samp{%V} format
> specifier extension is not supported by @code{printf}. When using
> @samp{call} style dprintf, care should be taken to ensure that only
> format specifiers supported by the output function are used, otherwise
Thanks, this is an "obvious fix".
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] gdb/doc: fix a makeinfo warning
2023-05-31 14:40 ` Tom Tromey
@ 2023-06-01 1:34 ` Enze Li
0 siblings, 0 replies; 5+ messages in thread
From: Enze Li @ 2023-06-01 1:34 UTC (permalink / raw)
To: Tom Tromey; +Cc: Enze Li via Gdb-patches, enze.li
On Wed, May 31 2023 at 08:40:24 AM -0600, Tom Tromey wrote:
>>>>>> "Enze" == Enze Li via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Enze> I see this warning when compiling GDB,
> Enze> gdb.texinfo:5975: warning: undefined flag: GDB
> Enze> gdb.texinfo:5976: warning: undefined flag: GDB
>
> Enze> and consequently I see the misprints in doc/gdb/Dynamic-Printf.html as
> Enze> follow,
>
> Thanks. I noticed this as well and I pushed a fix for it before I saw
> yours.
>
> Tom
Hi Tom,
It's okay to drop this one. Anyway, thanks for fixing this.
Cheers!
Enze
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] gdb/doc: fix a makeinfo warning
2023-05-31 14:54 ` Eli Zaretskii
@ 2023-06-01 1:42 ` Enze Li
0 siblings, 0 replies; 5+ messages in thread
From: Enze Li @ 2023-06-01 1:42 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: gdb-patches, enze.li
On Wed, May 31 2023 at 10:53:54 AM -0400, Eli Zaretskii wrote:
>> Cc: enze.li@gmx.com
>> Date: Wed, 31 May 2023 22:13:41 +0800
>> From: Enze Li via Gdb-patches <gdb-patches@sourceware.org>
>>
>> I see this warning when compiling GDB,
>>
>> gdb.texinfo:5975: warning: undefined flag: GDB
>> gdb.texinfo:5976: warning: undefined flag: GDB
>>
>> and consequently I see the misprints in doc/gdb/Dynamic-Printf.html as
>> follow,
>>
>> ...Most of {No value for ‘GDB’}’s format specifiers...
>>
>> Fix this by using '@value{GDBN}' instead of '@value{GDB}'.
>> ---
>> gdb/doc/gdb.texinfo | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
>> index 4bc83ed2168..a179af77224 100644
>> --- a/gdb/doc/gdb.texinfo
>> +++ b/gdb/doc/gdb.texinfo
>> @@ -5972,8 +5972,8 @@ Handle the output by calling a function in your program (normally
>> @code{printf}). When using this style the supported format specifiers
>> depend entirely on the function being called.
>>
>> -Most of @value{GDB}'s format specifiers align with those supported by
>> -the @code{printf} function, however, @value{GDB}'s @samp{%V} format
>> +Most of @value{GDBN}'s format specifiers align with those supported by
>> +the @code{printf} function, however, @value{GDBN}'s @samp{%V} format
>> specifier extension is not supported by @code{printf}. When using
>> @samp{call} style dprintf, care should be taken to ensure that only
>> format specifiers supported by the output function are used, otherwise
>
> Thanks, this is an "obvious fix".
Hi Eli,
It is necessary to be cautious for a new contributor. Thank you for your
guidance, next time I will carefully try to submit such obvious errors.
Best Regards,
Enze
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-06-01 1:42 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-31 14:13 [PATCH] gdb/doc: fix a makeinfo warning Enze Li
2023-05-31 14:40 ` Tom Tromey
2023-06-01 1:34 ` Enze Li
2023-05-31 14:54 ` Eli Zaretskii
2023-06-01 1:42 ` Enze Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).