From: Enze Li <enze.li@hotmail.com>
To: Tom Tromey <tom@tromey.com>
Cc: Enze Li via Gdb-patches <gdb-patches@sourceware.org>, enze.li@gmx.com
Subject: Re: [PATCH] gdb/testsuite: update a pattern in gdb_file_cmd
Date: Tue, 13 Dec 2022 22:28:27 +0800 [thread overview]
Message-ID: <OS3P286MB21527BE6BB9A44FE43E4A0A8F0E39@OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <87tu24h3n1.fsf@tromey.com> (Tom Tromey's message of "Fri, 09 Dec 2022 10:45:54 -0700")
On Fri, Dec 09 2022 at 10:45:54 AM -0700, Tom Tromey wrote:
> Enze> Then run the selftest.exp, I see:
>
> Thanks for doing this.
>
> Not your problem really, but these self-tests have been difficult for a
> long time. In the long run I hope we can get rid of them entirely and
> replace them with unit tests where possible.
>
> Tom
Hi Tom,
How about we document this idea in the TODO list? This will make it
easier for others to know about the requirement.
--- a/gdb/testsuite/TODO
+++ b/gdb/testsuite/TODO
@@ -195,6 +195,8 @@ prologues will need to look different. For sparc, the immediate field
is 13 bits (signed), so I believe the threshold would be 4K bytes in a
frame).
+Whenever possible, replace self-tests with unit tests.
+
^L
(this is for editing this file with GNU emacs)
Local Variables:
I dunno if this file still makes sense, and since it exists, I guess it
would be appropriate to document it here.
WDYT?
Best Regards,
Enze
next prev parent reply other threads:[~2022-12-13 14:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 13:06 Enze Li
2022-12-07 15:01 ` Simon Marchi
2022-12-08 14:36 ` Tom de Vries
2022-12-09 17:45 ` Tom Tromey
2022-12-13 14:28 ` Enze Li [this message]
2022-12-13 16:23 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OS3P286MB21527BE6BB9A44FE43E4A0A8F0E39@OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM \
--to=enze.li@hotmail.com \
--cc=enze.li@gmx.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).