Re: [PATCH] gdb/csky modify registers list for general_reggroup

[Enze Li <enze.li@hotmail.com>]

On Tue, 2022-07-12 at 11:21 +0800, Enze Li via Gdb-patches wrote:
> Hi Jiangshuai,
> 
> Thanks for doing this.  I found some minor nits with the coding
> style.
> Pls see below.
> 
> On Tue, 2022-07-12 at 10:23 +0800, Jiangshuai Li wrote:
> > there are two modification points here:
>   ^^^^^
> there -> There
> 
> > 1. for the debugging of csky architecture, after executing "info
> > register",
> >    we hope to print out GPRs, PC and the registers related to
> > exceptions
> > 2. with tdesc-xml, users can view the register groups described in
> > XML
> > ---
> >  gdb/csky-tdep.c | 12 +++++++++++-
> >  1 file changed, 11 insertions(+), 1 deletion(-)
> > 
> > diff --git a/gdb/csky-tdep.c b/gdb/csky-tdep.c
> > index 502b01e33e1..fcdb865eb87 100644
> > --- a/gdb/csky-tdep.c
> > +++ b/gdb/csky-tdep.c
> > @@ -2518,7 +2518,11 @@ csky_register_reggroup_p (struct gdbarch
> > *gdbarch, int regnum,
> >    if (reggroup == save_reggroup || reggroup == restore_reggroup)
> >      return raw_p;
> >  
> > -  if (((regnum >= CSKY_R0_REGNUM) && (regnum <= CSKY_R0_REGNUM +
> > 31))
> > +  if ((((regnum >= CSKY_R0_REGNUM) && (regnum <= CSKY_R0_REGNUM +
> > 31))
> > +       || (regnum == CSKY_PC_REGNUM)
> > +       || (regnum == CSKY_EPC_REGNUM)
> > +       || (regnum == CSKY_CR0_REGNUM)
> > +       || (regnum == CSKY_EPSR_REGNUM))
> >        && (reggroup == general_reggroup))
> >      return 1;
> >  
> > @@ -2548,6 +2552,10 @@ csky_register_reggroup_p (struct gdbarch
> > *gdbarch, int regnum,
> >        && (reggroup == fr_reggroup))
> >      return 6;
> >  
> > +  if (tdesc_has_registers (gdbarch_target_desc (gdbarch)))
> > +    if (tdesc_register_in_reggroup_p (gdbarch, regnum, reggroup) >
> > 0)
> > +      return 7;
> > +
> 
> Accounting to the GDB C/C++ coding standards (See here[1]), "Any two
> or
> more lines in code should be wrapped in braces".
> 
> I think this part should be like this:
> 
> ```
> if (tdesc_has_registers (gdbarch_target_desc (gdbarch)))  {
>     if (tdesc_register_in_reggroup_p (gdbarch, regnum, reggroup) > 0)
> 	return 7;
>   }
> ```

Correction:

if (tdesc_has_registers (gdbarch_target_desc (gdbarch)))
  {
    if (tdesc_register_in_reggroup_p (gdbarch, regnum, reggroup) > 0)
	return 7;
  }

> 
> [1] 
> https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards#Whitespaces
> 
> Thanks,
> Enze
> 
> >    return 0;
> >  }
> >  
> > @@ -3020,6 +3028,8 @@ csky_gdbarch_init (struct gdbarch_info info,
> > struct gdbarch_list *arches)
> >        set_gdbarch_num_regs (gdbarch, (num_regs + 1));
> >        tdesc_use_registers (gdbarch, info.target_desc, std::move
> > (tdesc_data));
> >        set_gdbarch_register_type (gdbarch, csky_register_type);
> > +      set_gdbarch_register_reggroup_p (gdbarch,
> > +                                       csky_register_reggroup_p);
> >      }
> >  
> >    if (tdep->fv_pseudo_registers_count)
>   }
>