Re: [PATCH] gdb/netbsd: add missing header file

[Enze Li <enze.li@hotmail.com>]

On Sun, 2022-07-24 at 21:01 -0400, Simon Marchi wrote:
> 
> 
> On 2022-07-23 22:55, Enze Li via Gdb-patches wrote:
> > I ran into this error when building GDB on NetBSD:
> > 
> >   CXX    netbsd-nat.o
> > netbsd-nat.c: In member function 'virtual bool
> > nbsd_nat_target::info_proc(const char*, info_proc_what)':
> > netbsd-nat.c:314:3: error: 'gdb_argv' was not declared in this
> > scope
> >    gdb_argv built_argv (args);
> >    ^~~~~~~~
> > netbsd-nat.c:314:3: note: suggested alternative: 'gdbarch'
> >    gdb_argv built_argv (args);
> >    ^~~~~~~~
> >    gdbarch
> > netbsd-nat.c:315:7: error: 'built_argv' was not declared in this
> > scope
> >    if (built_argv.count () == 0)
> >        ^~~~~~~~~~
> > netbsd-nat.c:315:7: note: suggested alternative: 'buildargv'
> >    if (built_argv.count () == 0)
> >        ^~~~~~~~~~
> >        buildargv
> > gmake[2]: *** [Makefile:1893: netbsd-nat.o] Error 1
> > 
> > Fix this by adding the missing header file, as it is obvious.
> > 
> > Tested by rebuilding on NetBSD/amd64.
> > ---
> >  gdb/netbsd-nat.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/gdb/netbsd-nat.c b/gdb/netbsd-nat.c
> > index c45df391afc..8a4a43270d6 100644
> > --- a/gdb/netbsd-nat.c
> > +++ b/gdb/netbsd-nat.c
> > @@ -25,6 +25,7 @@
> >  #include "netbsd-tdep.h"
> >  #include "inferior.h"
> >  #include "gdbarch.h"
> > +#include "gdbsupport/buildargv.h"
> >  
> >  #include <sys/types.h>
> >  #include <sys/ptrace.h>
> 
> LGTM.
> 
> Simon

Thanks, Simon.  Pushed.

Enze