public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
* [PING 2] [PATCH 0/4] Adapt Fortran testsuite for ifort
@ 2022-07-04 10:29 Kempke, Nils-Christian
  2022-07-04 13:54 ` Enze Li
  0 siblings, 1 reply; 8+ messages in thread
From: Kempke, Nils-Christian @ 2022-07-04 10:29 UTC (permalink / raw)
  To: Kempke, Nils-Christian, gdb-patches

Ping!

Thanks,
Nils

> -----Original Message-----
> From: Gdb-patches <gdb-patches-bounces+nils-
> christian.kempke=intel.com@sourceware.org> On Behalf Of Kempke, Nils-
> Christian via Gdb-patches
> Sent: Monday, June 27, 2022 6:59 AM
> To: gdb-patches@sourceware.org
> Subject: [PING] [PATCH 0/4] Adapt Fortran testsuite for ifort
> 
> Ping!
> 
> Thanks, Nils
> 
> > -----Original Message-----
> > From: Kempke, Nils-Christian <nils-christian.kempke@intel.com>
> > Sent: Friday, June 10, 2022 5:45 PM
> > To: gdb-patches@sourceware.org
> > Cc: Kempke, Nils-Christian <nils-christian.kempke@intel.com>
> > Subject: [PATCH 0/4] Adapt Fortran testsuite for ifort
> >
> > Hi,
> >
> > there were a few places in the testsuite where ifort's behavior was
> > FAILing the tests and where I think this is not the result of an ifort
> > bug but rather of a testsuite not forgiving enough.
> >
> > The attached patches should not change the behavior for any other
> > compiler, and I could not find any regressions with gfortran/ifx (tested
> > with unix, unix/m32, native-gdbserver and native-extended-gdbserver).
> >
> > For ifort this series improves testsuite performance if compared to the
> > current master:
> >
> > master before series:
> >
> >                 === gdb Summary ===
> >
> >   # of expected passes            5771
> >   # of unexpected failures        238
> >   # of unknown successes          1
> >   # of known failures             1
> >   # of untested testcases         1
> >   # of unresolved testcases       3
> >   # of unsupported tests          5
> >   # of duplicate test names       3
> >
> > master after series:
> >
> >                 === gdb Summary ===
> >
> >   # of expected passes            5847
> >   # of unexpected failures        161
> >   # of known failures             1
> >   # of untested testcases         1
> >   # of unresolved testcases       3
> >   # of unsupported tests          5
> >   # of duplicate test names       3
> >
> >
> > Any feedback is appreciated,
> >
> > Cheers,
> > Nils
> >
> > Nils-Christian Kempke (4):
> >   testsuite, fortran: make mixed-lang-stack less compiler dependent
> >   testsuite, fortran: Remove self assignment non-statements
> >   testsuite, fortran: adapt tests for ifort's 'start' behavior
> >   testsuite, fortran: make kfail gfortran specific
> >
> >  gdb/testsuite/gdb.fortran/array-slices-bad.exp    |  5 ++++-
> >  gdb/testsuite/gdb.fortran/function-calls.exp      |  4 +++-
> >  gdb/testsuite/gdb.fortran/library-module-lib.f90  |  2 +-
> >  gdb/testsuite/gdb.fortran/library-module-main.f90 |  2 +-
> >  gdb/testsuite/gdb.fortran/mixed-lang-stack.exp    |  9 ++++++++-
> >  gdb/testsuite/gdb.fortran/module.f90              | 11 ++++++-----
> >  gdb/testsuite/gdb.fortran/vla-type.exp            |  5 +++--
> >  7 files changed, 26 insertions(+), 12 deletions(-)
> >
> > --
> > 2.25.1
> 
> Intel Deutschland GmbH
> Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
> Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
> Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
> Chairperson of the Supervisory Board: Nicole Lau
> Registered Office: Munich
> Commercial Register: Amtsgericht Muenchen HRB 186928

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PING 2] [PATCH 0/4] Adapt Fortran testsuite for ifort
  2022-07-04 10:29 [PING 2] [PATCH 0/4] Adapt Fortran testsuite for ifort Kempke, Nils-Christian
@ 2022-07-04 13:54 ` Enze Li
  2022-07-04 14:03   ` Kempke, Nils-Christian
  0 siblings, 1 reply; 8+ messages in thread
From: Enze Li @ 2022-07-04 13:54 UTC (permalink / raw)
  To: Kempke, Nils-Christian, gdb-patches

Hi Nils,

A friendly reminder that it is not easy to review patches outside of
the threaded email.  It would be nice if you could reply "PING"
directly in the threaded email.  That way, others can see the patches
*directly* instead of searching through the mailing list.

Thanks,
Enze

On Mon, 2022-07-04 at 10:29 +0000, Kempke, Nils-Christian via Gdb-
patches wrote:
> Ping!
> 
> Thanks,
> Nils
> 
> > -----Original Message-----
> > From: Gdb-patches <gdb-patches-bounces+nils-
> > christian.kempke=intel.com@sourceware.org> On Behalf Of Kempke,
> > Nils-
> > Christian via Gdb-patches
> > Sent: Monday, June 27, 2022 6:59 AM
> > To: gdb-patches@sourceware.org
> > Subject: [PING] [PATCH 0/4] Adapt Fortran testsuite for ifort
> > 
> > Ping!
> > 
> > Thanks, Nils
> > 
> > > -----Original Message-----
> > > From: Kempke, Nils-Christian <nils-christian.kempke@intel.com>
> > > Sent: Friday, June 10, 2022 5:45 PM
> > > To: gdb-patches@sourceware.org
> > > Cc: Kempke, Nils-Christian <nils-christian.kempke@intel.com>
> > > Subject: [PATCH 0/4] Adapt Fortran testsuite for ifort
> > > 
> > > Hi,
> > > 
> > > there were a few places in the testsuite where ifort's behavior
> > > was
> > > FAILing the tests and where I think this is not the result of an
> > > ifort
> > > bug but rather of a testsuite not forgiving enough.
> > > 
> > > The attached patches should not change the behavior for any other
> > > compiler, and I could not find any regressions with gfortran/ifx
> > > (tested
> > > with unix, unix/m32, native-gdbserver and native-extended-
> > > gdbserver).
> > > 
> > > For ifort this series improves testsuite performance if compared
> > > to the
> > > current master:
> > > 
> > > master before series:
> > > 
> > >                 === gdb Summary ===
> > > 
> > >   # of expected passes            5771
> > >   # of unexpected failures        238
> > >   # of unknown successes          1
> > >   # of known failures             1
> > >   # of untested testcases         1
> > >   # of unresolved testcases       3
> > >   # of unsupported tests          5
> > >   # of duplicate test names       3
> > > 
> > > master after series:
> > > 
> > >                 === gdb Summary ===
> > > 
> > >   # of expected passes            5847
> > >   # of unexpected failures        161
> > >   # of known failures             1
> > >   # of untested testcases         1
> > >   # of unresolved testcases       3
> > >   # of unsupported tests          5
> > >   # of duplicate test names       3
> > > 
> > > 
> > > Any feedback is appreciated,
> > > 
> > > Cheers,
> > > Nils
> > > 
> > > Nils-Christian Kempke (4):
> > >   testsuite, fortran: make mixed-lang-stack less compiler
> > > dependent
> > >   testsuite, fortran: Remove self assignment non-statements
> > >   testsuite, fortran: adapt tests for ifort's 'start' behavior
> > >   testsuite, fortran: make kfail gfortran specific
> > > 
> > >  gdb/testsuite/gdb.fortran/array-slices-bad.exp    |  5 ++++-
> > >  gdb/testsuite/gdb.fortran/function-calls.exp      |  4 +++-
> > >  gdb/testsuite/gdb.fortran/library-module-lib.f90  |  2 +-
> > >  gdb/testsuite/gdb.fortran/library-module-main.f90 |  2 +-
> > >  gdb/testsuite/gdb.fortran/mixed-lang-stack.exp    |  9 ++++++++-
> > >  gdb/testsuite/gdb.fortran/module.f90              | 11 ++++++---
> > > --
> > >  gdb/testsuite/gdb.fortran/vla-type.exp            |  5 +++--
> > >  7 files changed, 26 insertions(+), 12 deletions(-)
> > > 
> > > --
> > > 2.25.1
> > 
> > Intel Deutschland GmbH
> > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
> > Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
> > Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon
> > Silva
> > Chairperson of the Supervisory Board: Nicole Lau
> > Registered Office: Munich
> > Commercial Register: Amtsgericht Muenchen HRB 186928
> 
> Intel Deutschland GmbH
> Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
> Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
> Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon
> Silva  
> Chairperson of the Supervisory Board: Nicole Lau
> Registered Office: Munich
> Commercial Register: Amtsgericht Muenchen HRB 186928
> 


^ permalink raw reply	[flat|nested] 8+ messages in thread

* RE: [PING 2] [PATCH 0/4] Adapt Fortran testsuite for ifort
  2022-07-04 13:54 ` Enze Li
@ 2022-07-04 14:03   ` Kempke, Nils-Christian
  2022-07-04 14:43     ` Kempke, Nils-Christian
  0 siblings, 1 reply; 8+ messages in thread
From: Kempke, Nils-Christian @ 2022-07-04 14:03 UTC (permalink / raw)
  To: Enze Li, gdb-patches

Hi Enze,

Yes, this was also not what I intended.  Seems like I already messed that up in
my first ping.

Thanks for pointing it out, I'll ping the original message again. This thread can
be ignored then.

Cheers,
Nils

> -----Original Message-----
> From: Enze Li <enze.li@hotmail.com>
> Sent: Monday, July 4, 2022 3:54 PM
> To: Kempke, Nils-Christian <nils-christian.kempke@intel.com>; gdb-
> patches@sourceware.org
> Subject: Re: [PING 2] [PATCH 0/4] Adapt Fortran testsuite for ifort
> 
> Hi Nils,
> 
> A friendly reminder that it is not easy to review patches outside of
> the threaded email.  It would be nice if you could reply "PING"
> directly in the threaded email.  That way, others can see the patches
> *directly* instead of searching through the mailing list.
> 
> Thanks,
> Enze
> 
> On Mon, 2022-07-04 at 10:29 +0000, Kempke, Nils-Christian via Gdb-
> patches wrote:
> > Ping!
> >
> > Thanks,
> > Nils
> >
> > > -----Original Message-----
> > > From: Gdb-patches <gdb-patches-bounces+nils-
> > > christian.kempke=intel.com@sourceware.org> On Behalf Of Kempke,
> > > Nils-
> > > Christian via Gdb-patches
> > > Sent: Monday, June 27, 2022 6:59 AM
> > > To: gdb-patches@sourceware.org
> > > Subject: [PING] [PATCH 0/4] Adapt Fortran testsuite for ifort
> > >
> > > Ping!
> > >
> > > Thanks, Nils
> > >
> > > > -----Original Message-----
> > > > From: Kempke, Nils-Christian <nils-christian.kempke@intel.com>
> > > > Sent: Friday, June 10, 2022 5:45 PM
> > > > To: gdb-patches@sourceware.org
> > > > Cc: Kempke, Nils-Christian <nils-christian.kempke@intel.com>
> > > > Subject: [PATCH 0/4] Adapt Fortran testsuite for ifort
> > > >
> > > > Hi,
> > > >
> > > > there were a few places in the testsuite where ifort's behavior
> > > > was
> > > > FAILing the tests and where I think this is not the result of an
> > > > ifort
> > > > bug but rather of a testsuite not forgiving enough.
> > > >
> > > > The attached patches should not change the behavior for any other
> > > > compiler, and I could not find any regressions with gfortran/ifx
> > > > (tested
> > > > with unix, unix/m32, native-gdbserver and native-extended-
> > > > gdbserver).
> > > >
> > > > For ifort this series improves testsuite performance if compared
> > > > to the
> > > > current master:
> > > >
> > > > master before series:
> > > >
> > > >                 === gdb Summary ===
> > > >
> > > >   # of expected passes            5771
> > > >   # of unexpected failures        238
> > > >   # of unknown successes          1
> > > >   # of known failures             1
> > > >   # of untested testcases         1
> > > >   # of unresolved testcases       3
> > > >   # of unsupported tests          5
> > > >   # of duplicate test names       3
> > > >
> > > > master after series:
> > > >
> > > >                 === gdb Summary ===
> > > >
> > > >   # of expected passes            5847
> > > >   # of unexpected failures        161
> > > >   # of known failures             1
> > > >   # of untested testcases         1
> > > >   # of unresolved testcases       3
> > > >   # of unsupported tests          5
> > > >   # of duplicate test names       3
> > > >
> > > >
> > > > Any feedback is appreciated,
> > > >
> > > > Cheers,
> > > > Nils
> > > >
> > > > Nils-Christian Kempke (4):
> > > >   testsuite, fortran: make mixed-lang-stack less compiler
> > > > dependent
> > > >   testsuite, fortran: Remove self assignment non-statements
> > > >   testsuite, fortran: adapt tests for ifort's 'start' behavior
> > > >   testsuite, fortran: make kfail gfortran specific
> > > >
> > > >  gdb/testsuite/gdb.fortran/array-slices-bad.exp    |  5 ++++-
> > > >  gdb/testsuite/gdb.fortran/function-calls.exp      |  4 +++-
> > > >  gdb/testsuite/gdb.fortran/library-module-lib.f90  |  2 +-
> > > >  gdb/testsuite/gdb.fortran/library-module-main.f90 |  2 +-
> > > >  gdb/testsuite/gdb.fortran/mixed-lang-stack.exp    |  9 ++++++++-
> > > >  gdb/testsuite/gdb.fortran/module.f90              | 11 ++++++---
> > > > --
> > > >  gdb/testsuite/gdb.fortran/vla-type.exp            |  5 +++--
> > > >  7 files changed, 26 insertions(+), 12 deletions(-)
> > > >
> > > > --
> > > > 2.25.1
> > >
> > > Intel Deutschland GmbH
> > > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
> > > Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
> > > Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon
> > > Silva
> > > Chairperson of the Supervisory Board: Nicole Lau
> > > Registered Office: Munich
> > > Commercial Register: Amtsgericht Muenchen HRB 186928
> >
> > Intel Deutschland GmbH
> > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
> > Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
> > Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon
> > Silva
> > Chairperson of the Supervisory Board: Nicole Lau
> > Registered Office: Munich
> > Commercial Register: Amtsgericht Muenchen HRB 186928
> >

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928

^ permalink raw reply	[flat|nested] 8+ messages in thread

* RE: [PING 2] [PATCH 0/4] Adapt Fortran testsuite for ifort
  2022-07-04 14:03   ` Kempke, Nils-Christian
@ 2022-07-04 14:43     ` Kempke, Nils-Christian
  2022-07-04 14:49       ` Bruno Larsen
  0 siblings, 1 reply; 8+ messages in thread
From: Kempke, Nils-Christian @ 2022-07-04 14:43 UTC (permalink / raw)
  To: Kempke, Nils-Christian, Enze Li, gdb-patches

To clarify (and please correct me, if my way of pinging is wrong):

I normally hit 'reply all',  either on the original message if this was the first
ping or on the latest ping if this was a subsequent ping. Then, I modify the subject
to 'RE: [PING N] ORIGINAL TITLE' and add my little ping body to the email. Then I
send that message.

Is this wrong? 

I see that I somehow messed up the first ping for this message (in June) - it is not listed
in the same thread as the original message - so apparently it was not a reply to it..
I might have removed the 'RE:' in the title of that messge?

But anyhow, this is how I understood

https://sourceware.org/gdb/wiki/ContributionChecklist#Ping_and_keep_pinging

and Joels mail on the patches list.

Cheers,
Nils

> -----Original Message-----
> From: Gdb-patches <gdb-patches-bounces+nils-
> christian.kempke=intel.com@sourceware.org> On Behalf Of Kempke, Nils-
> Christian via Gdb-patches
> Sent: Monday, July 4, 2022 4:04 PM
> To: Enze Li <enze.li@hotmail.com>; gdb-patches@sourceware.org
> Subject: RE: [PING 2] [PATCH 0/4] Adapt Fortran testsuite for ifort
> 
> Hi Enze,
> 
> Yes, this was also not what I intended.  Seems like I already messed that up in
> my first ping.
> 
> Thanks for pointing it out, I'll ping the original message again. This thread can
> be ignored then.
> 
> Cheers,
> Nils
> 
> > -----Original Message-----
> > From: Enze Li <enze.li@hotmail.com>
> > Sent: Monday, July 4, 2022 3:54 PM
> > To: Kempke, Nils-Christian <nils-christian.kempke@intel.com>; gdb-
> > patches@sourceware.org
> > Subject: Re: [PING 2] [PATCH 0/4] Adapt Fortran testsuite for ifort
> >
> > Hi Nils,
> >
> > A friendly reminder that it is not easy to review patches outside of
> > the threaded email.  It would be nice if you could reply "PING"
> > directly in the threaded email.  That way, others can see the patches
> > *directly* instead of searching through the mailing list.
> >
> > Thanks,
> > Enze
> >
> > On Mon, 2022-07-04 at 10:29 +0000, Kempke, Nils-Christian via Gdb-
> > patches wrote:
> > > Ping!
> > >
> > > Thanks,
> > > Nils
> > >
> > > > -----Original Message-----
> > > > From: Gdb-patches <gdb-patches-bounces+nils-
> > > > christian.kempke=intel.com@sourceware.org> On Behalf Of Kempke,
> > > > Nils-
> > > > Christian via Gdb-patches
> > > > Sent: Monday, June 27, 2022 6:59 AM
> > > > To: gdb-patches@sourceware.org
> > > > Subject: [PING] [PATCH 0/4] Adapt Fortran testsuite for ifort
> > > >
> > > > Ping!
> > > >
> > > > Thanks, Nils
> > > >
> > > > > -----Original Message-----
> > > > > From: Kempke, Nils-Christian <nils-christian.kempke@intel.com>
> > > > > Sent: Friday, June 10, 2022 5:45 PM
> > > > > To: gdb-patches@sourceware.org
> > > > > Cc: Kempke, Nils-Christian <nils-christian.kempke@intel.com>
> > > > > Subject: [PATCH 0/4] Adapt Fortran testsuite for ifort
> > > > >
> > > > > Hi,
> > > > >
> > > > > there were a few places in the testsuite where ifort's behavior
> > > > > was
> > > > > FAILing the tests and where I think this is not the result of an
> > > > > ifort
> > > > > bug but rather of a testsuite not forgiving enough.
> > > > >
> > > > > The attached patches should not change the behavior for any other
> > > > > compiler, and I could not find any regressions with gfortran/ifx
> > > > > (tested
> > > > > with unix, unix/m32, native-gdbserver and native-extended-
> > > > > gdbserver).
> > > > >
> > > > > For ifort this series improves testsuite performance if compared
> > > > > to the
> > > > > current master:
> > > > >
> > > > > master before series:
> > > > >
> > > > >                 === gdb Summary ===
> > > > >
> > > > >   # of expected passes            5771
> > > > >   # of unexpected failures        238
> > > > >   # of unknown successes          1
> > > > >   # of known failures             1
> > > > >   # of untested testcases         1
> > > > >   # of unresolved testcases       3
> > > > >   # of unsupported tests          5
> > > > >   # of duplicate test names       3
> > > > >
> > > > > master after series:
> > > > >
> > > > >                 === gdb Summary ===
> > > > >
> > > > >   # of expected passes            5847
> > > > >   # of unexpected failures        161
> > > > >   # of known failures             1
> > > > >   # of untested testcases         1
> > > > >   # of unresolved testcases       3
> > > > >   # of unsupported tests          5
> > > > >   # of duplicate test names       3
> > > > >
> > > > >
> > > > > Any feedback is appreciated,
> > > > >
> > > > > Cheers,
> > > > > Nils
> > > > >
> > > > > Nils-Christian Kempke (4):
> > > > >   testsuite, fortran: make mixed-lang-stack less compiler
> > > > > dependent
> > > > >   testsuite, fortran: Remove self assignment non-statements
> > > > >   testsuite, fortran: adapt tests for ifort's 'start' behavior
> > > > >   testsuite, fortran: make kfail gfortran specific
> > > > >
> > > > >  gdb/testsuite/gdb.fortran/array-slices-bad.exp    |  5 ++++-
> > > > >  gdb/testsuite/gdb.fortran/function-calls.exp      |  4 +++-
> > > > >  gdb/testsuite/gdb.fortran/library-module-lib.f90  |  2 +-
> > > > >  gdb/testsuite/gdb.fortran/library-module-main.f90 |  2 +-
> > > > >  gdb/testsuite/gdb.fortran/mixed-lang-stack.exp    |  9 ++++++++-
> > > > >  gdb/testsuite/gdb.fortran/module.f90              | 11 ++++++---
> > > > > --
> > > > >  gdb/testsuite/gdb.fortran/vla-type.exp            |  5 +++--
> > > > >  7 files changed, 26 insertions(+), 12 deletions(-)
> > > > >
> > > > > --
> > > > > 2.25.1
> > > >
> > > > Intel Deutschland GmbH
> > > > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
> > > > Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
> > > > Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon
> > > > Silva
> > > > Chairperson of the Supervisory Board: Nicole Lau
> > > > Registered Office: Munich
> > > > Commercial Register: Amtsgericht Muenchen HRB 186928
> > >
> > > Intel Deutschland GmbH
> > > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
> > > Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
> > > Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon
> > > Silva
> > > Chairperson of the Supervisory Board: Nicole Lau
> > > Registered Office: Munich
> > > Commercial Register: Amtsgericht Muenchen HRB 186928
> > >
> 
> Intel Deutschland GmbH
> Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
> Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
> Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
> Chairperson of the Supervisory Board: Nicole Lau
> Registered Office: Munich
> Commercial Register: Amtsgericht Muenchen HRB 186928
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PING 2] [PATCH 0/4] Adapt Fortran testsuite for ifort
  2022-07-04 14:43     ` Kempke, Nils-Christian
@ 2022-07-04 14:49       ` Bruno Larsen
  2022-07-04 16:09         ` Kempke, Nils-Christian
  0 siblings, 1 reply; 8+ messages in thread
From: Bruno Larsen @ 2022-07-04 14:49 UTC (permalink / raw)
  To: Kempke, Nils-Christian, Enze Li, gdb-patches

This is likely a problem with the rest of your emailing chain (either client or outgoing server)

I remember when using the Outlook web-based interface, if I removed the "Re:" from the subject,
it would remove the In-Reply-To header, which messed up the threading. I think Exchange was at
fault, but I'm not sure, someone else fixed this for me...

Cheers!
Bruno Larsen

On 7/4/22 11:43, Kempke, Nils-Christian via Gdb-patches wrote:
> To clarify (and please correct me, if my way of pinging is wrong):
> 
> I normally hit 'reply all',  either on the original message if this was the first
> ping or on the latest ping if this was a subsequent ping. Then, I modify the subject
> to 'RE: [PING N] ORIGINAL TITLE' and add my little ping body to the email. Then I
> send that message.
> 
> Is this wrong?
> 
> I see that I somehow messed up the first ping for this message (in June) - it is not listed
> in the same thread as the original message - so apparently it was not a reply to it..
> I might have removed the 'RE:' in the title of that messge?
> 
> But anyhow, this is how I understood
> 
> https://sourceware.org/gdb/wiki/ContributionChecklist#Ping_and_keep_pinging
> 
> and Joels mail on the patches list.
> 
> Cheers,
> Nils
> 
>> -----Original Message-----
>> From: Gdb-patches <gdb-patches-bounces+nils-
>> christian.kempke=intel.com@sourceware.org> On Behalf Of Kempke, Nils-
>> Christian via Gdb-patches
>> Sent: Monday, July 4, 2022 4:04 PM
>> To: Enze Li <enze.li@hotmail.com>; gdb-patches@sourceware.org
>> Subject: RE: [PING 2] [PATCH 0/4] Adapt Fortran testsuite for ifort
>>
>> Hi Enze,
>>
>> Yes, this was also not what I intended.  Seems like I already messed that up in
>> my first ping.
>>
>> Thanks for pointing it out, I'll ping the original message again. This thread can
>> be ignored then.
>>
>> Cheers,
>> Nils
>>
>>> -----Original Message-----
>>> From: Enze Li <enze.li@hotmail.com>
>>> Sent: Monday, July 4, 2022 3:54 PM
>>> To: Kempke, Nils-Christian <nils-christian.kempke@intel.com>; gdb-
>>> patches@sourceware.org
>>> Subject: Re: [PING 2] [PATCH 0/4] Adapt Fortran testsuite for ifort
>>>
>>> Hi Nils,
>>>
>>> A friendly reminder that it is not easy to review patches outside of
>>> the threaded email.  It would be nice if you could reply "PING"
>>> directly in the threaded email.  That way, others can see the patches
>>> *directly* instead of searching through the mailing list.
>>>
>>> Thanks,
>>> Enze
>>>
>>> On Mon, 2022-07-04 at 10:29 +0000, Kempke, Nils-Christian via Gdb-
>>> patches wrote:
>>>> Ping!
>>>>
>>>> Thanks,
>>>> Nils
>>>>
>>>>> -----Original Message-----
>>>>> From: Gdb-patches <gdb-patches-bounces+nils-
>>>>> christian.kempke=intel.com@sourceware.org> On Behalf Of Kempke,
>>>>> Nils-
>>>>> Christian via Gdb-patches
>>>>> Sent: Monday, June 27, 2022 6:59 AM
>>>>> To: gdb-patches@sourceware.org
>>>>> Subject: [PING] [PATCH 0/4] Adapt Fortran testsuite for ifort
>>>>>
>>>>> Ping!
>>>>>
>>>>> Thanks, Nils
>>>>>
>>>>>> -----Original Message-----
>>>>>> From: Kempke, Nils-Christian <nils-christian.kempke@intel.com>
>>>>>> Sent: Friday, June 10, 2022 5:45 PM
>>>>>> To: gdb-patches@sourceware.org
>>>>>> Cc: Kempke, Nils-Christian <nils-christian.kempke@intel.com>
>>>>>> Subject: [PATCH 0/4] Adapt Fortran testsuite for ifort
>>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> there were a few places in the testsuite where ifort's behavior
>>>>>> was
>>>>>> FAILing the tests and where I think this is not the result of an
>>>>>> ifort
>>>>>> bug but rather of a testsuite not forgiving enough.
>>>>>>
>>>>>> The attached patches should not change the behavior for any other
>>>>>> compiler, and I could not find any regressions with gfortran/ifx
>>>>>> (tested
>>>>>> with unix, unix/m32, native-gdbserver and native-extended-
>>>>>> gdbserver).
>>>>>>
>>>>>> For ifort this series improves testsuite performance if compared
>>>>>> to the
>>>>>> current master:
>>>>>>
>>>>>> master before series:
>>>>>>
>>>>>>                  === gdb Summary ===
>>>>>>
>>>>>>    # of expected passes            5771
>>>>>>    # of unexpected failures        238
>>>>>>    # of unknown successes          1
>>>>>>    # of known failures             1
>>>>>>    # of untested testcases         1
>>>>>>    # of unresolved testcases       3
>>>>>>    # of unsupported tests          5
>>>>>>    # of duplicate test names       3
>>>>>>
>>>>>> master after series:
>>>>>>
>>>>>>                  === gdb Summary ===
>>>>>>
>>>>>>    # of expected passes            5847
>>>>>>    # of unexpected failures        161
>>>>>>    # of known failures             1
>>>>>>    # of untested testcases         1
>>>>>>    # of unresolved testcases       3
>>>>>>    # of unsupported tests          5
>>>>>>    # of duplicate test names       3
>>>>>>
>>>>>>
>>>>>> Any feedback is appreciated,
>>>>>>
>>>>>> Cheers,
>>>>>> Nils
>>>>>>
>>>>>> Nils-Christian Kempke (4):
>>>>>>    testsuite, fortran: make mixed-lang-stack less compiler
>>>>>> dependent
>>>>>>    testsuite, fortran: Remove self assignment non-statements
>>>>>>    testsuite, fortran: adapt tests for ifort's 'start' behavior
>>>>>>    testsuite, fortran: make kfail gfortran specific
>>>>>>
>>>>>>   gdb/testsuite/gdb.fortran/array-slices-bad.exp    |  5 ++++-
>>>>>>   gdb/testsuite/gdb.fortran/function-calls.exp      |  4 +++-
>>>>>>   gdb/testsuite/gdb.fortran/library-module-lib.f90  |  2 +-
>>>>>>   gdb/testsuite/gdb.fortran/library-module-main.f90 |  2 +-
>>>>>>   gdb/testsuite/gdb.fortran/mixed-lang-stack.exp    |  9 ++++++++-
>>>>>>   gdb/testsuite/gdb.fortran/module.f90              | 11 ++++++---
>>>>>> --
>>>>>>   gdb/testsuite/gdb.fortran/vla-type.exp            |  5 +++--
>>>>>>   7 files changed, 26 insertions(+), 12 deletions(-)
>>>>>>
>>>>>> --
>>>>>> 2.25.1
>>>>>
>>>>> Intel Deutschland GmbH
>>>>> Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
>>>>> Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
>>>>> Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon
>>>>> Silva
>>>>> Chairperson of the Supervisory Board: Nicole Lau
>>>>> Registered Office: Munich
>>>>> Commercial Register: Amtsgericht Muenchen HRB 186928
>>>>
>>>> Intel Deutschland GmbH
>>>> Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
>>>> Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
>>>> Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon
>>>> Silva
>>>> Chairperson of the Supervisory Board: Nicole Lau
>>>> Registered Office: Munich
>>>> Commercial Register: Amtsgericht Muenchen HRB 186928
>>>>
>>
>> Intel Deutschland GmbH
>> Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
>> Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
>> Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
>> Chairperson of the Supervisory Board: Nicole Lau
>> Registered Office: Munich
>> Commercial Register: Amtsgericht Muenchen HRB 186928
> Intel Deutschland GmbH
> Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
> Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
> Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
> Chairperson of the Supervisory Board: Nicole Lau
> Registered Office: Munich
> Commercial Register: Amtsgericht Muenchen HRB 186928


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PING 2] [PATCH 0/4] Adapt Fortran testsuite for ifort
  2022-07-04 14:49       ` Bruno Larsen
@ 2022-07-04 16:09         ` Kempke, Nils-Christian
  2022-07-05 13:01           ` Enze Li
  0 siblings, 1 reply; 8+ messages in thread
From: Kempke, Nils-Christian @ 2022-07-04 16:09 UTC (permalink / raw)
  To: Bruno Larsen, Enze Li, gdb-patches

Hi Bruno,

mh, ok, thanks! I'll investigate this and try to find a way that 'fixes' the outlook
behavior.

Actually, not using outlook but using the exchange online interface it appears to be
working for me. I just sent a second "[PING 2]" for my ifort patches series here

https://sourceware.org/pipermail/gdb-patches/2022-July/190490.html

and in my outlook it is now being shown as a reply to the original version of the
patches.

The mailing list sorted the reply somewhat weirdly (as a reply to the first message with
the title [PING 2]) but either way @Enze is this what you meant?

The [PING 2] mail shows to contain the

In-Reply-To: <20220610154500.374897-1-nils-christian.kempke@intel.com>

header and the ID seems to actually be the ID of the original message:

Message-ID: <20220610154500.374897-1-nils-christian.kempke@intel.com>

is part of the original message's header.

If this way is fine I'll go ahead and start using the exchange web interface..

Cheers,
Nils
________________________________
From: Bruno Larsen <blarsen@redhat.com>
Sent: Monday, July 4, 2022 4:49 PM
To: Kempke, Nils-Christian <nils-christian.kempke@intel.com>; Enze Li <enze.li@hotmail.com>; gdb-patches@sourceware.org <gdb-patches@sourceware.org>
Subject: Re: [PING 2] [PATCH 0/4] Adapt Fortran testsuite for ifort

This is likely a problem with the rest of your emailing chain (either client or outgoing server)

I remember when using the Outlook web-based interface, if I removed the "Re:" from the subject,
it would remove the In-Reply-To header, which messed up the threading. I think Exchange was at
fault, but I'm not sure, someone else fixed this for me...

Cheers!
Bruno Larsen

On 7/4/22 11:43, Kempke, Nils-Christian via Gdb-patches wrote:
> To clarify (and please correct me, if my way of pinging is wrong):
>
> I normally hit 'reply all',  either on the original message if this was the first
> ping or on the latest ping if this was a subsequent ping. Then, I modify the subject
> to 'RE: [PING N] ORIGINAL TITLE' and add my little ping body to the email. Then I
> send that message.
>
> Is this wrong?
>
> I see that I somehow messed up the first ping for this message (in June) - it is not listed
> in the same thread as the original message - so apparently it was not a reply to it..
> I might have removed the 'RE:' in the title of that messge?
>
> But anyhow, this is how I understood
>
> https://sourceware.org/gdb/wiki/ContributionChecklist#Ping_and_keep_pinging
>
> and Joels mail on the patches list.
>
> Cheers,
> Nils
>
>> -----Original Message-----
>> From: Gdb-patches <gdb-patches-bounces+nils-
>> christian.kempke=intel.com@sourceware.org> On Behalf Of Kempke, Nils-
>> Christian via Gdb-patches
>> Sent: Monday, July 4, 2022 4:04 PM
>> To: Enze Li <enze.li@hotmail.com>; gdb-patches@sourceware.org
>> Subject: RE: [PING 2] [PATCH 0/4] Adapt Fortran testsuite for ifort
>>
>> Hi Enze,
>>
>> Yes, this was also not what I intended.  Seems like I already messed that up in
>> my first ping.
>>
>> Thanks for pointing it out, I'll ping the original message again. This thread can
>> be ignored then.
>>
>> Cheers,
>> Nils
>>
>>> -----Original Message-----
>>> From: Enze Li <enze.li@hotmail.com>
>>> Sent: Monday, July 4, 2022 3:54 PM
>>> To: Kempke, Nils-Christian <nils-christian.kempke@intel.com>; gdb-
>>> patches@sourceware.org
>>> Subject: Re: [PING 2] [PATCH 0/4] Adapt Fortran testsuite for ifort
>>>
>>> Hi Nils,
>>>
>>> A friendly reminder that it is not easy to review patches outside of
>>> the threaded email.  It would be nice if you could reply "PING"
>>> directly in the threaded email.  That way, others can see the patches
>>> *directly* instead of searching through the mailing list.
>>>
>>> Thanks,
>>> Enze
>>>
>>> On Mon, 2022-07-04 at 10:29 +0000, Kempke, Nils-Christian via Gdb-
>>> patches wrote:
>>>> Ping!
>>>>
>>>> Thanks,
>>>> Nils
>>>>
>>>>> -----Original Message-----
>>>>> From: Gdb-patches <gdb-patches-bounces+nils-
>>>>> christian.kempke=intel.com@sourceware.org> On Behalf Of Kempke,
>>>>> Nils-
>>>>> Christian via Gdb-patches
>>>>> Sent: Monday, June 27, 2022 6:59 AM
>>>>> To: gdb-patches@sourceware.org
>>>>> Subject: [PING] [PATCH 0/4] Adapt Fortran testsuite for ifort
>>>>>
>>>>> Ping!
>>>>>
>>>>> Thanks, Nils
>>>>>
>>>>>> -----Original Message-----
>>>>>> From: Kempke, Nils-Christian <nils-christian.kempke@intel.com>
>>>>>> Sent: Friday, June 10, 2022 5:45 PM
>>>>>> To: gdb-patches@sourceware.org
>>>>>> Cc: Kempke, Nils-Christian <nils-christian.kempke@intel.com>
>>>>>> Subject: [PATCH 0/4] Adapt Fortran testsuite for ifort
>>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> there were a few places in the testsuite where ifort's behavior
>>>>>> was
>>>>>> FAILing the tests and where I think this is not the result of an
>>>>>> ifort
>>>>>> bug but rather of a testsuite not forgiving enough.
>>>>>>
>>>>>> The attached patches should not change the behavior for any other
>>>>>> compiler, and I could not find any regressions with gfortran/ifx
>>>>>> (tested
>>>>>> with unix, unix/m32, native-gdbserver and native-extended-
>>>>>> gdbserver).
>>>>>>
>>>>>> For ifort this series improves testsuite performance if compared
>>>>>> to the
>>>>>> current master:
>>>>>>
>>>>>> master before series:
>>>>>>
>>>>>>                  === gdb Summary ===
>>>>>>
>>>>>>    # of expected passes            5771
>>>>>>    # of unexpected failures        238
>>>>>>    # of unknown successes          1
>>>>>>    # of known failures             1
>>>>>>    # of untested testcases         1
>>>>>>    # of unresolved testcases       3
>>>>>>    # of unsupported tests          5
>>>>>>    # of duplicate test names       3
>>>>>>
>>>>>> master after series:
>>>>>>
>>>>>>                  === gdb Summary ===
>>>>>>
>>>>>>    # of expected passes            5847
>>>>>>    # of unexpected failures        161
>>>>>>    # of known failures             1
>>>>>>    # of untested testcases         1
>>>>>>    # of unresolved testcases       3
>>>>>>    # of unsupported tests          5
>>>>>>    # of duplicate test names       3
>>>>>>
>>>>>>
>>>>>> Any feedback is appreciated,
>>>>>>
>>>>>> Cheers,
>>>>>> Nils
>>>>>>
>>>>>> Nils-Christian Kempke (4):
>>>>>>    testsuite, fortran: make mixed-lang-stack less compiler
>>>>>> dependent
>>>>>>    testsuite, fortran: Remove self assignment non-statements
>>>>>>    testsuite, fortran: adapt tests for ifort's 'start' behavior
>>>>>>    testsuite, fortran: make kfail gfortran specific
>>>>>>
>>>>>>   gdb/testsuite/gdb.fortran/array-slices-bad.exp    |  5 ++++-
>>>>>>   gdb/testsuite/gdb.fortran/function-calls.exp      |  4 +++-
>>>>>>   gdb/testsuite/gdb.fortran/library-module-lib.f90  |  2 +-
>>>>>>   gdb/testsuite/gdb.fortran/library-module-main.f90 |  2 +-
>>>>>>   gdb/testsuite/gdb.fortran/mixed-lang-stack.exp    |  9 ++++++++-
>>>>>>   gdb/testsuite/gdb.fortran/module.f90              | 11 ++++++---
>>>>>> --
>>>>>>   gdb/testsuite/gdb.fortran/vla-type.exp            |  5 +++--
>>>>>>   7 files changed, 26 insertions(+), 12 deletions(-)
>>>>>>
>>>>>> --
>>>>>> 2.25.1
>>>>>
>>>>> Intel Deutschland GmbH
>>>>> Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
>>>>> Tel: +49 89 99 8853-0, www.intel.de<http://www.intel.de> <http://www.intel.de>
>>>>> Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon
>>>>> Silva
>>>>> Chairperson of the Supervisory Board: Nicole Lau
>>>>> Registered Office: Munich
>>>>> Commercial Register: Amtsgericht Muenchen HRB 186928
>>>>
>>>> Intel Deutschland GmbH
>>>> Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
>>>> Tel: +49 89 99 8853-0, www.intel.de<http://www.intel.de> <http://www.intel.de>
>>>> Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon
>>>> Silva
>>>> Chairperson of the Supervisory Board: Nicole Lau
>>>> Registered Office: Munich
>>>> Commercial Register: Amtsgericht Muenchen HRB 186928
>>>>
>>
>> Intel Deutschland GmbH
>> Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
>> Tel: +49 89 99 8853-0, www.intel.de<http://www.intel.de> <http://www.intel.de>
>> Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
>> Chairperson of the Supervisory Board: Nicole Lau
>> Registered Office: Munich
>> Commercial Register: Amtsgericht Muenchen HRB 186928
> Intel Deutschland GmbH
> Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
> Tel: +49 89 99 8853-0, www.intel.de<http://www.intel.de> <http://www.intel.de>
> Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
> Chairperson of the Supervisory Board: Nicole Lau
> Registered Office: Munich
> Commercial Register: Amtsgericht Muenchen HRB 186928

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PING 2] [PATCH 0/4] Adapt Fortran testsuite for ifort
  2022-07-04 16:09         ` Kempke, Nils-Christian
@ 2022-07-05 13:01           ` Enze Li
  0 siblings, 0 replies; 8+ messages in thread
From: Enze Li @ 2022-07-05 13:01 UTC (permalink / raw)
  To: Kempke, Nils-Christian, Bruno Larsen, gdb-patches

On Mon, 2022-07-04 at 16:09 +0000, Kempke, Nils-Christian wrote:
> Hi Bruno,
> 
> mh, ok, thanks! I'll investigate this and try to find a way that
> 'fixes' the outlook
> behavior.
> 
> Actually, not using outlook but using the exchange online interface
> it appears to be
> working for me. I just sent a second "[PING 2]" for my ifort patches
> series here
> 
> https://sourceware.org/pipermail/gdb-patches/2022-July/190490.html
> 
> and in my outlook it is now being shown as a reply to the original
> version of the
> patches.
> 
> The mailing list sorted the reply somewhat weirdly (as a reply to the
> first message with
> the title [PING 2]) but either way @Enze is this what you meant?

I don't think it's a mailing list issue.  I looked at the header file
of your [PING 2] email and I don't see the "In-Reply-To" section in the
email I received here.  I think this is why your reply email is not
immediately followed by the previous patches in the mailing list.

I got this filed from your [PING 2] email:

Message-Id:
<CY4PR1101MB2071023C22B49A125ADDFE91B8BE9@CY4PR1101MB2071.namprd11.prod.outlook.com
>

It seems that your server has changed your original Message-ID filed,
and dropped the In-Reply-To filed. Anyway, I see that you have fixed
the problem, excellent! 😉

Thanks,
Enze
  
> 
> The [PING 2] mail shows to contain the
> 
> In-Reply-To:
> <20220610154500.374897-1-nils-christian.kempke@intel.com>
> 
> header and the ID seems to actually be the ID of the original
> message:
> 
> Message-ID: <20220610154500.374897-1-nils-christian.kempke@intel.com>
> 
> is part of the original message's header.
> 
> If this way is fine I'll go ahead and start using the exchange web
> interface..
> 
> Cheers,
> Nils
> From: Bruno Larsen <blarsen@redhat.com>
> Sent: Monday, July 4, 2022 4:49 PM
> To: Kempke, Nils-Christian <nils-christian.kempke@intel.com>; Enze Li
> <enze.li@hotmail.com>; gdb-patches@sourceware.org
> <gdb-patches@sourceware.org>
> Subject: Re: [PING 2] [PATCH 0/4] Adapt Fortran testsuite for ifort
>  
> This is likely a problem with the rest of your emailing chain (either
> client or outgoing server)
> 
> I remember when using the Outlook web-based interface, if I removed
> the "Re:" from the subject,
> it would remove the In-Reply-To header, which messed up the
> threading. I think Exchange was at
> fault, but I'm not sure, someone else fixed this for me...
> 
> Cheers!
> Bruno Larsen
> 
> On 7/4/22 11:43, Kempke, Nils-Christian via Gdb-patches wrote:
> > To clarify (and please correct me, if my way of pinging is wrong):
> > 
> > I normally hit 'reply all',  either on the original message if this
> > was the first
> > ping or on the latest ping if this was a subsequent ping. Then, I
> > modify the subject
> > to 'RE: [PING N] ORIGINAL TITLE' and add my little ping body to the
> > email. Then I
> > send that message.
> > 
> > Is this wrong?
> > 
> > I see that I somehow messed up the first ping for this message (in
> > June) - it is not listed
> > in the same thread as the original message - so apparently it was
> > not a reply to it..
> > I might have removed the 'RE:' in the title of that messge?
> > 
> > But anyhow, this is how I understood
> > 
> > https://sourceware.org/gdb/wiki/ContributionChecklist#Ping_and_keep_pinging
> > 
> > and Joels mail on the patches list.
> > 
> > Cheers,
> > Nils
> > 
> > > -----Original Message-----
> > > From: Gdb-patches <gdb-patches-bounces+nils-
> > > christian.kempke=intel.com@sourceware.org> On Behalf Of Kempke,
> > > Nils-
> > > Christian via Gdb-patches
> > > Sent: Monday, July 4, 2022 4:04 PM
> > > To: Enze Li <enze.li@hotmail.com>; gdb-patches@sourceware.org
> > > Subject: RE: [PING 2] [PATCH 0/4] Adapt Fortran testsuite for
> > > ifort
> > > 
> > > Hi Enze,
> > > 
> > > Yes, this was also not what I intended.  Seems like I already
> > > messed that up in
> > > my first ping.
> > > 
> > > Thanks for pointing it out, I'll ping the original message again.
> > > This thread can
> > > be ignored then.
> > > 
> > > Cheers,
> > > Nils
> > > 
> > > > -----Original Message-----
> > > > From: Enze Li <enze.li@hotmail.com>
> > > > Sent: Monday, July 4, 2022 3:54 PM
> > > > To: Kempke, Nils-Christian <nils-christian.kempke@intel.com>;
> > > > gdb-
> > > > patches@sourceware.org
> > > > Subject: Re: [PING 2] [PATCH 0/4] Adapt Fortran testsuite for
> > > > ifort
> > > > 
> > > > Hi Nils,
> > > > 
> > > > A friendly reminder that it is not easy to review patches
> > > > outside of
> > > > the threaded email.  It would be nice if you could reply "PING"
> > > > directly in the threaded email.  That way, others can see the
> > > > patches
> > > > *directly* instead of searching through the mailing list.
> > > > 
> > > > Thanks,
> > > > Enze
> > > > 
> > > > On Mon, 2022-07-04 at 10:29 +0000, Kempke, Nils-Christian via
> > > > Gdb-
> > > > patches wrote:
> > > > > Ping!
> > > > > 
> > > > > Thanks,
> > > > > Nils
> > > > > 
> > > > > > -----Original Message-----
> > > > > > From: Gdb-patches <gdb-patches-bounces+nils-
> > > > > > christian.kempke=intel.com@sourceware.org> On Behalf Of
> > > > > > Kempke,
> > > > > > Nils-
> > > > > > Christian via Gdb-patches
> > > > > > Sent: Monday, June 27, 2022 6:59 AM
> > > > > > To: gdb-patches@sourceware.org
> > > > > > Subject: [PING] [PATCH 0/4] Adapt Fortran testsuite for
> > > > > > ifort
> > > > > > 
> > > > > > Ping!
> > > > > > 
> > > > > > Thanks, Nils
> > > > > > 
> > > > > > > -----Original Message-----
> > > > > > > From: Kempke, Nils-Christian
> > > > > > > <nils-christian.kempke@intel.com>
> > > > > > > Sent: Friday, June 10, 2022 5:45 PM
> > > > > > > To: gdb-patches@sourceware.org
> > > > > > > Cc: Kempke, Nils-Christian
> > > > > > > <nils-christian.kempke@intel.com>
> > > > > > > Subject: [PATCH 0/4] Adapt Fortran testsuite for ifort
> > > > > > > 
> > > > > > > Hi,
> > > > > > > 
> > > > > > > there were a few places in the testsuite where ifort's
> > > > > > > behavior
> > > > > > > was
> > > > > > > FAILing the tests and where I think this is not the
> > > > > > > result of an
> > > > > > > ifort
> > > > > > > bug but rather of a testsuite not forgiving enough.
> > > > > > > 
> > > > > > > The attached patches should not change the behavior for
> > > > > > > any other
> > > > > > > compiler, and I could not find any regressions with
> > > > > > > gfortran/ifx
> > > > > > > (tested
> > > > > > > with unix, unix/m32, native-gdbserver and native-
> > > > > > > extended-
> > > > > > > gdbserver).
> > > > > > > 
> > > > > > > For ifort this series improves testsuite performance if
> > > > > > > compared
> > > > > > > to the
> > > > > > > current master:
> > > > > > > 
> > > > > > > master before series:
> > > > > > > 
> > > > > > >                   === gdb Summary ===
> > > > > > > 
> > > > > > >     # of expected passes            5771
> > > > > > >     # of unexpected failures        238
> > > > > > >     # of unknown successes          1
> > > > > > >     # of known failures             1
> > > > > > >     # of untested testcases         1
> > > > > > >     # of unresolved testcases       3
> > > > > > >     # of unsupported tests          5
> > > > > > >     # of duplicate test names       3
> > > > > > > 
> > > > > > > master after series:
> > > > > > > 
> > > > > > >                   === gdb Summary ===
> > > > > > > 
> > > > > > >     # of expected passes            5847
> > > > > > >     # of unexpected failures        161
> > > > > > >     # of known failures             1
> > > > > > >     # of untested testcases         1
> > > > > > >     # of unresolved testcases       3
> > > > > > >     # of unsupported tests          5
> > > > > > >     # of duplicate test names       3
> > > > > > > 
> > > > > > > 
> > > > > > > Any feedback is appreciated,
> > > > > > > 
> > > > > > > Cheers,
> > > > > > > Nils
> > > > > > > 
> > > > > > > Nils-Christian Kempke (4):
> > > > > > >     testsuite, fortran: make mixed-lang-stack less
> > > > > > > compiler
> > > > > > > dependent
> > > > > > >     testsuite, fortran: Remove self assignment non-
> > > > > > > statements
> > > > > > >     testsuite, fortran: adapt tests for ifort's 'start'
> > > > > > > behavior
> > > > > > >     testsuite, fortran: make kfail gfortran specific
> > > > > > > 
> > > > > > >    gdb/testsuite/gdb.fortran/array-slices-bad.exp    |  5
> > > > > > > ++++-
> > > > > > >    gdb/testsuite/gdb.fortran/function-calls.exp      |  4
> > > > > > > +++-
> > > > > > >    gdb/testsuite/gdb.fortran/library-module-lib.f90  |  2
> > > > > > > +-
> > > > > > >    gdb/testsuite/gdb.fortran/library-module-main.f90 |  2
> > > > > > > +-
> > > > > > >    gdb/testsuite/gdb.fortran/mixed-lang-stack.exp    |  9
> > > > > > > ++++++++-
> > > > > > >    gdb/testsuite/gdb.fortran/module.f90              | 11
> > > > > > > ++++++---
> > > > > > > --
> > > > > > >    gdb/testsuite/gdb.fortran/vla-type.exp            |  5
> > > > > > > +++--
> > > > > > >    7 files changed, 26 insertions(+), 12 deletions(-)
> > > > > > > 
> > > > > > > --
> > > > > > > 2.25.1
> > > > > > 
> > > > > > Intel Deutschland GmbH
> > > > > > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
> > > > > > Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
> > > > > > Managing Directors: Christin Eisenschmid, Sharon Heck,
> > > > > > Tiffany Doon
> > > > > > Silva
> > > > > > Chairperson of the Supervisory Board: Nicole Lau
> > > > > > Registered Office: Munich
> > > > > > Commercial Register: Amtsgericht Muenchen HRB 186928
> > > > > 
> > > > > Intel Deutschland GmbH
> > > > > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
> > > > > Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
> > > > > Managing Directors: Christin Eisenschmid, Sharon Heck,
> > > > > Tiffany Doon
> > > > > Silva
> > > > > Chairperson of the Supervisory Board: Nicole Lau
> > > > > Registered Office: Munich
> > > > > Commercial Register: Amtsgericht Muenchen HRB 186928
> > > > > 
> > > 
> > > Intel Deutschland GmbH
> > > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
> > > Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
> > > Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany
> > > Doon Silva
> > > Chairperson of the Supervisory Board: Nicole Lau
> > > Registered Office: Munich
> > > Commercial Register: Amtsgericht Muenchen HRB 186928
> > Intel Deutschland GmbH
> > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
> > Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
> > Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon
> > Silva
> > Chairperson of the Supervisory Board: Nicole Lau
> > Registered Office: Munich
> > Commercial Register: Amtsgericht Muenchen HRB 186928
> 
> Intel Deutschland GmbH
> Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
> Tel: +49 89 99 8853-0, www.intel.de
> Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon
> Silva   
> Chairperson of the Supervisory Board: Nicole Lau
> Registered Office: Munich
> Commercial Register: Amtsgericht Muenchen HRB 186928


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PING 2][PATCH 0/4] Adapt Fortran testsuite for ifort
  2022-06-10 15:44 Nils-Christian Kempke
@ 2022-07-04 15:59 ` Kempke, Nils-Christian
  0 siblings, 0 replies; 8+ messages in thread
From: Kempke, Nils-Christian @ 2022-07-04 15:59 UTC (permalink / raw)
  To: gdb-patches

Ping!

Cheers,
Nils
________________________________
From: Kempke, Nils-Christian <nils-christian.kempke@intel.com>
Sent: Friday, June 10, 2022 5:44 PM
To: gdb-patches@sourceware.org <gdb-patches@sourceware.org>
Cc: Kempke, Nils-Christian <nils-christian.kempke@intel.com>
Subject: [PATCH 0/4] Adapt Fortran testsuite for ifort

Hi,

there were a few places in the testsuite where ifort's behavior was
FAILing the tests and where I think this is not the result of an ifort
bug but rather of a testsuite not forgiving enough.

The attached patches should not change the behavior for any other
compiler, and I could not find any regressions with gfortran/ifx (tested
with unix, unix/m32, native-gdbserver and native-extended-gdbserver).

For ifort this series improves testsuite performance if compared to the
current master:

master before series:

                === gdb Summary ===

  # of expected passes            5771
  # of unexpected failures        238
  # of unknown successes          1
  # of known failures             1
  # of untested testcases         1
  # of unresolved testcases       3
  # of unsupported tests          5
  # of duplicate test names       3

master after series:

                === gdb Summary ===

  # of expected passes            5847
  # of unexpected failures        161
  # of known failures             1
  # of untested testcases         1
  # of unresolved testcases       3
  # of unsupported tests          5
  # of duplicate test names       3


Any feedback is appreciated,

Cheers,
Nils

Nils-Christian Kempke (4):
  testsuite, fortran: make mixed-lang-stack less compiler dependent
  testsuite, fortran: Remove self assignment non-statements
  testsuite, fortran: adapt tests for ifort's 'start' behavior
  testsuite, fortran: make kfail gfortran specific

 gdb/testsuite/gdb.fortran/array-slices-bad.exp    |  5 ++++-
 gdb/testsuite/gdb.fortran/function-calls.exp      |  4 +++-
 gdb/testsuite/gdb.fortran/library-module-lib.f90  |  2 +-
 gdb/testsuite/gdb.fortran/library-module-main.f90 |  2 +-
 gdb/testsuite/gdb.fortran/mixed-lang-stack.exp    |  9 ++++++++-
 gdb/testsuite/gdb.fortran/module.f90              | 11 ++++++-----
 gdb/testsuite/gdb.fortran/vla-type.exp            |  5 +++--
 7 files changed, 26 insertions(+), 12 deletions(-)

--
2.25.1

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2022-07-05 13:01 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-04 10:29 [PING 2] [PATCH 0/4] Adapt Fortran testsuite for ifort Kempke, Nils-Christian
2022-07-04 13:54 ` Enze Li
2022-07-04 14:03   ` Kempke, Nils-Christian
2022-07-04 14:43     ` Kempke, Nils-Christian
2022-07-04 14:49       ` Bruno Larsen
2022-07-04 16:09         ` Kempke, Nils-Christian
2022-07-05 13:01           ` Enze Li
  -- strict thread matches above, loose matches on Subject: below --
2022-06-10 15:44 Nils-Christian Kempke
2022-07-04 15:59 ` [PING 2][PATCH " Kempke, Nils-Christian

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).