From: Enze Li <enze.li@hotmail.com>
To: gdb-patches@sourceware.org
Cc: enze.li@gmx.com
Subject: [PING] [PATCH] gdb: initialize the data_head variable to eliminate compilation warnings
Date: Wed, 06 Jul 2022 21:53:29 +0800 [thread overview]
Message-ID: <OS3P286MB2152EF4E796B72F866DE34AFF0809@OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <OS3P286MB215287D0A1891AB7BCDE67FDF0A99@OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM>
Hi all,
Kindly PING for this tiny patch. The warning mentioned in this patch
still exists in the trunk. Does it make sense?
Best Regards,
Enze
On Sat, 2022-06-11 at 18:36 +0800, Enze Li via Gdb-patches wrote:
> On a machine with gcc 12, I get this warning:
>
> CXX nat/linux-btrace.o
> In function ‘btrace_error linux_read_bts(btrace_data_bts*,
> btrace_target_info*, btrace_read_type)’,
> inlined from ‘btrace_error linux_read_btrace(btrace_data*,
> btrace_target_info*, btrace_read_type)’ at ../gdb/nat/linux-
> btrace.c:935:29:
> ../gdb/nat/linux-btrace.c:865:21: warning: ‘data_head’ may be used
> uninitialized [-Wmaybe-uninitialized]
> 865 | pevent->last_head = data_head;
> | ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~
> ../gdb/nat/linux-btrace.c: In function ‘btrace_error
> linux_read_btrace(btrace_data*, btrace_target_info*,
> btrace_read_type)’:
> ../gdb/nat/linux-btrace.c:792:9: note: ‘data_head’ was declared here
> 792 | __u64 data_head, data_tail;
> | ^~~~~~~~~
>
> Fix this by initializing the 'data_head' variable.
>
> Tested by rebuilding on x86_64 openSUSE Tumbleweed with gcc 12.
> ---
> gdb/nat/linux-btrace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gdb/nat/linux-btrace.c b/gdb/nat/linux-btrace.c
> index b0d6dcd7cf1..c31fb5ffe43 100644
> --- a/gdb/nat/linux-btrace.c
> +++ b/gdb/nat/linux-btrace.c
> @@ -789,7 +789,7 @@ linux_read_bts (struct btrace_data_bts *btrace,
> struct perf_event_buffer *pevent;
> const uint8_t *begin, *end, *start;
> size_t buffer_size, size;
> - __u64 data_head, data_tail;
> + __u64 data_head = 0, data_tail;
> unsigned int retries = 5;
>
> pevent = &tinfo->variant.bts.bts;
next prev parent reply other threads:[~2022-07-06 13:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-11 10:36 Enze Li
2022-07-06 13:53 ` Enze Li [this message]
2022-07-06 14:02 ` [PING] " Metzger, Markus T
2022-07-08 13:47 ` Enze Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OS3P286MB2152EF4E796B72F866DE34AFF0809@OS3P286MB2152.JPNP286.PROD.OUTLOOK.COM \
--to=enze.li@hotmail.com \
--cc=enze.li@gmx.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).