RE: [PATCH v5 1/1] gdb, infcmd: Support jump command with same line in multiple symtabs

["Puputti, Matti" <matti.puputti@intel.com>]

Hi Andrew,

Thank you for the review.
Please note that the Patch 5 makes one more change in the code, by  changing the error message ("Unreasonable jump request" -> "Jump request is ambiguous: does not resolve to a single address").

If you are ok with the new error message, and since Eli seems to be ok with the documentation, I think we are ready to push.
I don't yet have rights to push.
Can you please push this commit for me?

Br,
Matti Puputti 

> -----Original Message-----
> From: Eli Zaretskii <eliz@gnu.org>
> Sent: Friday, May 12, 2023 4:38 PM
> To: Puputti, Matti <matti.puputti@intel.com>
> Cc: gdb-patches@sourceware.org; aburgess@redhat.com
> Subject: Re: [PATCH v5 1/1] gdb, infcmd: Support jump command with same
> line in multiple symtabs
> 
> > From: Matti Puputti <matti.puputti@intel.com>
> > Cc: eliz@gnu.org,
> > 	aburgess@redhat.com
> > Date: Fri, 12 May 2023 15:33:20 +0200
> >
> > If a header file defining a static function is included in multiple source
> > files, each calling the function, and GDB is asked to jump to a line inside
> > that function, there would be multiple locations matching the target.  The
> > solution in this commit is to select the location in the current symtab.
> > ---
> >  gdb/doc/gdb.texinfo                           |  4 +-
> >  gdb/infcmd.c                                  | 14 ++++-
> >  .../gdb.base/jump_multiple_objfiles-foo.c     | 24 +++++++++
> >  .../gdb.base/jump_multiple_objfiles.c         | 30 +++++++++++
> >  .../gdb.base/jump_multiple_objfiles.exp       | 54 +++++++++++++++++++
> >  .../gdb.base/jump_multiple_objfiles.h         | 30 +++++++++++
> >  6 files changed, 154 insertions(+), 2 deletions(-)
> >  create mode 100755 gdb/testsuite/gdb.base/jump_multiple_objfiles-foo.c
> >  create mode 100755 gdb/testsuite/gdb.base/jump_multiple_objfiles.c
> >  create mode 100755 gdb/testsuite/gdb.base/jump_multiple_objfiles.exp
> >  create mode 100755 gdb/testsuite/gdb.base/jump_multiple_objfiles.h
> 
> Thanks, the documentation part of this is OK.
> 
> Reviewed-By: Eli Zaretskii <eliz@gnu.org>
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva  
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928