From: Eli Zaretskii <eliz@gnu.org>
To: Matti Puputti <matti.puputti@intel.com>
Cc: gdb-patches@sourceware.org, aburgess@redhat.com
Subject: Re: [PATCH v5 1/1] gdb, infcmd: Support jump command with same line in multiple symtabs
Date: Fri, 12 May 2023 17:38:28 +0300 [thread overview]
Message-ID: <83y1ltbonv.fsf@gnu.org> (raw)
In-Reply-To: <20230512133320.1236624-2-matti.puputti@intel.com> (message from Matti Puputti on Fri, 12 May 2023 15:33:20 +0200)
> From: Matti Puputti <matti.puputti@intel.com>
> Cc: eliz@gnu.org,
> aburgess@redhat.com
> Date: Fri, 12 May 2023 15:33:20 +0200
>
> If a header file defining a static function is included in multiple source
> files, each calling the function, and GDB is asked to jump to a line inside
> that function, there would be multiple locations matching the target. The
> solution in this commit is to select the location in the current symtab.
> ---
> gdb/doc/gdb.texinfo | 4 +-
> gdb/infcmd.c | 14 ++++-
> .../gdb.base/jump_multiple_objfiles-foo.c | 24 +++++++++
> .../gdb.base/jump_multiple_objfiles.c | 30 +++++++++++
> .../gdb.base/jump_multiple_objfiles.exp | 54 +++++++++++++++++++
> .../gdb.base/jump_multiple_objfiles.h | 30 +++++++++++
> 6 files changed, 154 insertions(+), 2 deletions(-)
> create mode 100755 gdb/testsuite/gdb.base/jump_multiple_objfiles-foo.c
> create mode 100755 gdb/testsuite/gdb.base/jump_multiple_objfiles.c
> create mode 100755 gdb/testsuite/gdb.base/jump_multiple_objfiles.exp
> create mode 100755 gdb/testsuite/gdb.base/jump_multiple_objfiles.h
Thanks, the documentation part of this is OK.
Reviewed-By: Eli Zaretskii <eliz@gnu.org>
next prev parent reply other threads:[~2023-05-12 14:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-12 13:33 [PATCH v5 0/1] " Matti Puputti
2023-05-12 13:33 ` [PATCH v5 1/1] " Matti Puputti
2023-05-12 14:38 ` Eli Zaretskii [this message]
2023-05-15 8:19 ` Puputti, Matti
2023-05-22 8:01 ` [PING][PATCH " Puputti, Matti
2023-05-24 12:51 ` Andrew Burgess
2023-05-24 16:03 ` Andrew Burgess
2023-05-25 5:38 ` Puputti, Matti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83y1ltbonv.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=matti.puputti@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).