* [RFA] src-release.sh: Fix gdb source tarball build failure due to libsframe
@ 2022-11-27 12:53 Joel Brobecker
2022-11-28 14:44 ` Tom Tromey
0 siblings, 1 reply; 3+ messages in thread
From: Joel Brobecker @ 2022-11-27 12:53 UTC (permalink / raw)
To: binutils, gdb-patches; +Cc: Indu Bhagat, gcc-patches, Joel Brobecker
Hello,
This script was recently changed as follow:
| commit e619dddb3a45780ae66d762756882a3b896b617d
| Date: Tue Nov 15 15:07:13 2022 -0800
| Subject: src-release.sh: Add libsframe
|
| Add libsframe to the list of top level directories that will be included
| in a release.
Since then, the gdb source tarball has been failing with the error
below during the "make configure-host configure-target" phase:
| make[3]: *** No rule to make target '../libsframe/libsframe.la',
| needed by 'libbfd.la'. Stop.
| make[3]: Leaving directory '/tmp/gdb-public/bfd'
This patch fixes the issue by adding libsframe to the list of
GDB_SUPPORT_DIRS, similar to what was done for BINUTILS.
ChangeLog:
* src-release.sh (GDB_SUPPORT_DIRS): Add libsframe.
Ok to apply to master?
NB: Once approved, I will take care of applying the patch to both
binutils-gdb and gcc (hence the Cc: of gcc-patches).
Thank you,
---
src-release.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src-release.sh b/src-release.sh
index 050a8eb958d..ec28f8691c7 100755
--- a/src-release.sh
+++ b/src-release.sh
@@ -322,7 +322,7 @@ gas_release()
tar_compress $package $tool "$GAS_SUPPORT_DIRS" "$compressors"
}
-GDB_SUPPORT_DIRS="bfd include libiberty libctf opcodes readline sim intl libdecnumber cpu zlib contrib gnulib gdbsupport gdbserver libbacktrace"
+GDB_SUPPORT_DIRS="libsframe bfd include libiberty libctf opcodes readline sim intl libdecnumber cpu zlib contrib gnulib gdbsupport gdbserver libbacktrace"
gdb_release()
{
compressors=$1
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFA] src-release.sh: Fix gdb source tarball build failure due to libsframe
2022-11-27 12:53 [RFA] src-release.sh: Fix gdb source tarball build failure due to libsframe Joel Brobecker
@ 2022-11-28 14:44 ` Tom Tromey
2022-11-30 3:37 ` Joel Brobecker
0 siblings, 1 reply; 3+ messages in thread
From: Tom Tromey @ 2022-11-28 14:44 UTC (permalink / raw)
To: Joel Brobecker via Gdb-patches
Cc: binutils, Joel Brobecker, Indu Bhagat, gcc-patches
>>>>> "Joel" == Joel Brobecker via Gdb-patches <gdb-patches@sourceware.org> writes:
Joel> ChangeLog:
Joel> * src-release.sh (GDB_SUPPORT_DIRS): Add libsframe.
Joel> Ok to apply to master?
Looks good to me.
I think we recently agreed that gdb and binutils maintainers can approve
patches like this... ?
thanks,
Tom
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFA] src-release.sh: Fix gdb source tarball build failure due to libsframe
2022-11-28 14:44 ` Tom Tromey
@ 2022-11-30 3:37 ` Joel Brobecker
0 siblings, 0 replies; 3+ messages in thread
From: Joel Brobecker @ 2022-11-30 3:37 UTC (permalink / raw)
To: Tom Tromey
Cc: Joel Brobecker via Gdb-patches, binutils, Joel Brobecker,
Indu Bhagat, gcc-patches
> >>>>> "Joel" == Joel Brobecker via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Joel> ChangeLog:
>
> Joel> * src-release.sh (GDB_SUPPORT_DIRS): Add libsframe.
>
> Joel> Ok to apply to master?
>
> Looks good to me.
> I think we recently agreed that gdb and binutils maintainers can approve
> patches like this... ?
Thanks Tom. Pushed to master.
FTR, I thought this script was also part of the GCC repository,
but discovered that this is not the case when I tried to apply
the same patch there.
--
Joel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-30 3:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-27 12:53 [RFA] src-release.sh: Fix gdb source tarball build failure due to libsframe Joel Brobecker
2022-11-28 14:44 ` Tom Tromey
2022-11-30 3:37 ` Joel Brobecker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).