From: Joel Brobecker <brobecker@adacore.com>
To: Simon Marchi <simark@simark.ca>
Cc: Joel Brobecker <brobecker@adacore.com>, gdb-patches@sourceware.org
Subject: Re: FYI: Updating Copyright Year ranges for GDB to add year 2023
Date: Fri, 6 Jan 2023 06:59:42 +0400 [thread overview]
Message-ID: <Y7eOniVXYtjrSH2F@adacore.com> (raw)
In-Reply-To: <ef0fb5c9-dadd-3c9e-b49b-b4ee4598c5a0@simark.ca>
> This file was missed:
>
> diff --git a/gdbsupport/Makefile.in b/gdbsupport/Makefile.in
> index 6aadae410316..c4b43c99c3d7 100644
> --- a/gdbsupport/Makefile.in
> +++ b/gdbsupport/Makefile.in
> @@ -15,7 +15,7 @@
> @SET_MAKE@
>
> #
> -# Copyright (C) 2020-2022 Free Software Foundation, Inc.
> +# Copyright (C) 2020-2023 Free Software Foundation, Inc.
> #
> # This file is free software; you can redistribute it and/or modify
> # it under the terms of the GNU General Public License as published by
Thanks for catching that.
I took a look and the reason this file wasn't adjusted is because
it is in the EXCLUDE_LIST:
# Files which should not be modified, either because they are
# generated, non-FSF, or otherwise special (e.g. license text,
# or test cases which must be sensitive to line numbering).
EXCLUDE_LIST = (
[..]
"gdbsupport/Makefile.in",
[..]
)
In this case, the reason is that this file is generated, and
the commit message of the commit that added it says that mods
we make will be undone by the next regen.
I looked a little deeper, and I think the reason why an auto-update
doesn't work is that the file has two copyright notices, one after
the other, and the script is written to stop after the first one found.
In this case, if we wanted to be absolutely thorough, I think the way
to deal with this situation would be to regenerate it. In my opinion,
I think this is more work than it's worth. Regenerating those files
has always been a bit of a pain, and I think it's fine to leave that
file as it is until the next time it gets re-gen'ed.
--
Joel
prev parent reply other threads:[~2023-01-06 2:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-01 12:57 Joel Brobecker
2023-01-01 12:57 ` [PATCH 1/4] Update copyright year in help message of gdb, gdbserver, gdbreplay Joel Brobecker
2023-01-01 12:57 ` [PATCH 2/4] gdb/copyright.py: Adjust following rename of sim/ppc/ppc-instructions Joel Brobecker
2023-01-01 12:57 ` [PATCH 3/4] Update copyright year range in header of all files managed by GDB Joel Brobecker
2023-01-01 13:04 ` Joel Brobecker
2023-01-01 12:57 ` [PATCH 4/4] manual copyright year range of various GDB files to add 2023 Joel Brobecker
2023-01-01 13:17 ` FYI: Updating Copyright Year ranges for GDB to add year 2023 Joel Brobecker
2023-01-04 16:06 ` Simon Marchi
2023-01-06 2:59 ` Joel Brobecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y7eOniVXYtjrSH2F@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).