From: Mike Frysinger <vapier@gentoo.org>
To: Mark Wielaard <mark@klomp.org>
Cc: gdb-patches@sourceware.org, Sam James <sam@gentoo.org>
Subject: Re: [PATCH] sim: mn10300: minimize mn10300-sim.h include in sim-main.h
Date: Sun, 15 Jan 2023 16:47:44 -0500 [thread overview]
Message-ID: <Y8R0gOVkwQ2Mqqb2@vapier> (raw)
In-Reply-To: <20230115202009.149626-1-mark@klomp.org>
[-- Attachment #1: Type: text/plain, Size: 660 bytes --]
On 15 Jan 2023 21:20, Mark Wielaard wrote:
> --- a/sim/mn10300/sim-main.h
> +++ b/sim/mn10300/sim-main.h
> @@ -38,7 +38,14 @@ mn10300_core_signal ((SD), (CPU), (CIA), (MAP), (NR_BYTES), (ADDR), (TRANSFER),
> #include "sim-fpu.h"
> #include "sim-signal.h"
>
> +/* These datastructures and defines are only used by the igen generated
> + support.c, semantics.c, idecode.c and engine.c files. */
> +#if defined(SUPPORT_C) \
> + || defined(SEMANTICS_C) \
> + || defined(IDECODE_C) \
> + || defined(ENGINE_C)
> #include "mn10300-sim.h"
> +#endif
a nifty hack. can you move the sim-fpu.h & sim-signal.h inside this block ?
-mike
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-01-15 21:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-15 20:20 Mark Wielaard
2023-01-15 21:47 ` Mike Frysinger [this message]
2023-01-18 21:53 ` Mark Wielaard
2023-01-19 0:01 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8R0gOVkwQ2Mqqb2@vapier \
--to=vapier@gentoo.org \
--cc=gdb-patches@sourceware.org \
--cc=mark@klomp.org \
--cc=sam@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).