From: Joel Brobecker <brobecker@adacore.com>
To: Luis Machado <luis.machado@arm.com>
Cc: Simon Marchi <simon.marchi@polymtl.ca>,
Joel Brobecker <brobecker@adacore.com>,
Torbjorn SVENSSON <torbjorn.svensson@foss.st.com>,
tom@tromey.com, gdb-patches@sourceware.org
Subject: Re: GDB 13 release -- 2023-01-21 Update
Date: Sun, 29 Jan 2023 15:52:49 +0400 [thread overview]
Message-ID: <Y9ZeEbLCmKJ7iQAq@adacore.com> (raw)
In-Reply-To: <e334c3b2-d006-1061-3775-d378fddd1f3f@arm.com>
> > > > - With that said, the patch appears to simply add a cache,
> > > > so the logic of it all doesn't appear to be extremely
> > > > complicated. So I would rate the risk to be low.
> > >
> > > That's what it seems to me.
> > >
> > > I think another round of testing would be a good step to make sure there are no hidden bugs.
> > My understanding is that the problem was making debugging borderline
> > impossible. Or at least, really, really unpleasant. So I think it
> > qualifies as a bug fix, and that the benefit is worth the risk.
>
> Right. Past a short number of frames, unwinding got really really slow.
The part that I haven't been clear on is whether this affected everyone
on Arm-32bit, or everyone on both Arm and AArch64, or just a subset
of the users?
Regardless of the above, I agree we can backport. To avoid confusion,
can I leave this to you, Luis, to confirm that the two patches I identified
previously are the only two patches that need to be backported, and
can you backport those for us, with a round of testing if you haven't
done so already, just to double-check?
For the record, those patches were:
commit d72ba177c85f2ad18d0dcabdd8844532c9acb819
Author: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com>
Date: Thu Nov 17 12:17:53 2022 +0100
Subject: gdb: dwarf2 generic implementation for caching function data
... and ...
commit 5cf11483141a58314834653003e49709b47822d5
Author: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com>
Date: Thu Nov 17 12:18:20 2022 +0100
Subject: gdb/arm: Use new dwarf2 function cache
Thank you!
--
Joel
next prev parent reply other threads:[~2023-01-30 5:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-21 6:08 Joel Brobecker
2023-01-25 20:18 ` Torbjorn SVENSSON
2023-01-27 6:30 ` Joel Brobecker
2023-01-27 6:38 ` Luis Machado
2023-01-27 17:17 ` Simon Marchi
2023-01-28 8:39 ` Luis Machado
2023-01-29 11:52 ` Joel Brobecker [this message]
2023-01-30 11:23 ` Luis Machado
2023-01-31 7:03 ` Joel Brobecker
2023-01-31 13:57 ` Luis Machado
2023-01-31 14:33 ` Luis Machado
2023-02-02 3:44 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9ZeEbLCmKJ7iQAq@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=luis.machado@arm.com \
--cc=simon.marchi@polymtl.ca \
--cc=tom@tromey.com \
--cc=torbjorn.svensson@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).