* [PATCH] sim/erc32: fix signedness compatiblity and redefinition warnings
@ 2021-10-27 6:27 Orgad Shaneh
2021-10-27 9:37 ` Mike Frysinger
2021-10-28 7:55 ` Orgad Shaneh
0 siblings, 2 replies; 5+ messages in thread
From: Orgad Shaneh @ 2021-10-27 6:27 UTC (permalink / raw)
To: gdb-patches; +Cc: Orgad Shaneh
---
sim/erc32/func.c | 15 +++++++++------
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/sim/erc32/func.c b/sim/erc32/func.c
index ff53f3bca51..9296831bcd9 100644
--- a/sim/erc32/func.c
+++ b/sim/erc32/func.c
@@ -31,6 +31,7 @@
#include <sys/time.h>
#define VAL(x) strtoul(x,(char **)NULL,0)
+void boot_init (void);
struct disassemble_info dinfo;
struct pstate sregs;
@@ -747,7 +748,7 @@ static void print_insn_sparc_sis(uint32 addr, struct disassemble_info *info)
{
unsigned char i[4];
- sis_memory_read(addr, i, 4);
+ sis_memory_read(addr, (char *)i, 4);
dinfo.buffer_vma = addr;
dinfo.buffer_length = 4;
dinfo.buffer = i;
@@ -779,7 +780,7 @@ disp_mem(uint32 addr, uint32 len)
uint32 i;
union {
- unsigned char u8[4];
+ char b8[4];
uint32 u32;
} data;
uint32 mem[4], j;
@@ -788,7 +789,7 @@ disp_mem(uint32 addr, uint32 len)
for (i = addr & ~3; i < ((addr + len) & ~3); i += 16) {
printf("\n %8X ", i);
for (j = 0; j < 4; j++) {
- sis_memory_read ((i + (j * 4)), data.u8, 4);
+ sis_memory_read ((i + (j * 4)), data.b8, 4);
printf ("%08x ", data.u32);
mem[j] = data.u32;
}
@@ -809,12 +810,12 @@ dis_mem(uint32 addr, uint32 len, struct disassemble_info *info)
{
uint32 i;
union {
- unsigned char u8[4];
+ char b8[4];
uint32 u32;
} data;
for (i = addr & -3; i < ((addr & -3) + (len << 2)); i += 4) {
- sis_memory_read (i, data.u8, 4);
+ sis_memory_read (i, data.b8, 4);
printf (" %08x %08x ", i, data.u32);
print_insn_sparc_sis(i, info);
if (i >= 0xfffffffc) break;
@@ -996,7 +997,9 @@ sys_halt(void)
#include "libiberty.h"
#include "bfd.h"
+#ifndef min
#define min(A, B) (((A) < (B)) ? (A) : (B))
+#endif
#define LOAD_ADDRESS 0
int
@@ -1068,7 +1071,7 @@ bfd_load (const char *fname)
fptr = 0;
while (section_size > 0) {
- char buffer[1024];
+ unsigned char buffer[1024];
int count;
count = min(section_size, 1024);
--
2.33.1.windows.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] sim/erc32: fix signedness compatiblity and redefinition warnings
2021-10-27 6:27 [PATCH] sim/erc32: fix signedness compatiblity and redefinition warnings Orgad Shaneh
@ 2021-10-27 9:37 ` Mike Frysinger
2021-10-28 7:55 ` Orgad Shaneh
1 sibling, 0 replies; 5+ messages in thread
From: Mike Frysinger @ 2021-10-27 9:37 UTC (permalink / raw)
To: Orgad Shaneh; +Cc: gdb-patches
[-- Attachment #1: Type: text/plain, Size: 498 bytes --]
On 27 Oct 2021 06:27, Orgad Shaneh via Gdb-patches wrote:
> --- a/sim/erc32/func.c
> +++ b/sim/erc32/func.c
>
> +void boot_init (void);
this should be in sis.h instead so it's shared between users & definition
> unsigned char i[4];
>
> - sis_memory_read(addr, i, 4);
> + sis_memory_read(addr, (char *)i, 4);
we should change sis_memory_read to take a void* buffer instead. then we never
have to worry about or fight signed warnings like this again.
-mike
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] sim/erc32: fix signedness compatiblity and redefinition warnings
@ 2021-10-28 7:55 ` Orgad Shaneh
2021-10-29 5:31 ` Mike Frysinger
0 siblings, 1 reply; 5+ messages in thread
From: Orgad Shaneh @ 2021-10-28 7:55 UTC (permalink / raw)
To: gdb-patches; +Cc: Orgad Shaneh
---
sim/erc32/erc32.c | 25 ++++++++++++-------------
sim/erc32/exec.c | 14 +++++++-------
sim/erc32/func.c | 4 +++-
sim/erc32/sis.h | 11 ++++++-----
4 files changed, 28 insertions(+), 26 deletions(-)
diff --git a/sim/erc32/erc32.c b/sim/erc32/erc32.c
index e7a816f86bf..3bd2df857a7 100644
--- a/sim/erc32/erc32.c
+++ b/sim/erc32/erc32.c
@@ -292,8 +292,7 @@ static uint32 gpt_counter_read (void);
static void gpt_scaler_set (uint32 val);
static void gpt_reload_set (uint32 val);
static void timer_ctrl (uint32 val);
-static unsigned char *
- get_mem_ptr (uint32 addr, uint32 size);
+static void * get_mem_ptr (uint32 addr, uint32 size);
static void store_bytes (unsigned char *mem, uint32 waddr,
uint32 *data, int sz, int32 *ws);
@@ -1541,7 +1540,7 @@ store_bytes (unsigned char *mem, uint32 waddr, uint32 *data, int32 sz,
/* Memory emulation */
int
-memory_iread (uint32 addr, uint32 *data, int32 *ws)
+memory_iread (uint32 addr, uint32 *data, uint32 *ws)
{
uint32 asi;
if ((addr >= mem_ramstart) && (addr < (mem_ramstart + mem_ramsz))) {
@@ -1566,7 +1565,7 @@ memory_iread (uint32 addr, uint32 *data, int32 *ws)
}
int
-memory_read(int32 asi, uint32 addr, uint32 *data, int32 sz, int32 *ws)
+memory_read(int32 asi, uint32 addr, void *data, int32 sz, int32 *ws)
{
int32 mexc;
@@ -1587,7 +1586,7 @@ memory_read(int32 asi, uint32 addr, uint32 *data, int32 sz, int32 *ws)
*ws = mem_ramr_ws;
return 0;
} else if ((addr >= MEC_START) && (addr < MEC_END)) {
- mexc = mec_read(addr, asi, data);
+ mexc = mec_read(addr, asi, (uint32 *)data);
if (mexc) {
set_sfsr(MEC_ACC, addr, asi, 1);
*ws = MEM_EX_WS;
@@ -1607,7 +1606,7 @@ memory_read(int32 asi, uint32 addr, uint32 *data, int32 sz, int32 *ws)
} else if ((addr >= 0x10000000) &&
(addr < (0x10000000 + (512 << (mec_iocr & 0x0f)))) &&
(mec_iocr & 0x10)) {
- *data = erareg;
+ *(uint32 *)data = erareg;
return 0;
}
@@ -1739,7 +1738,7 @@ memory_write(int32 asi, uint32 addr, uint32 *data, int32 sz, int32 *ws)
return 1;
}
-static unsigned char *
+static void *
get_mem_ptr(uint32 addr, uint32 size)
{
if ((addr + size) < ROM_SZ) {
@@ -1755,15 +1754,15 @@ get_mem_ptr(uint32 addr, uint32 size)
}
#endif
- return (char *) -1;
+ return (void *) -1;
}
int
-sis_memory_write(uint32 addr, const unsigned char *data, uint32 length)
+sis_memory_write(uint32 addr, const void *data, uint32 length)
{
- char *mem;
+ void *mem;
- if ((mem = get_mem_ptr(addr, length)) == ((char *) -1))
+ if ((mem = get_mem_ptr(addr, length)) == ((void *) -1))
return 0;
memcpy(mem, data, length);
@@ -1771,11 +1770,11 @@ sis_memory_write(uint32 addr, const unsigned char *data, uint32 length)
}
int
-sis_memory_read(uint32 addr, char *data, uint32 length)
+sis_memory_read(uint32 addr, void *data, uint32 length)
{
char *mem;
- if ((mem = get_mem_ptr(addr, length)) == ((char *) -1))
+ if ((mem = get_mem_ptr(addr, length)) == ((void *) -1))
return 0;
memcpy(data, mem, length);
diff --git a/sim/erc32/exec.c b/sim/erc32/exec.c
index d8a8c6c662b..1858813f000 100644
--- a/sim/erc32/exec.c
+++ b/sim/erc32/exec.c
@@ -395,11 +395,11 @@ dispatch_instruction(struct pstate *sregs)
uint32 cwp, op, op2, op3, asi, rd, cond, rs1,
rs2;
- uint32 ldep, icc;
- int32 operand1, operand2, *rdd, result, eicc,
+ uint32 ldep, icc, data, *rdd;
+ int32 operand1, operand2, result, eicc,
new_cwp;
- int32 pc, npc, data, address, ws, mexc, fcc;
- int32 ddata[2];
+ int32 pc, npc, address, ws, mexc, fcc;
+ uint32 ddata[2];
sregs->ninst++;
cwp = ((sregs->psr & PSR_CWP) << 4);
@@ -1096,7 +1096,7 @@ dispatch_instruction(struct pstate *sregs)
break;
}
sregs->psr = (sregs->psr & 0xff000000) |
- (rs1 ^ operand2) & 0x00f03fff;
+ ((rs1 ^ operand2) & 0x00f03fff);
break;
case WRWIM:
if (!(sregs->psr & PSR_S)) {
@@ -1528,7 +1528,7 @@ dispatch_instruction(struct pstate *sregs)
if (sregs->frd == rd)
sregs->fhold += (sregs->ftime - ebase.simtime);
}
- mexc = memory_write(asi, address, &sregs->fsi[rd], 2, &ws);
+ mexc = memory_write(asi, address, (uint32 *)&sregs->fsi[rd], 2, &ws);
sregs->hold += ws;
if (mexc) {
sregs->trap = TRAP_DEXC;
@@ -1548,7 +1548,7 @@ dispatch_instruction(struct pstate *sregs)
if ((sregs->frd == rd) || (sregs->frd + 1 == rd))
sregs->fhold += (sregs->ftime - ebase.simtime);
}
- mexc = memory_write(asi, address, &sregs->fsi[rd], 3, &ws);
+ mexc = memory_write(asi, address, (uint32 *)&sregs->fsi[rd], 3, &ws);
sregs->hold += ws;
sregs->icnt = T_STD;
#ifdef STAT
diff --git a/sim/erc32/func.c b/sim/erc32/func.c
index ff53f3bca51..d168a31b2cd 100644
--- a/sim/erc32/func.c
+++ b/sim/erc32/func.c
@@ -139,7 +139,7 @@ set_regi(struct pstate *sregs, int32 reg, uint32 rval)
}
void
-get_regi(struct pstate * sregs, int32 reg, char *buf)
+get_regi(struct pstate * sregs, int32 reg, unsigned char *buf)
{
uint32 cwp;
uint32 rval = 0;
@@ -996,7 +996,9 @@ sys_halt(void)
#include "libiberty.h"
#include "bfd.h"
+#ifndef min
#define min(A, B) (((A) < (B)) ? (A) : (B))
+#endif
#define LOAD_ADDRESS 0
int
diff --git a/sim/erc32/sis.h b/sim/erc32/sis.h
index 7f787cf1433..98cb9ccc33d 100644
--- a/sim/erc32/sis.h
+++ b/sim/erc32/sis.h
@@ -164,21 +164,22 @@ extern void sim_halt (void);
extern void exit_sim (void);
extern void init_stdio (void);
extern void restore_stdio (void);
-extern int memory_iread (uint32 addr, uint32 *data, int32 *ws);
-extern int memory_read (int32 asi, uint32 addr, uint32 *data,
+extern int memory_iread (uint32 addr, uint32 *data, uint32 *ws);
+extern int memory_read (int32 asi, uint32 addr, void *data,
int32 sz, int32 *ws);
extern int memory_write (int32 asi, uint32 addr, uint32 *data,
int32 sz, int32 *ws);
extern int sis_memory_write (uint32 addr,
- const unsigned char *data, uint32 length);
-extern int sis_memory_read (uint32 addr, char *data,
+ const void *data, uint32 length);
+extern int sis_memory_read (uint32 addr, void *data,
uint32 length);
+extern void boot_init (void);
/* func.c */
extern struct pstate sregs;
extern void set_regi (struct pstate *sregs, int32 reg,
uint32 rval);
-extern void get_regi (struct pstate *sregs, int32 reg, char *buf);
+extern void get_regi (struct pstate *sregs, int32 reg, unsigned char *buf);
extern int exec_cmd (struct pstate *sregs, const char *cmd);
extern void reset_stat (struct pstate *sregs);
extern void show_stat (struct pstate *sregs);
--
2.33.1.windows.1.1.g7e610705a5
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] sim/erc32: fix signedness compatiblity and redefinition warnings
2021-10-28 7:55 ` Orgad Shaneh
@ 2021-10-29 5:31 ` Mike Frysinger
0 siblings, 0 replies; 5+ messages in thread
From: Mike Frysinger @ 2021-10-29 5:31 UTC (permalink / raw)
To: Orgad Shaneh; +Cc: gdb-patches
[-- Attachment #1: Type: text/plain, Size: 797 bytes --]
On 28 Oct 2021 07:55, Orgad Shaneh via Gdb-patches wrote:
most of the patch looks fine enough
> @@ -1587,7 +1586,7 @@ memory_read(int32 asi, uint32 addr, uint32 *data, int32 sz, int32 *ws)
> *ws = mem_ramr_ws;
> return 0;
> } else if ((addr >= MEC_START) && (addr < MEC_END)) {
> - mexc = mec_read(addr, asi, data);
> + mexc = mec_read(addr, asi, (uint32 *)data);
data is a void pointer, so you shouldn't need this cast in C
> @@ -1607,7 +1606,7 @@ memory_read(int32 asi, uint32 addr, uint32 *data, int32 sz, int32 *ws)
> } else if ((addr >= 0x10000000) &&
> (addr < (0x10000000 + (512 << (mec_iocr & 0x0f)))) &&
> (mec_iocr & 0x10)) {
> - *data = erareg;
> + *(uint32 *)data = erareg;
probably would be better to use memcpy on it
-mike
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] sim/erc32: fix signedness compatiblity and redefinition warnings
@ 2021-10-29 6:42 Orgad Shaneh
0 siblings, 0 replies; 5+ messages in thread
From: Orgad Shaneh @ 2021-10-29 6:42 UTC (permalink / raw)
To: gdb-patches; +Cc: Orgad Shaneh
---
sim/erc32/erc32.c | 23 +++++++++++------------
sim/erc32/exec.c | 14 +++++++-------
sim/erc32/func.c | 4 +++-
sim/erc32/sis.h | 11 ++++++-----
4 files changed, 27 insertions(+), 25 deletions(-)
diff --git a/sim/erc32/erc32.c b/sim/erc32/erc32.c
index e7a816f86bf..1dc95c4d638 100644
--- a/sim/erc32/erc32.c
+++ b/sim/erc32/erc32.c
@@ -292,8 +292,7 @@ static uint32 gpt_counter_read (void);
static void gpt_scaler_set (uint32 val);
static void gpt_reload_set (uint32 val);
static void timer_ctrl (uint32 val);
-static unsigned char *
- get_mem_ptr (uint32 addr, uint32 size);
+static void * get_mem_ptr (uint32 addr, uint32 size);
static void store_bytes (unsigned char *mem, uint32 waddr,
uint32 *data, int sz, int32 *ws);
@@ -1541,7 +1540,7 @@ store_bytes (unsigned char *mem, uint32 waddr, uint32 *data, int32 sz,
/* Memory emulation */
int
-memory_iread (uint32 addr, uint32 *data, int32 *ws)
+memory_iread (uint32 addr, uint32 *data, uint32 *ws)
{
uint32 asi;
if ((addr >= mem_ramstart) && (addr < (mem_ramstart + mem_ramsz))) {
@@ -1566,7 +1565,7 @@ memory_iread (uint32 addr, uint32 *data, int32 *ws)
}
int
-memory_read(int32 asi, uint32 addr, uint32 *data, int32 sz, int32 *ws)
+memory_read(int32 asi, uint32 addr, void *data, int32 sz, int32 *ws)
{
int32 mexc;
@@ -1607,7 +1606,7 @@ memory_read(int32 asi, uint32 addr, uint32 *data, int32 sz, int32 *ws)
} else if ((addr >= 0x10000000) &&
(addr < (0x10000000 + (512 << (mec_iocr & 0x0f)))) &&
(mec_iocr & 0x10)) {
- *data = erareg;
+ memcpy (data, &erareg, 4);;
return 0;
}
@@ -1739,7 +1738,7 @@ memory_write(int32 asi, uint32 addr, uint32 *data, int32 sz, int32 *ws)
return 1;
}
-static unsigned char *
+static void *
get_mem_ptr(uint32 addr, uint32 size)
{
if ((addr + size) < ROM_SZ) {
@@ -1755,15 +1754,15 @@ get_mem_ptr(uint32 addr, uint32 size)
}
#endif
- return (char *) -1;
+ return (void *) -1;
}
int
-sis_memory_write(uint32 addr, const unsigned char *data, uint32 length)
+sis_memory_write(uint32 addr, const void *data, uint32 length)
{
- char *mem;
+ void *mem;
- if ((mem = get_mem_ptr(addr, length)) == ((char *) -1))
+ if ((mem = get_mem_ptr(addr, length)) == ((void *) -1))
return 0;
memcpy(mem, data, length);
@@ -1771,11 +1770,11 @@ sis_memory_write(uint32 addr, const unsigned char *data, uint32 length)
}
int
-sis_memory_read(uint32 addr, char *data, uint32 length)
+sis_memory_read(uint32 addr, void *data, uint32 length)
{
char *mem;
- if ((mem = get_mem_ptr(addr, length)) == ((char *) -1))
+ if ((mem = get_mem_ptr(addr, length)) == ((void *) -1))
return 0;
memcpy(data, mem, length);
diff --git a/sim/erc32/exec.c b/sim/erc32/exec.c
index d8a8c6c662b..1858813f000 100644
--- a/sim/erc32/exec.c
+++ b/sim/erc32/exec.c
@@ -395,11 +395,11 @@ dispatch_instruction(struct pstate *sregs)
uint32 cwp, op, op2, op3, asi, rd, cond, rs1,
rs2;
- uint32 ldep, icc;
- int32 operand1, operand2, *rdd, result, eicc,
+ uint32 ldep, icc, data, *rdd;
+ int32 operand1, operand2, result, eicc,
new_cwp;
- int32 pc, npc, data, address, ws, mexc, fcc;
- int32 ddata[2];
+ int32 pc, npc, address, ws, mexc, fcc;
+ uint32 ddata[2];
sregs->ninst++;
cwp = ((sregs->psr & PSR_CWP) << 4);
@@ -1096,7 +1096,7 @@ dispatch_instruction(struct pstate *sregs)
break;
}
sregs->psr = (sregs->psr & 0xff000000) |
- (rs1 ^ operand2) & 0x00f03fff;
+ ((rs1 ^ operand2) & 0x00f03fff);
break;
case WRWIM:
if (!(sregs->psr & PSR_S)) {
@@ -1528,7 +1528,7 @@ dispatch_instruction(struct pstate *sregs)
if (sregs->frd == rd)
sregs->fhold += (sregs->ftime - ebase.simtime);
}
- mexc = memory_write(asi, address, &sregs->fsi[rd], 2, &ws);
+ mexc = memory_write(asi, address, (uint32 *)&sregs->fsi[rd], 2, &ws);
sregs->hold += ws;
if (mexc) {
sregs->trap = TRAP_DEXC;
@@ -1548,7 +1548,7 @@ dispatch_instruction(struct pstate *sregs)
if ((sregs->frd == rd) || (sregs->frd + 1 == rd))
sregs->fhold += (sregs->ftime - ebase.simtime);
}
- mexc = memory_write(asi, address, &sregs->fsi[rd], 3, &ws);
+ mexc = memory_write(asi, address, (uint32 *)&sregs->fsi[rd], 3, &ws);
sregs->hold += ws;
sregs->icnt = T_STD;
#ifdef STAT
diff --git a/sim/erc32/func.c b/sim/erc32/func.c
index ff53f3bca51..d168a31b2cd 100644
--- a/sim/erc32/func.c
+++ b/sim/erc32/func.c
@@ -139,7 +139,7 @@ set_regi(struct pstate *sregs, int32 reg, uint32 rval)
}
void
-get_regi(struct pstate * sregs, int32 reg, char *buf)
+get_regi(struct pstate * sregs, int32 reg, unsigned char *buf)
{
uint32 cwp;
uint32 rval = 0;
@@ -996,7 +996,9 @@ sys_halt(void)
#include "libiberty.h"
#include "bfd.h"
+#ifndef min
#define min(A, B) (((A) < (B)) ? (A) : (B))
+#endif
#define LOAD_ADDRESS 0
int
diff --git a/sim/erc32/sis.h b/sim/erc32/sis.h
index 7f787cf1433..98cb9ccc33d 100644
--- a/sim/erc32/sis.h
+++ b/sim/erc32/sis.h
@@ -164,21 +164,22 @@ extern void sim_halt (void);
extern void exit_sim (void);
extern void init_stdio (void);
extern void restore_stdio (void);
-extern int memory_iread (uint32 addr, uint32 *data, int32 *ws);
-extern int memory_read (int32 asi, uint32 addr, uint32 *data,
+extern int memory_iread (uint32 addr, uint32 *data, uint32 *ws);
+extern int memory_read (int32 asi, uint32 addr, void *data,
int32 sz, int32 *ws);
extern int memory_write (int32 asi, uint32 addr, uint32 *data,
int32 sz, int32 *ws);
extern int sis_memory_write (uint32 addr,
- const unsigned char *data, uint32 length);
-extern int sis_memory_read (uint32 addr, char *data,
+ const void *data, uint32 length);
+extern int sis_memory_read (uint32 addr, void *data,
uint32 length);
+extern void boot_init (void);
/* func.c */
extern struct pstate sregs;
extern void set_regi (struct pstate *sregs, int32 reg,
uint32 rval);
-extern void get_regi (struct pstate *sregs, int32 reg, char *buf);
+extern void get_regi (struct pstate *sregs, int32 reg, unsigned char *buf);
extern int exec_cmd (struct pstate *sregs, const char *cmd);
extern void reset_stat (struct pstate *sregs);
extern void show_stat (struct pstate *sregs);
--
2.33.1.windows.1.1.g7e610705a5
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-10-29 6:42 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-27 6:27 [PATCH] sim/erc32: fix signedness compatiblity and redefinition warnings Orgad Shaneh
2021-10-27 9:37 ` Mike Frysinger
2021-10-28 7:55 ` Orgad Shaneh
2021-10-29 5:31 ` Mike Frysinger
2021-10-29 6:42 Orgad Shaneh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).