From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey via Gdb-patches <gdb-patches@sourceware.org>
Cc: Tom Tromey <tromey@adacore.com>, Joel Brobecker <brobecker@adacore.com>
Subject: Re: [PATCH] Don't test interface.exp without GNAT debug info
Date: Sun, 20 Mar 2022 10:02:30 +0400 [thread overview]
Message-ID: <YjbDdoMw5YNi5R5m@adacore.com> (raw)
In-Reply-To: <20220317143905.1743262-1-tromey@adacore.com>
Hi Tom,
On Thu, Mar 17, 2022 at 08:39:05AM -0600, Tom Tromey via Gdb-patches wrote:
> The test gdb.ada/interface.exp requires some debug info in the GNAT
> runtime. When run without this info, the test can't pass. This patch
> changes the test to detect this situation and stop the test with
> "untested".
Thanks for the patch. It looks good to me.
> ---
> gdb/testsuite/gdb.ada/interface.exp | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/gdb/testsuite/gdb.ada/interface.exp b/gdb/testsuite/gdb.ada/interface.exp
> index 834da12b153..06b9660113b 100644
> --- a/gdb/testsuite/gdb.ada/interface.exp
> +++ b/gdb/testsuite/gdb.ada/interface.exp
> @@ -17,6 +17,11 @@ load_lib "ada.exp"
>
> if { [skip_ada_tests] } { return -1 }
>
> +if {![gnat_runtime_has_debug_info]} {
> + untested "GNAT runtime debuginfo required for this test"
> + return -1
> +}
> +
> standard_ada_testfile foo
>
> if {[gdb_compile_ada "${srcfile}" "${binfile}" executable [list debug additional_flags=-gnat05 ]] != "" } {
> --
> 2.34.1
>
--
Joel
next prev parent reply other threads:[~2022-03-20 6:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-17 14:39 Tom Tromey
2022-03-20 6:02 ` Joel Brobecker [this message]
2022-03-28 12:42 ` Tom Tromey
2022-04-10 19:13 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YjbDdoMw5YNi5R5m@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).