From: Alan Modra <amodra@gmail.com>
To: Mark Harmstone <mark@harmstone.com>
Cc: binutils@sourceware.org, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] pdb: Allow loading by gdb
Date: Wed, 10 May 2023 10:26:51 +0930 [thread overview]
Message-ID: <ZFrr008ZbjlqZg+Z@squeak.grove.modra.org> (raw)
In-Reply-To: <20230509003247.24156-1-mark@harmstone.com>
On Tue, May 09, 2023 at 01:32:46AM +0100, Mark Harmstone wrote:
> Add a new bfd_flavour value, and expose PDB files as objects, so that
> they get accepted by add-symbol-file.
By equating object_p and archive_p you are going to get whichever of
bfd_archive or bfd_object is tried first as the argument of
bfd_check_format (or bfd_check_format_matches). This seems fragile to
me. We have multiple binary utilities, ld, and gbd all calling
bfd_check_format. Do they all work correctly with this change, and
will they continue to work correctly with future changes?
I think you'd be better off staying with just one format, and
bfd_archive probably fits pdb files better than bfd_object.
--
Alan Modra
Australia Development Lab, IBM
next parent reply other threads:[~2023-05-10 0:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230509003247.24156-1-mark@harmstone.com>
2023-05-10 0:56 ` Alan Modra [this message]
2023-05-15 1:04 ` Mark Harmstone
2023-05-15 1:26 ` Alan Modra
2023-05-16 15:03 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZFrr008ZbjlqZg+Z@squeak.grove.modra.org \
--to=amodra@gmail.com \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=mark@harmstone.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).