public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Philippe Waroquiers <philippe.waroquiers@skynet.be>
To: Andrew Burgess <aburgess@redhat.com>,
	Philippe Waroquiers via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [RFA] Fix use after free caused by redefining a python prefix cmd that has aliases.
Date: Wed, 11 Jan 2023 11:58:24 +0100	[thread overview]
Message-ID: <a00311eaf71b0360344ced7b78829a3d79107908.camel@skynet.be> (raw)
In-Reply-To: <87fscih9e0.fsf@redhat.com>

Thanks for the comments, I will handle them (time permitting, this is an evening/weekend
activity).

Just a small initial feedback on the addition of FUN argument:

On Tue, 2023-01-10 at 12:16 +0000, Andrew Burgess wrote:
> >  static struct cmd_list_element *
> >  do_add_cmd (const char *name, enum command_class theclass,
> > +	    cmd_simple_func_ftype *fun,
> 
> A brief description of what FUN is for should be added to the comment
> above do_add_cmd.
In fact, I should have indicated in the commit msg that I have just added back
the FUN argument that was there in the past, but when it was removed, the comment
was left there.
I will dig a little bit more in depth to see when/why FUN was removed
and double check that the existing comment for FUN still correctly describes
what it now does (again?).

> 

Thanks
Philippe



      reply	other threads:[~2023-01-11 10:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-26 17:08 Philippe Waroquiers
2023-01-09 23:37 ` Philippe Waroquiers
2023-01-10 12:16 ` Andrew Burgess
2023-01-11 10:58   ` Philippe Waroquiers [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a00311eaf71b0360344ced7b78829a3d79107908.camel@skynet.be \
    --to=philippe.waroquiers@skynet.be \
    --cc=aburgess@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).