From: Bruno Larsen <blarsen@redhat.com>
To: Simon Marchi <simark@simark.ca>, gdb-patches@sourceware.org
Subject: Re: [PATCH v3] gdb: Fix issue with Clang CLI macros
Date: Thu, 3 Nov 2022 14:08:56 +0100 [thread overview]
Message-ID: <a27b7568-edba-5bb4-f07f-34c685fbbe1e@redhat.com> (raw)
In-Reply-To: <ce8f24a8-3da8-bb45-665b-633bc908bdc0@simark.ca>
On 03/11/2022 14:07, Simon Marchi wrote:
>
> On 11/3/22 08:58, Bruno Larsen via Gdb-patches wrote:
>> On 02/11/2022 13:36, Simon Marchi wrote:
>>>> +# Clang has this bug where it puts the macros defined on the command-line
>>>> +# after the main file portion (see PR 29034) and:
>>> I'm not sure if the "and" a the end is supposed to be there or not, it
>>> reads weird.
>> Oops, it was supposed to be inside the parenthesis, making it
>>
>> (see PR 29034 and https://github.com/llvm/llvm-project/issues/54506)
>>
>>
>> Is it fine if I keep it like that?
> Sure.
Thanks, pushed :)
Cheers,
Bruno
>
> Simon
>
prev parent reply other threads:[~2022-11-03 13:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 13:22 Bruno Larsen
2022-11-02 8:19 ` [PING][PATCH " Bruno Larsen
2022-11-02 12:36 ` [PATCH " Simon Marchi
2022-11-03 12:58 ` Bruno Larsen
2022-11-03 13:07 ` Simon Marchi
2022-11-03 13:08 ` Bruno Larsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a27b7568-edba-5bb4-f07f-34c685fbbe1e@redhat.com \
--to=blarsen@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).